From patchwork Mon Jul 6 08:01:47 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 27227 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 039D7C330F for ; Mon, 6 Jul 2026 08:02:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 81A2266065; Mon, 6 Jul 2026 10:02:35 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Zj1uVw7K"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BE6A866003 for ; Mon, 6 Jul 2026 10:02:14 +0200 (CEST) Received: from [192.168.125.177] (mob-109-113-60-81.net.vodafone.it [109.113.60.81]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 751913FC6; Mon, 6 Jul 2026 10:01:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1783324886; bh=NbrfAK9//1utpY5eLKzcx1k5qkbe73wBX/A1oIKCQEw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Zj1uVw7KhO8LFH2cde9kXY/6tjP1pytrGdH7MDvXzX/jLfrsP9MIzkLtvaufxLIe/ AFMNXqbXmdDotzPlK5BMSdwJ37Gn598zr2walzJZsFW/09orHLM2AKF9kZlfGXIG/N 6QF0fNZwMDsEFHDGJ4Lr5KFfgZ/l86g1kfdU5ltY= From: Jacopo Mondi Date: Mon, 06 Jul 2026 10:01:47 +0200 Subject: [PATCH v3 27/35] ipa: libipa: lsc_polynomial: Remove sensorSize_ MIME-Version: 1.0 Message-Id: <20260706-libipa-algorithms-v3-27-968757b038bb@ideasonboard.com> References: <20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com> In-Reply-To: <20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com> To: libcamera-devel@lists.libcamera.org, Stefan Klug Cc: Jacopo Mondi X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3191; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=NbrfAK9//1utpY5eLKzcx1k5qkbe73wBX/A1oIKCQEw=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqS2DykSCdQ4aftyAYXZi4twXNQViCVDBHKAFel A62UBkP6qaJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaktg8gAKCRByNAaPFqFW PEExEACIQwYR+klXV/YMd7mSsQNvbxWsiHbk/EsC8rNaM+ZpFVnOUmHEg6mPz85VqR2FcQZFvTy v7vv8QN9mZpwbSPM/JYcrUowCLXWZl1VtPOMD/7uj9MKInKTcnUGNRjQTBluEgI+xX6mrzKhacf znPuBelV3ImLNvTf2SamNoxhXyfJuSVjSO9b9GHeuO+UgJIMMvbwMEc5ZrcK45vachncTMDv7Or rtuUYZ2tDb/9U2O7VdF03zbEqIVVl+iB3o4lT0gc17g9G0NuZSwYI3aCBgLIAbqHUryd3r/F/ex W9alzMs14ZZA/tWwdLIJyBm1Yhbxayj+j10K3sGr+WOVKF3FQJTtn4FcIkfDRc09NsLYNB6+v1G Ork0r8bB5afRMPL+nyibYLiWkPg+CWKFAX0P7HDPG+cqu95q4z43ZM6qZ4dgdrY6jtQzYAz5G+q MlwA/OuqhSIFvwg4Uzd9tium1iusS0TLQxahZNQ1ER42YN4V43dD3DhyTcVv0XO07UtcUjPyYmm MS0XaGRDdVMt0g9ofr6mbfdqZV4qTgn+Bt6zmQK+RIn2FZP6cJNWMQ+hnefyj3C7xP6kRDxGCHq l4GdWfBn28RNpfjY4b6dhrohanwLWVTEjHxgBrFU0SFMlcR6tNSZ+oyXmLaS6noqDPSmCFUHaVP OmOAMiuk7zahDDA== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The sensorSize_ field is only used during the init() function and is provided to LscPolynomial using the LscDescriptor type. There is no need to store it as a class member and to pass it in at class construction time. Remove it and move the \todo comment in the LscDescriptor type documentation. Signed-off-by: Jacopo Mondi --- src/ipa/libipa/lsc.cpp | 6 +----- src/ipa/libipa/lsc_base.cpp | 3 +++ src/ipa/libipa/lsc_polynomial.cpp | 7 ------- src/ipa/libipa/lsc_polynomial.h | 6 ------ 4 files changed, 4 insertions(+), 18 deletions(-) diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp index c860569ccee4..804bbc2915e4 100644 --- a/src/ipa/libipa/lsc.cpp +++ b/src/ipa/libipa/lsc.cpp @@ -215,11 +215,7 @@ int LscAlgorithm::init(const ValueNode &tuningData, ControlInfoMap::Map &control impl_ = std::make_unique(); LOG(Lsc, Debug) << "Using table-based Lsc"; } else if (type == "polynomial") { - /* - * \todo: Most likely the reference frame should be native_size. - * Let's wait how the internal discussions progress. - */ - impl_ = std::make_unique(descriptor.sensorSize); + impl_ = std::make_unique(); polynomial_ = true; LOG(Lsc, Debug) << "Using polynomial Lsc"; } else { diff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp index 30af8d970a12..7de6ee70e7a0 100644 --- a/src/ipa/libipa/lsc_base.cpp +++ b/src/ipa/libipa/lsc_base.cpp @@ -78,6 +78,9 @@ void Interpolator:: * \var LscDescriptor::sensorSize * \brief The physical sensor size. This is the largest frame size used to * generate the lsc table. Only used by the polynomial lsc algorithm + * + * \todo: Most likely the reference frame should be native_size. + * Let's wait how the internal discussions progress. */ /** diff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp index 0550229b5152..013a4469546e 100644 --- a/src/ipa/libipa/lsc_polynomial.cpp +++ b/src/ipa/libipa/lsc_polynomial.cpp @@ -123,13 +123,6 @@ void Polynomial::setReferenceImageSize(const Size &size) * \sa LscImplementation */ -/** - * \fn LscPolynomial::LscPolynomial - * \param[in] sensorSize The physical sensor size - * - * Construct an LscPolynomial - */ - /** * \brief Parse polynomial lsc data * \param[in] sets The tuning file content diff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h index 2a26db499d68..6d19e46a50b7 100644 --- a/src/ipa/libipa/lsc_polynomial.h +++ b/src/ipa/libipa/lsc_polynomial.h @@ -57,11 +57,6 @@ private: using PolynomialComponentsMap = std::map; public: - LscPolynomial(const Size &sensorSize) - : sensorSize_(sensorSize) - { - } - int parseLscData(const ValueNode &sets, const LscDescriptor &descriptor) override; @@ -75,7 +70,6 @@ private: Span yPositions, const Rectangle &cropRectangle); PolynomialComponentsMap lscData_; - Size sensorSize_; }; } /* namespace ipa */