@@ -215,11 +215,7 @@ int LscAlgorithm::init(const ValueNode &tuningData, ControlInfoMap::Map &control
impl_ = std::make_unique<LscTable>();
LOG(Lsc, Debug) << "Using table-based Lsc";
} else if (type == "polynomial") {
- /*
- * \todo: Most likely the reference frame should be native_size.
- * Let's wait how the internal discussions progress.
- */
- impl_ = std::make_unique<LscPolynomial>(descriptor.sensorSize);
+ impl_ = std::make_unique<LscPolynomial>();
polynomial_ = true;
LOG(Lsc, Debug) << "Using polynomial Lsc";
} else {
@@ -78,6 +78,9 @@ void Interpolator<lsc::Components>::
* \var LscDescriptor::sensorSize
* \brief The physical sensor size. This is the largest frame size used to
* generate the lsc table. Only used by the polynomial lsc algorithm
+ *
+ * \todo: Most likely the reference frame should be native_size.
+ * Let's wait how the internal discussions progress.
*/
/**
@@ -123,13 +123,6 @@ void Polynomial::setReferenceImageSize(const Size &size)
* \sa LscImplementation
*/
-/**
- * \fn LscPolynomial::LscPolynomial
- * \param[in] sensorSize The physical sensor size
- *
- * Construct an LscPolynomial
- */
-
/**
* \brief Parse polynomial lsc data
* \param[in] sets The tuning file content
@@ -57,11 +57,6 @@ private:
using PolynomialComponentsMap = std::map<unsigned int, PolynomialComponents>;
public:
- LscPolynomial(const Size &sensorSize)
- : sensorSize_(sensorSize)
- {
- }
-
int parseLscData(const ValueNode &sets,
const LscDescriptor &descriptor) override;
@@ -75,7 +70,6 @@ private:
Span<const double> yPositions,
const Rectangle &cropRectangle);
PolynomialComponentsMap lscData_;
- Size sensorSize_;
};
} /* namespace ipa */
The sensorSize_ field is only used during the init() function and is provided to LscPolynomial using the LscDescriptor type. There is no need to store it as a class member and to pass it in at class construction time. Remove it and move the \todo comment in the LscDescriptor type documentation. Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> --- src/ipa/libipa/lsc.cpp | 6 +----- src/ipa/libipa/lsc_base.cpp | 3 +++ src/ipa/libipa/lsc_polynomial.cpp | 7 ------- src/ipa/libipa/lsc_polynomial.h | 6 ------ 4 files changed, 4 insertions(+), 18 deletions(-)