Patch Detail
Show a patch.
GET /api/patches/27115/?format=api
{ "id": 27115, "url": "https://patchwork.libcamera.org/api/patches/27115/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27115/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260629163017.863145-37-barnabas.pocze@ideasonboard.com>", "date": "2026-06-29T16:29:59", "name": "[RFC,v1,36/54] libcamera: request: completeBuffer(): Emit `bufferCompleted` last", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2a96645fdcf536e91bab2e08f0b5116d906e71f5", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27115/mbox/", "series": [ { "id": 6025, "url": "https://patchwork.libcamera.org/api/series/6025/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6025", "date": "2026-06-29T16:29:23", "name": "libcamera: Split requests and buffers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6025/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27115/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27115/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA933C3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Jun 2026 16:31:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6F91465F96;\n\tMon, 29 Jun 2026 18:31:27 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0071865F60\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Jun 2026 18:30:29 +0200 (CEST)", "from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D034E1044\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Jun 2026 18:29:45 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kDObMemi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750585;\n\tbh=mNPadciu9eF3j/cPMIbZCENrQJr8XUSe8TAg7lA7gMs=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=kDObMemiboYftLsRocaOla0OquvBUMW9GkgEA4lYavRx9MkI5MEo9QY18x0SAjjzI\n\tl87iCwldWmwG6sP0vwcu2V+iN5/2YJukgf1qR3V7J3lRod14Oox20MuduRti8Jv41E\n\tnQhIMcEt43IbCuV+MRGYAD2KHl/CDf1C2wOSoxi8=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 36/54] libcamera: request: completeBuffer(): Emit\n\t`bufferCompleted` last", "Date": "Mon, 29 Jun 2026 18:29:59 +0200", "Message-ID": "<20260629163017.863145-37-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "References": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To ensure that the application can see the buffer in the request's\nbuffer map.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/request.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex d7cf39ae2e..ecdf558066 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -108,8 +108,6 @@ bool Request::Private::completeBuffer(FrameBuffer *buffer)\n \tLIBCAMERA_TRACEPOINT(request_complete_buffer, this, buffer);\n \n \tRequest *request = LIBCAMERA_O_PTR();\n-\tcamera_->bufferCompleted.emit(request, buffer);\n-\n \tauto it = request->bufferMap_.find(buffer->_d()->stream_);\n \tASSERT(it != request->bufferMap_.end());\n \tASSERT(it->second == buffer || !it->second);\n@@ -124,6 +122,8 @@ bool Request::Private::completeBuffer(FrameBuffer *buffer)\n \tif (buffer->metadata().status == FrameMetadata::FrameCancelled)\n \t\tcancelled_ = true;\n \n+\tcamera_->bufferCompleted.emit(request, buffer);\n+\n \treturn !hasPendingBuffers();\n }\n \n", "prefixes": [ "RFC", "v1", "36/54" ] }