Patch Detail
Show a patch.
GET /api/patches/27062/?format=api
{ "id": 27062, "url": "https://patchwork.libcamera.org/api/patches/27062/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27062/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260626-ipu3-libipa-rework-v2-2-41546e23de3e@ideasonboard.com>", "date": "2026-06-26T13:05:49", "name": "[v2,02/12] ipu3: awb: Remove CCM settings from Awb algorithm", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "66c338e055df6dd86e80e69d389547289d8ceb17", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27062/mbox/", "series": [ { "id": 6022, "url": "https://patchwork.libcamera.org/api/series/6022/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6022", "date": "2026-06-26T13:05:47", "name": "libipa: Re-work IPU3 IPA to use libipa algorithms", "version": 2, "mbox": "https://patchwork.libcamera.org/series/6022/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27062/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27062/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7EF85C3302\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 26 Jun 2026 13:06:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C5BE65EFC;\n\tFri, 26 Jun 2026 15:06:09 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30D8A65878\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Jun 2026 15:06:05 +0200 (CEST)", "from [127.0.1.1]\n\t(chfd-03-b2-v4wan-176392-cust229.vm15.cable.virginm.net\n\t[82.19.20.230])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 388631438;\n\tFri, 26 Jun 2026 15:05:24 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AI91Hf46\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782479124;\n\tbh=Pd82DKCym4GNm+qhZLWfJ/wUXOexPxja3Fmk9clyA+8=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=AI91Hf46dXe2hvokniyM6iNhtA5nDNem6JUh65p/vp7O1EcW+3zkGX6NsOkSqcDQO\n\tecSBZDJXRRgUyJNpKQBkaEAwlahbIJ+gbV9dJaT7tYoq3mrM59eaZWcHUVto9luoNR\n\tjOVAY9zGe5yHyYv9ReRFP5QUU3tBdEKLlcEtXKwU=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "Date": "Fri, 26 Jun 2026 14:05:49 +0100", "Subject": "[PATCH v2 02/12] ipu3: awb: Remove CCM settings from Awb algorithm", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260626-ipu3-libipa-rework-v2-2-41546e23de3e@ideasonboard.com>", "References": "<20260626-ipu3-libipa-rework-v2-0-41546e23de3e@ideasonboard.com>", "In-Reply-To": "<20260626-ipu3-libipa-rework-v2-0-41546e23de3e@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Daniel Scally <dan.scally@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_?=\n\t=?utf-8?b?UMWRY3pl?= <barnabas.pocze@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1552;\n\ti=dan.scally@ideasonboard.com; h=from:subject:message-id;\n\tbh=Pd82DKCym4GNm+qhZLWfJ/wUXOexPxja3Fmk9clyA+8=;\n\tb=owEBbQKS/ZANAwAKAchJV3psRXUyAcsmYgBqPnk5VN/fZ4OasjtS5p87+TQnoCcSuiY+PSYLj\n\ttI7A51lVv6JAjMEAAEKAB0WIQQqyuwyDnZdb+mxmm/ISVd6bEV1MgUCaj55OQAKCRDISVd6bEV1\n\tMtWuD/4+Zy8cgnPlJ3aI61KtapPFQTaGF4v9Beo5OOWTXdGvKqUnY58WW2Ps35uEjaTNlF/LSjR\n\tub60J7eVXF1HT/J1Kh2sNd1b0V+NQtWSovCHYZ0PdkoIUcTenHYV7WcyJrbcSGN0Lw5Rexa1m5Z\n\t5/O8xtv4IXtIfM52pGRgoNTgMwBNceC48Ooow3XzokBZKuE1YQz9wiNtM97HqwKRU6HO7wkRreT\n\tFxGRL3I5+uIn38d1lHJe1gv+/x4idrFe7+Onn5lMEaBIjmb1bYwJJYrVyzzR56cMQhnWdRzSjib\n\tbqdII025rmNvRzkBsWIMmGBUZQGmga1Pd+EP+etHPwoZkptEN4/bDXa5Icf1DY+XduZP9Au8kXu\n\tBXNUtmxoQyrTgHil/ba08iH10f33bAOCAG255+hpTZ+yUzUN3hZhtPOxFXO7kOBH/1Q/wJP0yhz\n\t2Z0e8TPYveMbn1tlStTPvj6Hd+/hUhlWFmLF/dj0HZque21yuODmk6IsUpVbWAqNpO7Y94aMznh\n\t+iVELMkXb3T3fx+G3Kl+8fl5kMUoiahooIlF5ycBOxpyvmO/5so0rUhIQQjrVqyUkj+plqOTdNc\n\tU08C3v3h/3O+hu4Ywo4SV0Q+sqnH397wxsXHtDklHrvJ+sYhFjMRumPBprHoTYZ3Krks7GZ8YDv\n\tC4TEdGGgirYVSQQ==", "X-Developer-Key": "i=dan.scally@ideasonboard.com; a=openpgp;\n\tfpr=EEC699ACA1B7CB5D31330C0BBD501C2A3546CCF6", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The IPU3 AWB algorithm currently defines a CCM matrix that is just\na no-op. Remove the settings entirely; they need really to go in to\na dedicated CCM algorithm.\n\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\nChanges in v2:\n\n - None\n---\n src/ipa/ipu3/algorithms/awb.cpp | 10 ----------\n 1 file changed, 10 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 6b4418aa6f3add0a41cae77000c1f5f67897111a..613bdbbf51cd127e03906571813260a6857067dc 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -112,13 +112,6 @@ static const struct ipu3_uapi_bnr_static_config imguCssBnrDefaults = {\n \t.opt_center_sqr = { 419904, 133956 },\n };\n \n-/* Default color correction matrix defined as an identity matrix */\n-static const struct ipu3_uapi_ccm_mat_config imguCssCcmDefault = {\n-\t8191, 0, 0, 0,\n-\t0, 8191, 0, 0,\n-\t0, 0, 8191, 0\n-};\n-\n /**\n * \\class Awb\n * \\brief A Grey world white balance correction algorithm\n@@ -293,12 +286,9 @@ void Awb::prepare(IPAContext &context,\n \n \tLOG(IPU3Awb, Debug) << \"Color temperature estimated: \" << asyncResults_.temperatureK;\n \n-\t/* The CCM matrix may change when color temperature will be used */\n-\tparams->acc_param.ccm = imguCssCcmDefault;\n \n \tparams->use.acc_awb = 1;\n \tparams->use.acc_bnr = 1;\n-\tparams->use.acc_ccm = 1;\n }\n \n /* Generate an RGB vector with the average values for each zone */\n", "prefixes": [ "v2", "02/12" ] }