[{"id":39497,"web_url":"https://patchwork.libcamera.org/comment/39497/","msgid":"<178272725900.36676.7225664345388163285@ping.linuxembedded.co.uk>","date":"2026-06-29T10:00:59","subject":"Re: [PATCH v2 02/12] ipu3: awb: Remove CCM settings from Awb\n\talgorithm","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Scally (2026-06-26 14:05:49)\n> The IPU3 AWB algorithm currently defines a CCM matrix that is just\n> a no-op. Remove the settings entirely; they need really to go in to\n> a dedicated CCM algorithm.\n> \n> Reviewed-by: Barnabás Pőcze \n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Daniel Scally \n> ---\n> Changes in v2:\n> \n> - None\n> ---\n> src/ipa/ipu3/algorithms/awb.cpp | 10 ----------\n> 1 file changed, 10 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\n> index 6b4418aa6f3add0a41cae77000c1f5f67897111a..613bdbbf51cd127e03906571813260a6857067dc 100644\n> --- a/src/ipa/ipu3/algorithms/awb.cpp\n> +++ b/src/ipa/ipu3/algorithms/awb.cpp\n> @@ -112,13 +112,6 @@ static const struct ipu3_uapi_bnr_static_config imguCssBnrDefaults = {\n> .opt_center_sqr = { 419904, 133956 },\n> };\n> \n> -/* Default color correction matrix defined as an identity matrix */\n> -static const struct ipu3_uapi_ccm_mat_config imguCssCcmDefault = {\n> - 8191, 0, 0, 0,\n> - 0, 8191, 0, 0,\n> - 0, 0, 8191, 0\n> -};\n> -\n> /**\n> * \\class Awb\n> * \\brief A Grey world white balance correction algorithm\n> @@ -293,12 +286,9 @@ void Awb::prepare(IPAContext &context,\n> \n> LOG(IPU3Awb, Debug) << \"Color temperature estimated: \" << asyncResults_.temperatureK;\n> \n> - /* The CCM matrix may change when color temperature will be used */\n> - params->acc_param.ccm = imguCssCcmDefault;\n> \n> params->use.acc_awb = 1;\n> params->use.acc_bnr = 1;\n> - params->use.acc_ccm = 1;\n> }\n> \n> /* Generate an RGB vector with the average values for each zone */\n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 368E3C3261\n\tfor ;\n\tMon, 29 Jun 2026 10:01:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA13D65F19;\n\tMon, 29 Jun 2026 12:01:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0764965F04\n\tfor ;\n\tMon, 29 Jun 2026 12:01:02 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0589E8D4;\n\tMon, 29 Jun 2026 12:00:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VY6gFM4Y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782727219;\n\tbh=0RvRKVfg4NH6X0brBUwEq+W47ooyTKK/tRqFaEYKvv8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=VY6gFM4Y8dCxJ76q3R/JoLu8MtmxafFIeJo63Wu0wuwiiTcbSxZZpUTnLV/wtZiK/\n\t6vbZpggaRXLUoRGOHAZnDrIz/VBTnySBTTymfGzCwIAADPXYPQxnwh5rEaf9ewnXZW\n\t7Ye7RxU3MXAMakkii/EJBiziF+0SmEvC4VCVBQsE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260626-ipu3-libipa-rework-v2-2-41546e23de3e@ideasonboard.com>","References":"<20260626-ipu3-libipa-rework-v2-0-41546e23de3e@ideasonboard.com>\n\t<20260626-ipu3-libipa-rework-v2-2-41546e23de3e@ideasonboard.com>","Subject":"Re: [PATCH v2 02/12] ipu3: awb: Remove CCM settings from Awb\n\talgorithm","From":"Kieran Bingham ","Cc":"Daniel Scally , =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= ","To":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 29 Jun 2026 11:00:59 +0100","Message-ID":"<178272725900.36676.7225664345388163285@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39639,"web_url":"https://patchwork.libcamera.org/comment/39639/","msgid":"","date":"2026-07-08T15:14:42","subject":"Re: [PATCH v2 02/12] ipu3: awb: Remove CCM settings from Awb\n\talgorithm","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Dan\n\nOn Fri, Jun 26, 2026 at 02:05:49PM +0100, Daniel Scally wrote:\n> The IPU3 AWB algorithm currently defines a CCM matrix that is just\n> a no-op. Remove the settings entirely; they need really to go in to\n> a dedicated CCM algorithm.\n>\n> Reviewed-by: Barnabás Pőcze \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> Changes in v2:\n>\n> - None\n> ---\n> src/ipa/ipu3/algorithms/awb.cpp | 10 ----------\n> 1 file changed, 10 deletions(-)\n>\n> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\n> index 6b4418aa6f3add0a41cae77000c1f5f67897111a..613bdbbf51cd127e03906571813260a6857067dc 100644\n> --- a/src/ipa/ipu3/algorithms/awb.cpp\n> +++ b/src/ipa/ipu3/algorithms/awb.cpp\n> @@ -112,13 +112,6 @@ static const struct ipu3_uapi_bnr_static_config imguCssBnrDefaults = {\n> \t.opt_center_sqr = { 419904, 133956 },\n> };\n>\n> -/* Default color correction matrix defined as an identity matrix */\n> -static const struct ipu3_uapi_ccm_mat_config imguCssCcmDefault = {\n> -\t8191, 0, 0, 0,\n> -\t0, 8191, 0, 0,\n> -\t0, 0, 8191, 0\n> -};\n> -\n> /**\n> * \\class Awb\n> * \\brief A Grey world white balance correction algorithm\n> @@ -293,12 +286,9 @@ void Awb::prepare(IPAContext &context,\n>\n> \tLOG(IPU3Awb, Debug) << \"Color temperature estimated: \" << asyncResults_.temperatureK;\n>\n> -\t/* The CCM matrix may change when color temperature will be used */\n> -\tparams->acc_param.ccm = imguCssCcmDefault;\n>\n> \tparams->use.acc_awb = 1;\n> \tparams->use.acc_bnr = 1;\n> -\tparams->use.acc_ccm = 1;\n> }\n>\n> /* Generate an RGB vector with the average values for each zone */\n>\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B7E2C3261\n\tfor ;\n\tWed, 8 Jul 2026 15:14:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD7F766094;\n\tWed, 8 Jul 2026 17:14:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D719861451\n\tfor ;\n\tWed, 8 Jul 2026 17:14:45 +0200 (CEST)","from ideasonboard.com (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D54D8EAA;\n\tWed, 8 Jul 2026 17:13:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JwCEAizN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783523635;\n\tbh=Z3Fd9Zc7JbtPqS+sgnytYvcTRZJbN7Fc3kZtJh5aVu0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JwCEAizNt7MCeCyGlTc16IdjV3SVeRo8zqoJjoUdT7GVu4WaY3Q4JhILA4hk/x6H4\n\tk7CLXYvR2/06oZxqrEuW0v69tNKN6xbYkhMEGi3y0aWH3PO7G+QT54nstjag/5mS9g\n\tw01rIYy3EH1seT6bfZau2qfr63YWUpgaT4qjP0To=","Date":"Wed, 8 Jul 2026 17:14:42 +0200","From":"Jacopo Mondi ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= ","Subject":"Re: [PATCH v2 02/12] ipu3: awb: Remove CCM settings from Awb\n\talgorithm","Message-ID":"","References":"<20260626-ipu3-libipa-rework-v2-0-41546e23de3e@ideasonboard.com>\n\t<20260626-ipu3-libipa-rework-v2-2-41546e23de3e@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260626-ipu3-libipa-rework-v2-2-41546e23de3e@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]