Patch Detail
Show a patch.
GET /api/patches/27030/?format=api
{ "id": 27030, "url": "https://patchwork.libcamera.org/api/patches/27030/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27030/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260624085849.873784-5-bryan.odonoghue@linaro.org>", "date": "2026-06-24T08:58:43", "name": "[04/10] libcamera: egl: Rename createTexture2D to createInputTexture2D", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9a45568a88b0611738d06925374c3b3b2e76ee4b", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27030/mbox/", "series": [ { "id": 6015, "url": "https://patchwork.libcamera.org/api/series/6015/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6015", "date": "2026-06-24T08:58:39", "name": "libcamera: software_isp: gpu: Add go faster stripes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6015/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27030/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27030/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C690C3306\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 24 Jun 2026 08:59:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EBB226587B;\n\tWed, 24 Jun 2026 10:59:10 +0200 (CEST)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DEDC65880\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Jun 2026 10:59:03 +0200 (CEST)", "by mail-wm1-x335.google.com with SMTP id\n\t5b1f17b1804b1-4926046fbc5so6661425e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Jun 2026 01:59:03 -0700 (PDT)", "from inspiron14p-linux ([109.76.100.231])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-49261063d6esm25128375e9.2.2026.06.24.01.59.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 24 Jun 2026 01:59:02 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"eLKUrkqx\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1782291543; x=1782896343;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=x3IY0F3UjUxJGXv2KSdGvBjFnMvOa+oW1cFk+rb0RrQ=;\n\tb=eLKUrkqxewYZVUwRFvuhQtLJBGdBVuhs8oTFNjABp3peVUCulttA581hiX68ekvNE4\n\tfsQi1djEVhl//Hs1ntN86SPbp9hdj+AT0YuGQYe2o73QUTJxb689PDupI8VswojYodt5\n\tT+ahSXY55sGa4KwKJxNc4C5rc84Y9aUaEISiaAQg5V1l+Qwh1aFn7JkbV+//bE0NGI33\n\t01/LM5qTcHPRB23I7gkDP0XSqVlb/3DpBjHJu5FA6kzSSKPGYdt1LiGe3+Eual4P1ctQ\n\tgqhHgm4qbDco+r4Q1Nqpa5kk61MtIWv4T36T1izArDKn6mqhH/xg6RjJdeiLvv4vhPGW\n\t9NGw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1782291543; x=1782896343;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=x3IY0F3UjUxJGXv2KSdGvBjFnMvOa+oW1cFk+rb0RrQ=;\n\tb=iXehcFrSOmmQin5rVq9fzlM3I6M78Eiky2NVSQ23MO9E0i/E8qSnatoOBU34Rj2es0\n\tEv7iFWehcglKYOheUqSoN5Yqd632HrEWEa/BPmm+sIgrLFPOJzjhS/zRYA8gUCO/Iz+v\n\t21uaJtmX5wHgsi9JonybwGtZYvdrEzC/RSZ9XCwf/0x1beiZPKYg62uQ+z/EDhlvrht5\n\taHiONSo5ujHDVxCPek0Xw5T7j5/PCghE7OxgkshzJjJ4uPbJk2Hl5HRF9outboBoC7b3\n\tJHdh/lO9xKMUncXrdse2FAyyv/f3Qq9HJrIkRmhQdtl5tiUbeIihWrgCT+6qw5MEFMxU\n\t+sBw==", "X-Gm-Message-State": "AOJu0YwwzKT6mGbFInDd4/Fra5B35FhwXZ2rR2GzOrwdPfEpKc+w39sP\n\tnbutMBA9vmgnJVoYm1PVRXZJwQW/N/iGeGSYWQyA0QU8/1aPOjj7+bgogjrQd11X9mILmhhJPw4\n\t8qwoJgtA=", "X-Gm-Gg": "AfdE7clOG2bJD9leIgiOA4H56WTfjiWhp8Af2a9L+W7F3xUtEWJkvbxulpPkkzBwko+\n\t7x5UAWJhiJaeQ/8YhFQGhMS2x0E3gk8w3SHLwxUHBXV4UZh9j6A+hwj+aaeMDt0YF3r2Yxm5zjs\n\tJw2DObsFl0D7a/m1x38bNPkqELTyG9kxlzpZSxMwfTXc0luNzXrha3aR3nV3UEYTYADbzPnVQ9Q\n\tbZEsF2vBFFWp/Cr4f67TxODSfvtoZeot3fXZBqSJg5+XVYOrLlKE0cCkJ9j98lnTQg1sFHtloLI\n\taPNaA5UAjg72Ks9ksOlBgWqCvJnKI4we3BaBWjMSRrnjURmt4cOhMzOZc9GBXHI1UtcxABYULyV\n\tZyjF1GuPQfJsptwC3w0AKYhOrcCHRxN5mXW57vemyaxQp+vj5TxPAXQbx1ueoWQO1xRpv1Tp68c\n\t8akniKHpOMIvXiQNrh0gFeAmr+NnIZ", "X-Received": "by 2002:a05:600c:6692:b0:490:c1cb:48f4 with SMTP id\n\t5b1f17b1804b1-4925a0b5505mr87016355e9.12.1782291542952; \n\tWed, 24 Jun 2026 01:59:02 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "bryan.odonoghue@linaro.org,\n\tpavel@ucw.cz", "Subject": "[PATCH 04/10] libcamera: egl: Rename createTexture2D to\n\tcreateInputTexture2D", "Date": "Wed, 24 Jun 2026 09:58:43 +0100", "Message-ID": "<20260624085849.873784-5-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260624085849.873784-1-bryan.odonoghue@linaro.org>", "References": "<20260624085849.873784-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Right now this routine makes a texture from a supplied data-buffer. It\nshould have a more descriptive and accurate name.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/egl.h | 2 +-\n src/libcamera/egl.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex 4b0757afd..0709f9019 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -107,7 +107,7 @@ public:\n \n \tint createInputDMABufTexture2D(eGLImage &eglImage, int fd);\n \tint createOutputDMABufTexture2D(eGLImage &eglImage, int fd);\n-\tvoid createTexture2D(eGLImage &eglImage, void *data);\n+\tvoid createInputTexture2D(eGLImage &eglImage, void *data);\n \n \tint attachTextureToFBO(eGLImage &eglImage);\n \ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 8d80a6d1a..2825d34d3 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -266,7 +266,7 @@ int eGL::createOutputDMABufTexture2D(eGLImage &eglImage, int fd)\n * is useful for uploading static data like lookup tables or uniform color\n * matrices to the GPU.\n */\n-void eGL::createTexture2D(eGLImage &eglImage, void *data)\n+void eGL::createInputTexture2D(eGLImage &eglImage, void *data)\n {\n \tGLenum format;\n \tGLenum type = GL_UNSIGNED_BYTE;\n", "prefixes": [ "04/10" ] }