[{"id":39381,"web_url":"https://patchwork.libcamera.org/comment/39381/","msgid":"<3da38a50-8805-4353-ae74-0e1a076d81c5@collabora.com>","date":"2026-06-24T12:03:49","subject":"Re: [PATCH 04/10] libcamera: egl: Rename createTexture2D to\n\tcreateInputTexture2D","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"IMO the naming is not really more descriptive and accurate, especially \nas in the next commit it's used in createOutputTexture2D()\". So I kinda \nwould have preferred to make createTexture2D private and call it from \nboth createInputTexture2D() and createOutputTexture2D(). No strong \nopinion though.\n\nOn 24.06.26 10:58, Bryan O'Donoghue wrote:\n> Right now this routine makes a texture from a supplied data-buffer. It\n> should have a more descriptive and accurate name.\n>\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> include/libcamera/internal/egl.h | 2 +-\n> src/libcamera/egl.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\n> index 4b0757afd..0709f9019 100644\n> --- a/include/libcamera/internal/egl.h\n> +++ b/include/libcamera/internal/egl.h\n> @@ -107,7 +107,7 @@ public:\n> \n> \tint createInputDMABufTexture2D(eGLImage &eglImage, int fd);\n> \tint createOutputDMABufTexture2D(eGLImage &eglImage, int fd);\n> -\tvoid createTexture2D(eGLImage &eglImage, void *data);\n> +\tvoid createInputTexture2D(eGLImage &eglImage, void *data);\n> \n> \tint attachTextureToFBO(eGLImage &eglImage);\n> \n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index 8d80a6d1a..2825d34d3 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -266,7 +266,7 @@ int eGL::createOutputDMABufTexture2D(eGLImage &eglImage, int fd)\n> * is useful for uploading static data like lookup tables or uniform color\n> * matrices to the GPU.\n> */\n> -void eGL::createTexture2D(eGLImage &eglImage, void *data)\n> +void eGL::createInputTexture2D(eGLImage &eglImage, void *data)\n> {\n> \tGLenum format;\n> \tGLenum type = GL_UNSIGNED_BYTE;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55DFEC3306\n\tfor ;\n\tWed, 24 Jun 2026 12:04:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A97E65899;\n\tWed, 24 Jun 2026 14:03:59 +0200 (CEST)","from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com\n\t[136.143.188.12])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1370365718\n\tfor ;\n\tWed, 24 Jun 2026 14:03:56 +0200 (CEST)","by mx.zohomail.com with SMTPS id 178230263138064.76116945117315;\n\tWed, 24 Jun 2026 05:03:51 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"cVL2SRMK\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1782302634; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=Iui/vzGbieLjy7w5YFs+urc00Ejim1oStunlaz6gBx0XsoxzvjY1wRBQiyir29ejG3RW0eASwzdBbm940rkk3KdXY6kCth4aOy77npeXm2aBgj6fRP/WWsfWCEbzpKrGwdMTin7zSY2ES1vXlaCMKkVqIyPVQQgXhZ71+ovAIjw=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1782302634;\n\th=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=t7OnHF+9V4nxJQCwNMNaZny9xsx7jPs3Oi1J+GltDR8=; \n\tb=B8IdL5y1FQGTS+OBf5mGh92M3aAc/hLSwLpfg1zPyEpSf9qo78x8knIqLA8Af/x0+ezhpo2avK74YVNo4HEV8jeKSVspqyNUBebG0qMrtgq96RvZF+13Eb5NIfKJq7wxUyJakxFQv8aMzCM+ciOrKX5TINScyYVM81F6eKqBRlE=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1782302634;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc;\n\tbh=t7OnHF+9V4nxJQCwNMNaZny9xsx7jPs3Oi1J+GltDR8=;\n\tb=cVL2SRMKkJTT/pERoUK7ZSuynQjLYt7Z6CT73NWN2PHkn5/hPIa9Mn5SRHmyZafk\n\ty2XrnyUjt6HFhIx6pAEpEBQFrszdqG5CHvr4xa7c2k3ZsU4rLYKNHRB7VlfoT6C36IH\n\t4XXKGUOrFCVf45ukqKnsFbgAAd7kI20H4zlUztGU=","Message-ID":"<3da38a50-8805-4353-ae74-0e1a076d81c5@collabora.com>","Date":"Wed, 24 Jun 2026 14:03:49 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 04/10] libcamera: egl: Rename createTexture2D to\n\tcreateInputTexture2D","To":"libcamera-devel@lists.libcamera.org","References":"<20260624085849.873784-1-bryan.odonoghue@linaro.org>\n\t<20260624085849.873784-5-bryan.odonoghue@linaro.org>","Content-Language":"en-US, de-DE, en-GB","From":"Robert Mader ","In-Reply-To":"<20260624085849.873784-5-bryan.odonoghue@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39444,"web_url":"https://patchwork.libcamera.org/comment/39444/","msgid":"<85qzltlg7o.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-06-26T10:59:55","subject":"Re: [PATCH 04/10] libcamera: egl: Rename createTexture2D to\n\tcreateInputTexture2D","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> Right now this routine makes a texture from a supplied data-buffer. It\n> should have a more descriptive and accurate name.\n\nWhen on it, does this from the method docstring still apply?\n\n * This is useful for uploading static data like lookup tables or\n * uniform color matrices to the GPU.\n\nIt looks like it's used for different purposes now.\n\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> include/libcamera/internal/egl.h | 2 +-\n> src/libcamera/egl.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\n> index 4b0757afd..0709f9019 100644\n> --- a/include/libcamera/internal/egl.h\n> +++ b/include/libcamera/internal/egl.h\n> @@ -107,7 +107,7 @@ public:\n> \n> \tint createInputDMABufTexture2D(eGLImage &eglImage, int fd);\n> \tint createOutputDMABufTexture2D(eGLImage &eglImage, int fd);\n> -\tvoid createTexture2D(eGLImage &eglImage, void *data);\n> +\tvoid createInputTexture2D(eGLImage &eglImage, void *data);\n> \n> \tint attachTextureToFBO(eGLImage &eglImage);\n> \n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index 8d80a6d1a..2825d34d3 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -266,7 +266,7 @@ int eGL::createOutputDMABufTexture2D(eGLImage &eglImage, int fd)\n> * is useful for uploading static data like lookup tables or uniform color\n> * matrices to the GPU.\n> */\n> -void eGL::createTexture2D(eGLImage &eglImage, void *data)\n> +void eGL::createInputTexture2D(eGLImage &eglImage, void *data)\n> {\n> \tGLenum format;\n> \tGLenum type = GL_UNSIGNED_BYTE;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DF942BF415\n\tfor ;\n\tFri, 26 Jun 2026 11:00:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70F61658F8;\n\tFri, 26 Jun 2026 13:00:03 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DCE7565878\n\tfor ;\n\tFri, 26 Jun 2026 13:00:01 +0200 (CEST)","from mail-wr1-f69.google.com (mail-wr1-f69.google.com\n\t[209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-584-baH0rrFNMWKiwYbgb8Qi2A-1; Fri, 26 Jun 2026 06:59:59 -0400","by mail-wr1-f69.google.com with SMTP id\n\tffacd0b85a97d-46d8f6df1e6so382265f8f.2\n\tfor ;\n\tFri, 26 Jun 2026 03:59:59 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-4.net.vodafone.cz. [77.48.47.4])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-49268fc0f32sm71545995e9.3.2026.06.26.03.59.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 26 Jun 2026 03:59:56 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"XSwoFpPJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1782471601;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=U+10tVjG9otaANDvWaOX7wT5LKBiJUDQ+rgxaCnu9j0=;\n\tb=XSwoFpPJsIEFQyOD63e1ectT/oUds83MArR7QhWsed9IJ4g2m+8+pnCJPq/iSreYlKXXZf\n\t8VHwURp3azIGwiJEZLybkI0NoIdh/YJN24x1ghAwX0ZJBTiJcb2T1s7vKHGOP4yZzIgB3R\n\tuySp5NPLw3FeaS1WvLIP7XxfMlYNN2g=","X-MC-Unique":"baH0rrFNMWKiwYbgb8Qi2A-1","X-Mimecast-MFC-AGG-ID":"baH0rrFNMWKiwYbgb8Qi2A_1782471598","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1782471598; x=1783076398;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=U+10tVjG9otaANDvWaOX7wT5LKBiJUDQ+rgxaCnu9j0=;\n\tb=N3e9cS5IPzBkvgMNTjw+J++RdRmnc50ITUpNq70fWoX3XdphanqtvipHPqdBXgQTvZ\n\tTBvEFMMaXsH+1Ts/V9+HF9/LVQAhEnYnx5tHDrtk/APf7r6TgA5O5SQeUaBrYVqe7dXe\n\tcXRut5DUR/SHEpnCF0JDpNkoIPPSOqW2Ag7ua5RL/7aTA2TZtd0jGGUavX6bWQRFmk/k\n\tRu/J/XL8BtJknVKyrVkkpn1SEJ+/nQQtUgeszDy1NG70as/T+dWmOonGGrsVVQNZh4zN\n\t+VTvBCDMwP/N2QC4kee1dnjHBtAvJlGqrBxvEguc+8SwvTaGzTncZGsbxunM5l+Xe6t7\n\tkkNA==","X-Gm-Message-State":"AOJu0Ywp6nfjra7+xLo7iP/UL30l2xuLbQR2Zqx3lVmJPuS//n1nF4Df\n\t6s4+XqCkUxq7l1eaoWwUUdqTnSEgx2gFZ27OprG8lRT0DEYc+ITi5bMZuNxh4a/xkAbgsqYDPka\n\tXmtaagQSsb1m2fr9ZVxm/Nz4ltFnzhFtmy2OnecspAOjUnwM9/SZxNg/HR1DdpkdCupHnQQ0xjO\n\to=","X-Gm-Gg":"AfdE7cmjuNofRcqY/yRWFy4Y+8+PQzcvS8dg0Rjhh9R1DgQ2YA00EYstE5xHMLYbNR0\n\tWFRDw/o074z1k52mvFaeR1k1EFWTA7pXO271hJeOqXmHFL6DblXOHTV3yH/UBXwCCFBL8wx0nJk\n\tlhnU5p40mlLxjrfX/PKdwd7Qcaav8eN0a/Qf2Sy4lZh9JiQO0TUixOjROrTgXi2KlyCTBpNIMyb\n\t9ujdU/DSqF3Q9Qq3I+t+CQPPyRxN25JYlCZbAJDhirPllfJpJIajpRlmlSW0Nwi063W3u+B3Y5H\n\tVFLweldPQkWkiVNYTEi9d4Wat84hfWg6iCML07lwo7vLJuOgfR9V4b2aObuwZcHDgHAR9WfyKCg\n\t9cag4zdw55UsrkjW25YpohPwrqegXLGptd2lrZGvOD5b/eaacax4Mcj9DsLzLeS0O","X-Received":["by 2002:a05:600c:1d86:b0:490:d354:bcf4 with SMTP id\n\t5b1f17b1804b1-49266885dc4mr84485695e9.27.1782471598013; \n\tFri, 26 Jun 2026 03:59:58 -0700 (PDT)","by 2002:a05:600c:1d86:b0:490:d354:bcf4 with SMTP id\n\t5b1f17b1804b1-49266885dc4mr84485195e9.27.1782471597578; \n\tFri, 26 Jun 2026 03:59:57 -0700 (PDT)"],"From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, pavel@ucw.cz","Subject":"Re: [PATCH 04/10] libcamera: egl: Rename createTexture2D to\n\tcreateInputTexture2D","In-Reply-To":"<20260624085849.873784-5-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 24 Jun 2026 09:58:43 +0100\")","References":"<20260624085849.873784-1-bryan.odonoghue@linaro.org>\n\t<20260624085849.873784-5-bryan.odonoghue@linaro.org>","Date":"Fri, 26 Jun 2026 12:59:55 +0200","Message-ID":"<85qzltlg7o.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"irJrrsNZ7r5y3uFoP8n2B4WH2YJ8PxGKglEdsDUI9_Q_1782471598","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]