From patchwork Wed Jun 24 08:58:43 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 27030 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1C690C3306 for ; Wed, 24 Jun 2026 08:59:14 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EBB226587B; Wed, 24 Jun 2026 10:59:10 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="eLKUrkqx"; dkim-atps=neutral Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DEDC65880 for ; Wed, 24 Jun 2026 10:59:03 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4926046fbc5so6661425e9.0 for ; Wed, 24 Jun 2026 01:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1782291543; x=1782896343; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x3IY0F3UjUxJGXv2KSdGvBjFnMvOa+oW1cFk+rb0RrQ=; b=eLKUrkqxewYZVUwRFvuhQtLJBGdBVuhs8oTFNjABp3peVUCulttA581hiX68ekvNE4 fsQi1djEVhl//Hs1ntN86SPbp9hdj+AT0YuGQYe2o73QUTJxb689PDupI8VswojYodt5 T+ahSXY55sGa4KwKJxNc4C5rc84Y9aUaEISiaAQg5V1l+Qwh1aFn7JkbV+//bE0NGI33 01/LM5qTcHPRB23I7gkDP0XSqVlb/3DpBjHJu5FA6kzSSKPGYdt1LiGe3+Eual4P1ctQ gqhHgm4qbDco+r4Q1Nqpa5kk61MtIWv4T36T1izArDKn6mqhH/xg6RjJdeiLvv4vhPGW 9NGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782291543; x=1782896343; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=x3IY0F3UjUxJGXv2KSdGvBjFnMvOa+oW1cFk+rb0RrQ=; b=iXehcFrSOmmQin5rVq9fzlM3I6M78Eiky2NVSQ23MO9E0i/E8qSnatoOBU34Rj2es0 Ev7iFWehcglKYOheUqSoN5Yqd632HrEWEa/BPmm+sIgrLFPOJzjhS/zRYA8gUCO/Iz+v 21uaJtmX5wHgsi9JonybwGtZYvdrEzC/RSZ9XCwf/0x1beiZPKYg62uQ+z/EDhlvrht5 aHiONSo5ujHDVxCPek0Xw5T7j5/PCghE7OxgkshzJjJ4uPbJk2Hl5HRF9outboBoC7b3 JHdh/lO9xKMUncXrdse2FAyyv/f3Qq9HJrIkRmhQdtl5tiUbeIihWrgCT+6qw5MEFMxU +sBw== X-Gm-Message-State: AOJu0YwwzKT6mGbFInDd4/Fra5B35FhwXZ2rR2GzOrwdPfEpKc+w39sP nbutMBA9vmgnJVoYm1PVRXZJwQW/N/iGeGSYWQyA0QU8/1aPOjj7+bgogjrQd11X9mILmhhJPw4 8qwoJgtA= X-Gm-Gg: AfdE7clOG2bJD9leIgiOA4H56WTfjiWhp8Af2a9L+W7F3xUtEWJkvbxulpPkkzBwko+ 7x5UAWJhiJaeQ/8YhFQGhMS2x0E3gk8w3SHLwxUHBXV4UZh9j6A+hwj+aaeMDt0YF3r2Yxm5zjs Jw2DObsFl0D7a/m1x38bNPkqELTyG9kxlzpZSxMwfTXc0luNzXrha3aR3nV3UEYTYADbzPnVQ9Q bZEsF2vBFFWp/Cr4f67TxODSfvtoZeot3fXZBqSJg5+XVYOrLlKE0cCkJ9j98lnTQg1sFHtloLI aPNaA5UAjg72Ks9ksOlBgWqCvJnKI4we3BaBWjMSRrnjURmt4cOhMzOZc9GBXHI1UtcxABYULyV ZyjF1GuPQfJsptwC3w0AKYhOrcCHRxN5mXW57vemyaxQp+vj5TxPAXQbx1ueoWQO1xRpv1Tp68c 8akniKHpOMIvXiQNrh0gFeAmr+NnIZ X-Received: by 2002:a05:600c:6692:b0:490:c1cb:48f4 with SMTP id 5b1f17b1804b1-4925a0b5505mr87016355e9.12.1782291542952; Wed, 24 Jun 2026 01:59:02 -0700 (PDT) Received: from inspiron14p-linux ([109.76.100.231]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49261063d6esm25128375e9.2.2026.06.24.01.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2026 01:59:02 -0700 (PDT) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: bryan.odonoghue@linaro.org, pavel@ucw.cz Subject: [PATCH 04/10] libcamera: egl: Rename createTexture2D to createInputTexture2D Date: Wed, 24 Jun 2026 09:58:43 +0100 Message-ID: <20260624085849.873784-5-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260624085849.873784-1-bryan.odonoghue@linaro.org> References: <20260624085849.873784-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Right now this routine makes a texture from a supplied data-buffer. It should have a more descriptive and accurate name. Signed-off-by: Bryan O'Donoghue --- include/libcamera/internal/egl.h | 2 +- src/libcamera/egl.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h index 4b0757afd..0709f9019 100644 --- a/include/libcamera/internal/egl.h +++ b/include/libcamera/internal/egl.h @@ -107,7 +107,7 @@ public: int createInputDMABufTexture2D(eGLImage &eglImage, int fd); int createOutputDMABufTexture2D(eGLImage &eglImage, int fd); - void createTexture2D(eGLImage &eglImage, void *data); + void createInputTexture2D(eGLImage &eglImage, void *data); int attachTextureToFBO(eGLImage &eglImage); diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp index 8d80a6d1a..2825d34d3 100644 --- a/src/libcamera/egl.cpp +++ b/src/libcamera/egl.cpp @@ -266,7 +266,7 @@ int eGL::createOutputDMABufTexture2D(eGLImage &eglImage, int fd) * is useful for uploading static data like lookup tables or uniform color * matrices to the GPU. */ -void eGL::createTexture2D(eGLImage &eglImage, void *data) +void eGL::createInputTexture2D(eGLImage &eglImage, void *data) { GLenum format; GLenum type = GL_UNSIGNED_BYTE;