Patch Detail
Show a patch.
GET /api/patches/26892/?format=api
{ "id": 26892, "url": "https://patchwork.libcamera.org/api/patches/26892/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26892/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260616-ipu3-libipa-rework-v1-1-d4448b54f1d8@ideasonboard.com>", "date": "2026-06-16T06:41:35", "name": "[01/10] ipa: ipu3: Remove ~Awb() from source and header", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "061c1dcb33458323da3a2f4e8f592d90ae0915f8", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26892/mbox/", "series": [ { "id": 5995, "url": "https://patchwork.libcamera.org/api/series/5995/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5995", "date": "2026-06-16T06:41:34", "name": "libipa: Re-work IPU3 IPA to use libipa algorithms", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5995/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26892/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26892/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 28576BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 16 Jun 2026 06:41:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E18CA62404;\n\tTue, 16 Jun 2026 08:41:51 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 00FB7623F5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Jun 2026 08:41:49 +0200 (CEST)", "from [127.0.1.1]\n\t(chfd-03-b2-v4wan-176392-cust229.vm15.cable.virginm.net\n\t[82.19.20.230])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 967D2217B;\n\tTue, 16 Jun 2026 08:41:15 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hx58pO4/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781592075;\n\tbh=PEZjYKpng5Tu8RX+QavMJLjC77fTL4V4XtaUh1NBXZ4=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=hx58pO4/km+OwfiPRnullhzDfzRCmEGEOHdRvM2HfKw8R8fPoXKsXNYX5+0rUkJZu\n\toRXap3fzr8rghrLtJN9MoOjkZt3m11xZNCYIUe6XT3LeuvDH2cfBD0Ddl8dQTqEP3j\n\tPPYkGLyhxU32kbC31GfVk1rqsxA50bmWJJAOsrT4=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "Date": "Tue, 16 Jun 2026 07:41:35 +0100", "Subject": "[PATCH 01/10] ipa: ipu3: Remove ~Awb() from source and header", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260616-ipu3-libipa-rework-v1-1-d4448b54f1d8@ideasonboard.com>", "References": "<20260616-ipu3-libipa-rework-v1-0-d4448b54f1d8@ideasonboard.com>", "In-Reply-To": "<20260616-ipu3-libipa-rework-v1-0-d4448b54f1d8@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Daniel Scally <dan.scally@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1243;\n\ti=dan.scally@ideasonboard.com; h=from:subject:message-id;\n\tbh=PEZjYKpng5Tu8RX+QavMJLjC77fTL4V4XtaUh1NBXZ4=;\n\tb=owEBbQKS/ZANAwAKAchJV3psRXUyAcsmYgBqMPAoUxpvnueIpdAaVHzoh1slS43QFr7c/IV/5\n\tZ1kMN8TKE+JAjMEAAEKAB0WIQQqyuwyDnZdb+mxmm/ISVd6bEV1MgUCajDwKAAKCRDISVd6bEV1\n\tMvzdD/oC59mfNBvXKsQQZx+dkx2xvMhj39bcBy6i/sHDnZB0YsBVYiLnHZzfrLFa7JWEmlO2E2n\n\tFaiUb0yewLpKJrXipNhtS1PgUCY++gueas9Ou4rLELz/miYihWG1ukx8TaJRUi+UngknZ5q6znr\n\txgKh15s7eQQd1A8xa4U6STsGzX7AC7BZbsz7KyHdwnLIH1pHCH8OTHiVMoWoMraXTNCXpQrHvts\n\thgOaz1W+AUB02WS+t8TVei1LEFAb9zBnrwjnt6OqPDpAYgc1HD8GA0001Wouu0v+JVj/5y+gZnk\n\txaaMB5lyDctwKWiNbJcKJcBas3Z9lkEBk2PaPXTQ/K0CfEl41uAxkfU6JwVHqiVwItC0dR+GGZx\n\th2YXUb2FKOhWPIPldn3p3ZyAqZ65BIkOBb/PhZ/0q8S4xnFLiZJeH4Yp1P1TcG4ljvvDnVlGgp8\n\tVSKUvDpfmDzegPiyAc6QIwVkvXFqUsyWfWlvuZ6PEQB5Whusy2D1ws8DU3hekFuLUm3/+NTDYw3\n\t5NfxHX3eAXlc4toPn7Ugjreyvqbhv2wIM06ZQcJaz6FsQ94DPpY9k+EdoUfKylHHRpbcRRqIu2f\n\tMhDL5wwtyC+bW+MkEnhOVq5Ux/S55TURurI2VSAXycYA/PxBLATAVDCTKaSmoCq5dQgERHk2Ajz\n\tX2B0bl94EV0dk1A==", "X-Developer-Key": "i=dan.scally@ideasonboard.com; a=openpgp;\n\tfpr=EEC699ACA1B7CB5D31330C0BBD501C2A3546CCF6", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Remove the ~Awb() definition from the source and header files and\nsimply allow the compiler to provide the default implementations.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\n src/ipa/ipu3/algorithms/awb.cpp | 2 --\n src/ipa/ipu3/algorithms/awb.h | 1 -\n 2 files changed, 3 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 55de05d9e39f5d2c863b89923964a4c7756f3846..6b4418aa6f3add0a41cae77000c1f5f67897111a 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -195,8 +195,6 @@ Awb::Awb()\n \tzones_.reserve(kAwbStatsSizeX * kAwbStatsSizeY);\n }\n \n-Awb::~Awb() = default;\n-\n /**\n * \\copydoc libcamera::ipa::Algorithm::configure\n */\ndiff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\nindex dbf69c9073a1627b666fe63158081e347cf3581e..7ec322318dab54ae7c8a647a67a0cf5815a36eb6 100644\n--- a/src/ipa/ipu3/algorithms/awb.h\n+++ b/src/ipa/ipu3/algorithms/awb.h\n@@ -38,7 +38,6 @@ class Awb : public Algorithm\n {\n public:\n \tAwb();\n-\t~Awb();\n \n \tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n \tvoid prepare(IPAContext &context, const uint32_t frame,\n", "prefixes": [ "01/10" ] }