From patchwork Tue Jun 16 06:41:35 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dan Scally X-Patchwork-Id: 26892 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 28576BF415 for ; Tue, 16 Jun 2026 06:41:57 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E18CA62404; Tue, 16 Jun 2026 08:41:51 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="hx58pO4/"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 00FB7623F5 for ; Tue, 16 Jun 2026 08:41:49 +0200 (CEST) Received: from [127.0.1.1] (chfd-03-b2-v4wan-176392-cust229.vm15.cable.virginm.net [82.19.20.230]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 967D2217B; Tue, 16 Jun 2026 08:41:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1781592075; bh=PEZjYKpng5Tu8RX+QavMJLjC77fTL4V4XtaUh1NBXZ4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=hx58pO4/km+OwfiPRnullhzDfzRCmEGEOHdRvM2HfKw8R8fPoXKsXNYX5+0rUkJZu oRXap3fzr8rghrLtJN9MoOjkZt3m11xZNCYIUe6XT3LeuvDH2cfBD0Ddl8dQTqEP3j PPYkGLyhxU32kbC31GfVk1rqsxA50bmWJJAOsrT4= From: Daniel Scally Date: Tue, 16 Jun 2026 07:41:35 +0100 Subject: [PATCH 01/10] ipa: ipu3: Remove ~Awb() from source and header MIME-Version: 1.0 Message-Id: <20260616-ipu3-libipa-rework-v1-1-d4448b54f1d8@ideasonboard.com> References: <20260616-ipu3-libipa-rework-v1-0-d4448b54f1d8@ideasonboard.com> In-Reply-To: <20260616-ipu3-libipa-rework-v1-0-d4448b54f1d8@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Daniel Scally X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1243; i=dan.scally@ideasonboard.com; h=from:subject:message-id; bh=PEZjYKpng5Tu8RX+QavMJLjC77fTL4V4XtaUh1NBXZ4=; b=owEBbQKS/ZANAwAKAchJV3psRXUyAcsmYgBqMPAoUxpvnueIpdAaVHzoh1slS43QFr7c/IV/5 Z1kMN8TKE+JAjMEAAEKAB0WIQQqyuwyDnZdb+mxmm/ISVd6bEV1MgUCajDwKAAKCRDISVd6bEV1 MvzdD/oC59mfNBvXKsQQZx+dkx2xvMhj39bcBy6i/sHDnZB0YsBVYiLnHZzfrLFa7JWEmlO2E2n FaiUb0yewLpKJrXipNhtS1PgUCY++gueas9Ou4rLELz/miYihWG1ukx8TaJRUi+UngknZ5q6znr xgKh15s7eQQd1A8xa4U6STsGzX7AC7BZbsz7KyHdwnLIH1pHCH8OTHiVMoWoMraXTNCXpQrHvts hgOaz1W+AUB02WS+t8TVei1LEFAb9zBnrwjnt6OqPDpAYgc1HD8GA0001Wouu0v+JVj/5y+gZnk xaaMB5lyDctwKWiNbJcKJcBas3Z9lkEBk2PaPXTQ/K0CfEl41uAxkfU6JwVHqiVwItC0dR+GGZx h2YXUb2FKOhWPIPldn3p3ZyAqZ65BIkOBb/PhZ/0q8S4xnFLiZJeH4Yp1P1TcG4ljvvDnVlGgp8 VSKUvDpfmDzegPiyAc6QIwVkvXFqUsyWfWlvuZ6PEQB5Whusy2D1ws8DU3hekFuLUm3/+NTDYw3 5NfxHX3eAXlc4toPn7Ugjreyvqbhv2wIM06ZQcJaz6FsQ94DPpY9k+EdoUfKylHHRpbcRRqIu2f MhDL5wwtyC+bW+MkEnhOVq5Ux/S55TURurI2VSAXycYA/PxBLATAVDCTKaSmoCq5dQgERHk2Ajz X2B0bl94EV0dk1A== X-Developer-Key: i=dan.scally@ideasonboard.com; a=openpgp; fpr=EEC699ACA1B7CB5D31330C0BBD501C2A3546CCF6 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Remove the ~Awb() definition from the source and header files and simply allow the compiler to provide the default implementations. Signed-off-by: Daniel Scally Reviewed-by: Barnabás Pőcze --- src/ipa/ipu3/algorithms/awb.cpp | 2 -- src/ipa/ipu3/algorithms/awb.h | 1 - 2 files changed, 3 deletions(-) diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp index 55de05d9e39f5d2c863b89923964a4c7756f3846..6b4418aa6f3add0a41cae77000c1f5f67897111a 100644 --- a/src/ipa/ipu3/algorithms/awb.cpp +++ b/src/ipa/ipu3/algorithms/awb.cpp @@ -195,8 +195,6 @@ Awb::Awb() zones_.reserve(kAwbStatsSizeX * kAwbStatsSizeY); } -Awb::~Awb() = default; - /** * \copydoc libcamera::ipa::Algorithm::configure */ diff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h index dbf69c9073a1627b666fe63158081e347cf3581e..7ec322318dab54ae7c8a647a67a0cf5815a36eb6 100644 --- a/src/ipa/ipu3/algorithms/awb.h +++ b/src/ipa/ipu3/algorithms/awb.h @@ -38,7 +38,6 @@ class Awb : public Algorithm { public: Awb(); - ~Awb(); int configure(IPAContext &context, const IPAConfigInfo &configInfo) override; void prepare(IPAContext &context, const uint32_t frame,