[{"id":39099,"web_url":"https://patchwork.libcamera.org/comment/39099/","msgid":"<082c6fc0-0dc9-457f-95fd-6280f04fa9d9@protonmail.com>","date":"2026-06-16T08:29:16","subject":"Re: [PATCH 01/10] ipa: ipu3: Remove ~Awb() from source and header","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"2026. 06. 16. 8:41 keltezéssel, Daniel Scally írta:\n> Remove the ~Awb() definition from the source and header files and\n> simply allow the compiler to provide the default implementations.\n> \n> Signed-off-by: Daniel Scally \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/ipa/ipu3/algorithms/awb.cpp | 2 --\n> src/ipa/ipu3/algorithms/awb.h | 1 -\n> 2 files changed, 3 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\n> index 55de05d9e39f5d2c863b89923964a4c7756f3846..6b4418aa6f3add0a41cae77000c1f5f67897111a 100644\n> --- a/src/ipa/ipu3/algorithms/awb.cpp\n> +++ b/src/ipa/ipu3/algorithms/awb.cpp\n> @@ -195,8 +195,6 @@ Awb::Awb()\n> \tzones_.reserve(kAwbStatsSizeX * kAwbStatsSizeY);\n> }\n> \n> -Awb::~Awb() = default;\n> -\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::configure\n> */\n> diff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\n> index dbf69c9073a1627b666fe63158081e347cf3581e..7ec322318dab54ae7c8a647a67a0cf5815a36eb6 100644\n> --- a/src/ipa/ipu3/algorithms/awb.h\n> +++ b/src/ipa/ipu3/algorithms/awb.h\n> @@ -38,7 +38,6 @@ class Awb : public Algorithm\n> {\n> public:\n> \tAwb();\n> -\t~Awb();\n> \n> \tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n> \tvoid prepare(IPAContext &context, const uint32_t frame,\n> \n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6BB93C3261\n\tfor ;\n\tTue, 16 Jun 2026 08:29:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5461C625A1;\n\tTue, 16 Jun 2026 10:29:25 +0200 (CEST)","from mail-10630.protonmail.ch (mail-10630.protonmail.ch\n\t[79.135.106.30])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E3B0B61754\n\tfor ;\n\tTue, 16 Jun 2026 10:29:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"hsd+X+X3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1781598563; x=1781857763;\n\tbh=799lhfnvrgACg7ye6NDD/T6e+cMtwKDoWKrJuj60IQA=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=hsd+X+X3QGzxHCOcR0dRmbKhjDnEzZK6rZjlXk0BW27EVJamw+H5hDAISRlqauh1L\n\tzarxl6OIay4jHwUFbrTOPXL4+2t9ebKOhfyWutaAdTl58xNW0TINqytGP0/rzK+j9p\n\tCitIm2w4CEGUHe/Z657kC+a0O1FILnLdZzx98fHtnggIaydJB2ZXfHAoi8O3v1paMN\n\tfJ3yEJ5mcFngPmE2Np9ezCudYRScIg7nANdiAuT3EnfKqiV/01xC70yGerTQQagH8w\n\tRoHNcs/DWRwF+hw173crzdXGl8Wi3CFEiShOf+qs+SE0hDXl6+fAxuFgs35/sviOQn\n\txoKwF7AMj9ZYQ==","Date":"Tue, 16 Jun 2026 08:29:16 +0000","To":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","From":"=?utf-8?q?P=C5=91cze_Barnab=C3=A1s?= ","Subject":"Re: [PATCH 01/10] ipa: ipu3: Remove ~Awb() from source and header","Message-ID":"<082c6fc0-0dc9-457f-95fd-6280f04fa9d9@protonmail.com>","In-Reply-To":"<20260616-ipu3-libipa-rework-v1-1-d4448b54f1d8@ideasonboard.com>","References":"<20260616-ipu3-libipa-rework-v1-0-d4448b54f1d8@ideasonboard.com>\n\t<20260616-ipu3-libipa-rework-v1-1-d4448b54f1d8@ideasonboard.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"90a1d6c7a2b5d4fdaae2f9026c1222b921b10eb4","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39139,"web_url":"https://patchwork.libcamera.org/comment/39139/","msgid":"<178163327780.3598163.12731234004772228221@ping.linuxembedded.co.uk>","date":"2026-06-16T18:07:57","subject":"Re: [PATCH 01/10] ipa: ipu3: Remove ~Awb() from source and header","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Scally (2026-06-16 07:41:35)\n> Remove the ~Awb() definition from the source and header files and\n> simply allow the compiler to provide the default implementations.\n> \n> Signed-off-by: Daniel Scally \n\nEasy ones first I guess\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/ipu3/algorithms/awb.cpp | 2 --\n> src/ipa/ipu3/algorithms/awb.h | 1 -\n> 2 files changed, 3 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\n> index 55de05d9e39f5d2c863b89923964a4c7756f3846..6b4418aa6f3add0a41cae77000c1f5f67897111a 100644\n> --- a/src/ipa/ipu3/algorithms/awb.cpp\n> +++ b/src/ipa/ipu3/algorithms/awb.cpp\n> @@ -195,8 +195,6 @@ Awb::Awb()\n> zones_.reserve(kAwbStatsSizeX * kAwbStatsSizeY);\n> }\n> \n> -Awb::~Awb() = default;\n> -\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::configure\n> */\n> diff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\n> index dbf69c9073a1627b666fe63158081e347cf3581e..7ec322318dab54ae7c8a647a67a0cf5815a36eb6 100644\n> --- a/src/ipa/ipu3/algorithms/awb.h\n> +++ b/src/ipa/ipu3/algorithms/awb.h\n> @@ -38,7 +38,6 @@ class Awb : public Algorithm\n> {\n> public:\n> Awb();\n> - ~Awb();\n> \n> int configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n> void prepare(IPAContext &context, const uint32_t frame,\n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC33AC3261\n\tfor ;\n\tTue, 16 Jun 2026 18:08:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DF8E5626E3;\n\tTue, 16 Jun 2026 20:08:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8CEEB623CC\n\tfor ;\n\tTue, 16 Jun 2026 20:08:00 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D81B4227;\n\tTue, 16 Jun 2026 20:07:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LPFf2eB7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781633246;\n\tbh=CyyTOH0JIRtBsp0W/ySsJ1aa4f94DXuHqUKKH3noTso=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=LPFf2eB7M+fU0fmPWGXHr/qn+2uPZt5mOfs9E2MnwxOIPDq0JDhrprY9rjzLmf3E4\n\tLWVm1nxOssJvd3c/4LuvL1vlNRYC4srMlvcSVtDlC3LcQj7bGvnYjWL47kreYvHaC7\n\t47evIi2u/UerVkZePAeFMlT+Bro6PXWHu1XNNeo4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260616-ipu3-libipa-rework-v1-1-d4448b54f1d8@ideasonboard.com>","References":"<20260616-ipu3-libipa-rework-v1-0-d4448b54f1d8@ideasonboard.com>\n\t<20260616-ipu3-libipa-rework-v1-1-d4448b54f1d8@ideasonboard.com>","Subject":"Re: [PATCH 01/10] ipa: ipu3: Remove ~Awb() from source and header","From":"Kieran Bingham ","Cc":"Daniel Scally ","To":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 16 Jun 2026 19:07:57 +0100","Message-ID":"<178163327780.3598163.12731234004772228221@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]