Patch Detail
Show a patch.
GET /api/patches/26750/?format=api
{ "id": 26750, "url": "https://patchwork.libcamera.org/api/patches/26750/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26750/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260513142030.36897-2-johannes.goede@oss.qualcomm.com>", "date": "2026-05-13T14:20:30", "name": "[1/1] libcamera: pipeline: Add todo for doing IPA matching on IpaProxy type", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3963d9a482e1d0a93c888266eeb0cb52602be601", "submitter": { "id": 242, "url": "https://patchwork.libcamera.org/api/people/242/?format=api", "name": "Hans de Goede", "email": "johannes.goede@oss.qualcomm.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26750/mbox/", "series": [ { "id": 5943, "url": "https://patchwork.libcamera.org/api/series/5943/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5943", "date": "2026-05-13T14:20:29", "name": "libcamera: pipeline: Add todo for doing IPA matching on IpaProxy type", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5943/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26750/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26750/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2D3BC32F7\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 13 May 2026 14:20:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C1AF76302A;\n\tWed, 13 May 2026 16:20:39 +0200 (CEST)", "from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n\t[205.220.168.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 38D9062FE8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 May 2026 16:20:37 +0200 (CEST)", "from pps.filterd (m0279867.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t64D8n8YD2887818 for <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 May 2026 14:20:35 GMT", "from mail-vk1-f198.google.com (mail-vk1-f198.google.com\n\t[209.85.221.198])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e4p4gh8f8-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 May 2026 14:20:35 +0000 (GMT)", "by mail-vk1-f198.google.com with SMTP id\n\t71dfb90a1353d-575231e4b89so6627469e0c.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 May 2026 07:20:35 -0700 (PDT)", "from shalem\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-bd2dba8fd22sm246750866b.16.2026.05.13.07.20.32\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 13 May 2026 07:20:33 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"hkDDR43s\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"ZXtUqHNu\"; dkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=qcppdkim1; bh=/UlCEFPFUG5\n\t+h01zgvDuysGRZX6ZInQGgtm3AH8hWZc=; b=hkDDR43skPrgUKRwfS8Efdw2Udl\n\tfjRHnPj2RB1UmamIm42c+7adp0UepiKe1rY8Ur1zB+s+Yf/+QAhCkreONKPHXSFk\n\tYxkKP9EP06z/SwVeCluDwtrlHRmSMNx1ECU8Omq3P86LlqVV1IID/YtSMC2h3brb\n\tDaebQqPRAD3IPYL395J2Aw0aeHF0A/Yd5cdvko1d7lgDwycapw3y8RArWVQNMaOk\n\tKqkXPY33ToxZf72Q97oCBlB0DoeGAJwbFy3FFkmk/wJcjhjFRQ41sfHt9qLj925m\n\txvFPwKRWI5rd7NWjlPIqpiwEWwgtLuxrsINWIoCQA/KsCTwavSpEgPRIcrw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1778682034; x=1779286834;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=/UlCEFPFUG5+h01zgvDuysGRZX6ZInQGgtm3AH8hWZc=;\n\tb=ZXtUqHNuEJzG/C1Fvus3cFCsPoRuY88enpgfLRsO+pMMAz3tYU4BsxRVD4QljHUgfP\n\tGp3yuhftDIW5GoJzy8rHzOR8iWYtBnYLOVuROw/AA0TMizN5b0idqm9VitrSQTON5JlH\n\t4c7512YwR58aEcsfdfT6UiufNG21Zn9dcYqV3uf1srUIGacvmPqBN2eZdJlM8Uw5Wm5u\n\tN/kYbBcWMzXUqrmaNiOm8yRQRaE9SrwHw14WRhenpX1GVPt2XyJBRAM5q9CvGUS4omWB\n\tvDR2e5o15Dy9+v8wHaM68Ge4Yf5svhlHJajFztooNfU6FfucYmaDt0oHGfj8K0BogCgh\n\t8Cww==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1778682034; x=1779286834;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=/UlCEFPFUG5+h01zgvDuysGRZX6ZInQGgtm3AH8hWZc=;\n\tb=i5xxNv7Llspi7+XbZzIY1DHchO5K5PefGiW+T8G8UphWlLIZbawAU2cStnv08RRVid\n\t/p4jAjXtvl2O0m5mwkzoI403DvWzFyYtMCINfiFd6AfH/vNxpQndttxVmA7OrGCyq/A7\n\t0d5bd3a6G5Sh9lmFP78Vkex8a9zpfPz7YxRLtncVAPtUsllI+iGnyayPhZsGutamVN6e\n\tbEZK0Pvwy8QlS4CBVzDRaMEWOzklMsI0rr2puuaKD5S0nd6MWOjQttzLsHAl88ldZSAA\n\tWdJVpQpPYl/TBTM3bamJ9tS8kkTurYkzvfpLVY2Q7DWn36fpt5KgVVcmC9I3JrIJZvEN\n\teS/A==", "X-Gm-Message-State": "AOJu0YwnXZRQrIP5eh1AIgw+wqiKWVx+nNPXt9TmLElYb2xxUSnlo3lD\n\tHx8UNjnXzlZyGf9beNyDNUZIsLOU1EPDbIPy+iHMErPhCWQnDFlnBMpMLmn3fGE9eHwfAlcNYOS\n\tzZkQ4epYCfLVYVRi8PH7QdRCPgdMo3BAthSIZfPEvif3K/cnaRtZ2GeM8MkUM9cr65DdSSm7JT/\n\t4WlvGDMmho", "X-Gm-Gg": "Acq92OEKydG7BFYZp8lTlSkJi8MUhDvfO3yNLufM+w6pSDRCgr0xtqNwbYWitZXliZ2\n\tHiBrLJYfkU2FSuw+m5Wuzu1RnFA7e6znup0x+kWKtVZTih08VU7IDGcQR6CV1+Hgxq9rkjVkhnA\n\tJrepGTbDmCfZPdGtX3vbKPqXfrCMCPSePIuoh8fiZik7FP9LWADlSS3+UNBgzJqMRszOkHlAVau\n\tbza9aWsFzZkGrzzoN55YhcK2ocr3UptfVQg8k93Kl2vPJtAIrZYFhyHF/jzcwClPIQ60BAuifaO\n\tbHoiW9BHF3m9mX6lIwrqz5FDqw1Tuve4zvGkFgMFdspEY0EHP8uXjLjbnlxRwqAgVWKjY/cghwW\n\tPucXXBFDA/0CO4o4xPS31/s70LB66UBiGKPgU+KrU7JNXZCpiE0QROC1sqbgEeFCBd0HPRiOboG\n\tbyiRDxBq6lOemUcC7s5HiPU+iASunQSEDEsIKE", "X-Received": [ "by 2002:a05:6123:146:b0:570:f670:587d with SMTP id\n\t71dfb90a1353d-575e87d27ecmr1183263e0c.12.1778682034292; \n\tWed, 13 May 2026 07:20:34 -0700 (PDT)", "by 2002:a05:6123:146:b0:570:f670:587d with SMTP id\n\t71dfb90a1353d-575e87d27ecmr1183208e0c.12.1778682033862; \n\tWed, 13 May 2026 07:20:33 -0700 (PDT)" ], "From": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "Subject": "[PATCH 1/1] libcamera: pipeline: Add todo for doing IPA matching on\n\tIpaProxy type", "Date": "Wed, 13 May 2026 16:20:30 +0200", "Message-ID": "<20260513142030.36897-2-johannes.goede@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260513142030.36897-1-johannes.goede@oss.qualcomm.com>", "References": "<20260513142030.36897-1-johannes.goede@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-GUID": "p9b7EdB07PkXJsdpVBHULrcFz65sp3Ec", "X-Authority-Analysis": "v=2.4 cv=DOS/JSNb c=1 sm=1 tr=0 ts=6a0488b3 cx=c_pps\n\ta=1Os3MKEOqt8YzSjcPV0cFA==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10\n\ta=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n\ta=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=x-ZgCTfUe3VvHCtVNrgA:9\n\ta=hhpmQAJR8DioWGSBphRh:22", "X-Proofpoint-ORIG-GUID": "p9b7EdB07PkXJsdpVBHULrcFz65sp3Ec", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNTEzMDE0NyBTYWx0ZWRfX/7y3kNJR6RCt\n\te7ckrd049l3iQo6lzEuZokt7oP220oMTJ0sm5TIZ1spxhtUezoLSSRZFV3mcf+PpEIiPlXfYNFj\n\th8dkRhVXljkQpFr1tgClaZ151gDpPUx9jQd71bPfDjiWgqC6yLEsNqsfYtD9lwJi7GMLrkDLEEQ\n\t7iUM1NYzjLkGCF6Wi6s63DIqGGk1UYUdkjbJWaFHBqol4JVYUFNsk0BG96CNGt3AoIkiDmUMM1F\n\tZGRKwLIGJdVRojTrMcF+dfpvogoU5iRXM31GmNfskhfxsbOf9bKlhUVopQhPg+A4DJ028qCY//J\n\tER3bUKuyVUGD1+iXi51+6JZsVuTuanXA23IQ4gxx1wPHbqxk1xJJAlgQNSD7Nb7QH4S9Jw1mte/\n\tvcFweLihw2uoafan71gK2p7UfI2k9UurjgTOZOCXhxgE5qMld4b4+ko5zI/mrhl4cnvJlbhFpgk\n\tACVBYAPeFcVv+v6k+Dw==", "X-Proofpoint-Virus-Version": "vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-05-13_01,2026-05-08_02,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tmalwarescore=0 adultscore=0 impostorscore=0 bulkscore=0 clxscore=1015\n\tpriorityscore=1501 phishscore=0 suspectscore=0 lowpriorityscore=0\n\tspamscore=0\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2605050000\n\tdefinitions=main-2605130147", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a todo to createIPA() in libcamera/internal/pipeline_handler.h noting\nthat: The IpaProxy class-type template parameter should have a static\nname() member and that should be used to find the IPA instead of matching\non PipelineHandler.name_ or a passed in ipaName createIPA() argument.\n\nSigned-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>\n---\n include/libcamera/internal/pipeline_handler.h | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex 4fd6bf3ba..c434b4fcc 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -72,6 +72,18 @@ public:\n \n \tCameraManager *cameraManager() const { return manager_; }\n \n+\t/*\n+\t * \\todo instead of matching on the this->_name or a passed in ipaName\n+\t * the IpaProxy class-type template parameter should have a static\n+\t * name() member and that should be used to find the IPA.\n+\t *\n+\t * Fixing this is blocked on the rpi/pisp and rpi/vc4 pipeline-handlers\n+\t * each having their own IPA implementation while sharing a single\n+\t * IpaProxy class between the two.\n+\t *\n+\t * Once this is fixed the second createIPA() overload taking an ipaName\n+\t * argument should be dropped.\n+\t */\n \ttemplate<typename T>\n \tstd::unique_ptr<T> createIPA(uint32_t minVersion, uint32_t maxVersion)\n \t{\n", "prefixes": [ "1/1" ] }