[1/1] libcamera: pipeline: Add todo for doing IPA matching on IpaProxy type
diff mbox series

Message ID 20260513142030.36897-2-johannes.goede@oss.qualcomm.com
State New
Headers show
Series
  • libcamera: pipeline: Add todo for doing IPA matching on IpaProxy type
Related show

Commit Message

Hans de Goede May 13, 2026, 2:20 p.m. UTC 
Add a todo to createIPA() in libcamera/internal/pipeline_handler.h noting
that: The IpaProxy class-type template parameter should have a static
name() member and that should be used to find the IPA instead of matching
on PipelineHandler.name_ or a passed in ipaName createIPA() argument.

Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
---
 include/libcamera/internal/pipeline_handler.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Patch
diff mbox series 

diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h
index 4fd6bf3ba..c434b4fcc 100644
--- a/include/libcamera/internal/pipeline_handler.h
+++ b/include/libcamera/internal/pipeline_handler.h
@@ -72,6 +72,18 @@  public:
 
 	CameraManager *cameraManager() const { return manager_; }
 
+	/*
+	 * \todo instead of matching on the this->_name or a passed in ipaName
+	 * the IpaProxy class-type template parameter should have a static
+	 * name() member and that should be used to find the IPA.
+	 *
+	 * Fixing this is blocked on the rpi/pisp and rpi/vc4 pipeline-handlers
+	 * each having their own IPA implementation while sharing a single
+	 * IpaProxy class between the two.
+	 *
+	 * Once this is fixed the second createIPA() overload taking an ipaName
+	 * argument should be dropped.
+	 */
 	template<typename T>
 	std::unique_ptr<T> createIPA(uint32_t minVersion, uint32_t maxVersion)
 	{