From patchwork Wed May 13 14:20:30 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 26750 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D2D3BC32F7 for ; Wed, 13 May 2026 14:20:40 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C1AF76302A; Wed, 13 May 2026 16:20:39 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="hkDDR43s"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZXtUqHNu"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 38D9062FE8 for ; Wed, 13 May 2026 16:20:37 +0200 (CEST) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64D8n8YD2887818 for ; Wed, 13 May 2026 14:20:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=/UlCEFPFUG5 +h01zgvDuysGRZX6ZInQGgtm3AH8hWZc=; b=hkDDR43skPrgUKRwfS8Efdw2Udl fjRHnPj2RB1UmamIm42c+7adp0UepiKe1rY8Ur1zB+s+Yf/+QAhCkreONKPHXSFk YxkKP9EP06z/SwVeCluDwtrlHRmSMNx1ECU8Omq3P86LlqVV1IID/YtSMC2h3brb DaebQqPRAD3IPYL395J2Aw0aeHF0A/Yd5cdvko1d7lgDwycapw3y8RArWVQNMaOk KqkXPY33ToxZf72Q97oCBlB0DoeGAJwbFy3FFkmk/wJcjhjFRQ41sfHt9qLj925m xvFPwKRWI5rd7NWjlPIqpiwEWwgtLuxrsINWIoCQA/KsCTwavSpEgPRIcrw== Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e4p4gh8f8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 13 May 2026 14:20:35 +0000 (GMT) Received: by mail-vk1-f198.google.com with SMTP id 71dfb90a1353d-575231e4b89so6627469e0c.1 for ; Wed, 13 May 2026 07:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778682034; x=1779286834; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/UlCEFPFUG5+h01zgvDuysGRZX6ZInQGgtm3AH8hWZc=; b=ZXtUqHNuEJzG/C1Fvus3cFCsPoRuY88enpgfLRsO+pMMAz3tYU4BsxRVD4QljHUgfP Gp3yuhftDIW5GoJzy8rHzOR8iWYtBnYLOVuROw/AA0TMizN5b0idqm9VitrSQTON5JlH 4c7512YwR58aEcsfdfT6UiufNG21Zn9dcYqV3uf1srUIGacvmPqBN2eZdJlM8Uw5Wm5u N/kYbBcWMzXUqrmaNiOm8yRQRaE9SrwHw14WRhenpX1GVPt2XyJBRAM5q9CvGUS4omWB vDR2e5o15Dy9+v8wHaM68Ge4Yf5svhlHJajFztooNfU6FfucYmaDt0oHGfj8K0BogCgh 8Cww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778682034; x=1779286834; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/UlCEFPFUG5+h01zgvDuysGRZX6ZInQGgtm3AH8hWZc=; b=i5xxNv7Llspi7+XbZzIY1DHchO5K5PefGiW+T8G8UphWlLIZbawAU2cStnv08RRVid /p4jAjXtvl2O0m5mwkzoI403DvWzFyYtMCINfiFd6AfH/vNxpQndttxVmA7OrGCyq/A7 0d5bd3a6G5Sh9lmFP78Vkex8a9zpfPz7YxRLtncVAPtUsllI+iGnyayPhZsGutamVN6e bEZK0Pvwy8QlS4CBVzDRaMEWOzklMsI0rr2puuaKD5S0nd6MWOjQttzLsHAl88ldZSAA WdJVpQpPYl/TBTM3bamJ9tS8kkTurYkzvfpLVY2Q7DWn36fpt5KgVVcmC9I3JrIJZvEN eS/A== X-Gm-Message-State: AOJu0YwnXZRQrIP5eh1AIgw+wqiKWVx+nNPXt9TmLElYb2xxUSnlo3lD Hx8UNjnXzlZyGf9beNyDNUZIsLOU1EPDbIPy+iHMErPhCWQnDFlnBMpMLmn3fGE9eHwfAlcNYOS zZkQ4epYCfLVYVRi8PH7QdRCPgdMo3BAthSIZfPEvif3K/cnaRtZ2GeM8MkUM9cr65DdSSm7JT/ 4WlvGDMmho X-Gm-Gg: Acq92OEKydG7BFYZp8lTlSkJi8MUhDvfO3yNLufM+w6pSDRCgr0xtqNwbYWitZXliZ2 HiBrLJYfkU2FSuw+m5Wuzu1RnFA7e6znup0x+kWKtVZTih08VU7IDGcQR6CV1+Hgxq9rkjVkhnA JrepGTbDmCfZPdGtX3vbKPqXfrCMCPSePIuoh8fiZik7FP9LWADlSS3+UNBgzJqMRszOkHlAVau bza9aWsFzZkGrzzoN55YhcK2ocr3UptfVQg8k93Kl2vPJtAIrZYFhyHF/jzcwClPIQ60BAuifaO bHoiW9BHF3m9mX6lIwrqz5FDqw1Tuve4zvGkFgMFdspEY0EHP8uXjLjbnlxRwqAgVWKjY/cghwW PucXXBFDA/0CO4o4xPS31/s70LB66UBiGKPgU+KrU7JNXZCpiE0QROC1sqbgEeFCBd0HPRiOboG byiRDxBq6lOemUcC7s5HiPU+iASunQSEDEsIKE X-Received: by 2002:a05:6123:146:b0:570:f670:587d with SMTP id 71dfb90a1353d-575e87d27ecmr1183263e0c.12.1778682034292; Wed, 13 May 2026 07:20:34 -0700 (PDT) X-Received: by 2002:a05:6123:146:b0:570:f670:587d with SMTP id 71dfb90a1353d-575e87d27ecmr1183208e0c.12.1778682033862; Wed, 13 May 2026 07:20:33 -0700 (PDT) Received: from shalem (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd2dba8fd22sm246750866b.16.2026.05.13.07.20.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 07:20:33 -0700 (PDT) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Hans de Goede Subject: [PATCH 1/1] libcamera: pipeline: Add todo for doing IPA matching on IpaProxy type Date: Wed, 13 May 2026 16:20:30 +0200 Message-ID: <20260513142030.36897-2-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260513142030.36897-1-johannes.goede@oss.qualcomm.com> References: <20260513142030.36897-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Proofpoint-GUID: p9b7EdB07PkXJsdpVBHULrcFz65sp3Ec X-Authority-Analysis: v=2.4 cv=DOS/JSNb c=1 sm=1 tr=0 ts=6a0488b3 cx=c_pps a=1Os3MKEOqt8YzSjcPV0cFA==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=x-ZgCTfUe3VvHCtVNrgA:9 a=hhpmQAJR8DioWGSBphRh:22 X-Proofpoint-ORIG-GUID: p9b7EdB07PkXJsdpVBHULrcFz65sp3Ec X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEzMDE0NyBTYWx0ZWRfX/7y3kNJR6RCt e7ckrd049l3iQo6lzEuZokt7oP220oMTJ0sm5TIZ1spxhtUezoLSSRZFV3mcf+PpEIiPlXfYNFj h8dkRhVXljkQpFr1tgClaZ151gDpPUx9jQd71bPfDjiWgqC6yLEsNqsfYtD9lwJi7GMLrkDLEEQ 7iUM1NYzjLkGCF6Wi6s63DIqGGk1UYUdkjbJWaFHBqol4JVYUFNsk0BG96CNGt3AoIkiDmUMM1F ZGRKwLIGJdVRojTrMcF+dfpvogoU5iRXM31GmNfskhfxsbOf9bKlhUVopQhPg+A4DJ028qCY//J ER3bUKuyVUGD1+iXi51+6JZsVuTuanXA23IQ4gxx1wPHbqxk1xJJAlgQNSD7Nb7QH4S9Jw1mte/ vcFweLihw2uoafan71gK2p7UfI2k9UurjgTOZOCXhxgE5qMld4b4+ko5zI/mrhl4cnvJlbhFpgk ACVBYAPeFcVv+v6k+Dw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.51, FMLib:17.12.100.49 definitions=2026-05-13_01,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 impostorscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 phishscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605130147 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add a todo to createIPA() in libcamera/internal/pipeline_handler.h noting that: The IpaProxy class-type template parameter should have a static name() member and that should be used to find the IPA instead of matching on PipelineHandler.name_ or a passed in ipaName createIPA() argument. Signed-off-by: Hans de Goede --- include/libcamera/internal/pipeline_handler.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h index 4fd6bf3ba..c434b4fcc 100644 --- a/include/libcamera/internal/pipeline_handler.h +++ b/include/libcamera/internal/pipeline_handler.h @@ -72,6 +72,18 @@ public: CameraManager *cameraManager() const { return manager_; } + /* + * \todo instead of matching on the this->_name or a passed in ipaName + * the IpaProxy class-type template parameter should have a static + * name() member and that should be used to find the IPA. + * + * Fixing this is blocked on the rpi/pisp and rpi/vc4 pipeline-handlers + * each having their own IPA implementation while sharing a single + * IpaProxy class between the two. + * + * Once this is fixed the second createIPA() overload taking an ipaName + * argument should be dropped. + */ template std::unique_ptr createIPA(uint32_t minVersion, uint32_t maxVersion) {