Patch Detail
Show a patch.
GET /api/patches/26707/?format=api
{ "id": 26707, "url": "https://patchwork.libcamera.org/api/patches/26707/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26707/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260508223736.0B7291EA006C@mailuser.phl.internal>", "date": "2026-05-08T21:35:57", "name": "[v2,2/2] libcamera: software_isp: Use Vector operator>>= in finishFrame", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d6c896fe666c2af07cf96b397a6523848dea2131", "submitter": { "id": 261, "url": "https://patchwork.libcamera.org/api/people/261/?format=api", "name": "Javier Tia", "email": "floss@jetm.me" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26707/mbox/", "series": [ { "id": 5929, "url": "https://patchwork.libcamera.org/api/series/5929/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5929", "date": "2026-05-08T21:35:24", "name": "libcamera: Vector right-shift operators and SwStatsCpu use site", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5929/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26707/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26707/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 72C94BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 8 May 2026 22:37:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F2B5A6302E;\n\tSat, 9 May 2026 00:37:39 +0200 (CEST)", "from fhigh-a5-smtp.messagingengine.com\n\t(fhigh-a5-smtp.messagingengine.com [103.168.172.156])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 21E0E62FEA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 9 May 2026 00:37:37 +0200 (CEST)", "from phl-compute-02.internal (phl-compute-02.internal\n\t[10.202.2.42])\n\tby mailfhigh.phl.internal (Postfix) with ESMTP id 298BC1400106;\n\tFri, 8 May 2026 18:37:36 -0400 (EDT)", "from phl-imap-07 ([10.202.2.97])\n\tby phl-compute-02.internal (MEProxy); Fri, 08 May 2026 18:37:36 -0400", "by mailuser.phl.internal (Postfix, from userid 501)\n\tid 0B7291EA006C; Fri, 8 May 2026 18:37:36 -0400 (EDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=jetm.me header.i=@jetm.me header.b=\"jSefRTNb\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"DXE3DUaP\"; \n\tdkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=jetm.me; h=cc:cc\n\t:content-transfer-encoding:content-type:content-type:date:date\n\t:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to; s=fm2; t=1778279856;\n\tx=1778366256; bh=rdl7FlZRDD5hPRomwZIvt+J7x8ER3CE2Z9z6Qt9njHI=; b=\n\tjSefRTNb0vkHx8JB9tQYgYSusy6CJo+dVpJTuU5A+0EAygHq31D101DTnMIhkW0T\n\tSpLbBL0DA3fgNfeQ3khNlNnEqMURsJeJsOKCU/IyNYH2JWcOl6oltMzZIJsiEGRe\n\t3wtZdRUVR8Lwz9tn8fF6E6Y/kiovd872dPLvuveuZVrJqUr2bcXVYpFQ0JYjd0ww\n\tIUD+k9msO6cySUjdk1vS225Ewd+fU7Dr+kMTIgRib/rNtVazNY7A1FoiuUfMZ6vd\n\t5tuZvjAW6j93jt/+uw4ZXPZ4ylFJpLqiVuW2oEsBu+aG0qJZThINWvMhvYgVv01l\n\th+3vhbHxLOsNk2ZxjWlSDg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:cc:content-transfer-encoding\n\t:content-type:content-type:date:date:feedback-id:feedback-id\n\t:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to:x-me-proxy\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1778279856; x=\n\t1778366256; bh=rdl7FlZRDD5hPRomwZIvt+J7x8ER3CE2Z9z6Qt9njHI=; b=D\n\tXE3DUaPcbNJo80g3CxM7Wt9h3RHvpm0BnaXBOwb2Hn0WIDk4EKqKZUP6fb6aNl1W\n\tcxKl9tzsjrMisIwwPbFhbqPI72Ig+TldhWrgTH3xkjneIWGpqM/h12/wrgJA121+\n\tvfq9Jo4bBvpaU51cMlPlmfBARKLzVtKSAhrDDfKDtl8GDDqIq8aKsjPSqgwlgR9e\n\tF1GdFsQAyYxVoVSkM5xauv3xFtRxnRNX80TJs97BQAQXBrvjouBvHGVoRYVvi71N\n\trAYRc/1qhbgGFIjx7Xua+Fho3DCZyKbMLd6BUf6PHg+SoOLeWyZQNWFpd3tG+YFR\n\tNr6r3VjzOGqnXLbDNjFVg==" ], "X-ME-Sender": "<xms:sGX-acDW82Y4Q2Z5ujgI_qtLvsmGN5L4MCviYuM7CuR8zh0a-mlZlA>\n\t<xme:sGX-aZXDUT3rm2UKp_bUGTltc26I3QPIgJEOSoqG8m_wgaxh76RxQUpfVDoXqaXhE\n\tpx6TVDsOqBuNyfJKqBvGRk4dY6B8iBkS48lf6WAbLiA90KMGnFjlfs>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdduudduheejucetufdoteggodetrf\n\tdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu\n\trghilhhouhhtmecufedttdenucgopfhokfffucdluddtmdenucfjughrpefotggggffhvf\n\tffufevjghfsehtkedttdertdejnecuhfhrohhmpeflrghvihgvrhcuvfhirgcuoehflhho\n\tshhssehjvghtmhdrmhgvqeenucggtffrrghtthgvrhhnpedtudejffejkeekteelueefvd\n\tejvdeuhfefteehkeevtddvleduteekleetvdelhfenucevlhhushhtvghrufhiiigvpedt\n\tnecurfgrrhgrmhepmhgrihhlfhhrohhmpehflhhoshhssehjvghtmhdrmhgvpdhnsggprh\n\tgtphhtthhopeejpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehrohgsvghrthdr\n\tmhgruggvrhestgholhhlrggsohhrrgdrtghomhdprhgtphhtthhopegsrghrnhgrsggrsh\n\tdrphhotgiivgesihguvggrshhonhgsohgrrhgurdgtohhmpdhrtghpthhtohepkhhivghr\n\trghnrdgsihhnghhhrghmsehiuggvrghsohhnsghorghrugdrtghomhdprhgtphhtthhope\n\thlrghurhgvnhhtrdhpihhntghhrghrthesihguvggrshhonhgsohgrrhgurdgtohhmpdhr\n\ttghpthhtohepfhhlohhsshesjhgvthhmrdhmvgdprhgtphhtthhopehlihgstggrmhgvrh\n\tgrqdguvghvvghlsehlihhsthhsrdhlihgstggrmhgvrhgrrdhorhhgpdhrtghpthhtohep\n\tmhiirghmrgiirghlsehrvgguhhgrthdrtghomh", "X-ME-Proxy": "<xmx:sGX-aU6zvpufOe7UaRi3nfj87cp3O-k7Tgsczphr4BMVyX5QoNptzA>\n\t<xmx:sGX-aWna4SNcQM0J0cspLoPUJKvpLHUpmAhSdn4HQpQpTJO6wbJEWA>\n\t<xmx:sGX-aRop5d_qt0-bVyJpb6u8DlV3iO2QrigF6p0vLU80iqEAZAE83A>\n\t<xmx:sGX-ads7xflLFEtMi9POONmMSkH6Y_UoAVYTlTqs8AWXlrX-QE-Lqg>\n\t<xmx:sGX-adZxs69110aXwnMVJF9f1aEKb7yTBVgJ5I553K8-5xOTV-7Dhl_P>", "Feedback-ID": "i9dde48b3:Fastmail", "X-Mailer": "MessagingEngine.com Webmail Interface", "Content-Type": "text/plain; charset=\"utf-8\"", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "From": "Javier Tia <floss@jetm.me>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 08 May 2026 15:35:57 -0600", "Subject": "[PATCH v2 2/2] libcamera: software_isp: Use Vector operator>>= in\n\tfinishFrame", "Cc": "mzamazal@redhat.com, kieran.bingham@ideasonboard.com,\n\tlaurent.pinchart@ideasonboard.com, barnabas.pocze@ideasonboard.com,\n\trobert.mader@collabora.com", "In-Reply-To": "<177827984964.786021.2242634090011461397@jetm.me>", "References": "<177827984964.786021.2242634090011461397@jetm.me>", "Message-Id": "<20260508223736.0B7291EA006C@mailuser.phl.internal>", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Replace the three per-component right-shift assignments with a single\nsum_ >>= sumShift_ call now that Vector provides the operator.\n\nSigned-off-by: Javier Tia <floss@jetm.me>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/software_isp/swstats_cpu.cpp | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex 2e020e62..0815ec9a 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -363,9 +363,7 @@ void SwStatsCpu::finishFrame(uint32_t frame, uint32_t bufferId)\n \t\t\t\tsharedStats_->yHistogram[j] += s.yHistogram[j];\n \t\t}\n \n-\t\tsharedStats_->sum_.r() >>= sumShift_;\n-\t\tsharedStats_->sum_.g() >>= sumShift_;\n-\t\tsharedStats_->sum_.b() >>= sumShift_;\n+\t\tsharedStats_->sum_ >>= sumShift_;\n \t}\n \n \tsharedStats_->valid = valid;\n", "prefixes": [ "v2", "2/2" ] }