From patchwork Fri May 8 21:35:57 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Tia X-Patchwork-Id: 26707 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 72C94BE173 for ; Fri, 8 May 2026 22:37:41 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id F2B5A6302E; Sat, 9 May 2026 00:37:39 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=jetm.me header.i=@jetm.me header.b="jSefRTNb"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="DXE3DUaP"; dkim-atps=neutral Received: from fhigh-a5-smtp.messagingengine.com (fhigh-a5-smtp.messagingengine.com [103.168.172.156]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 21E0E62FEA for ; Sat, 9 May 2026 00:37:37 +0200 (CEST) Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfhigh.phl.internal (Postfix) with ESMTP id 298BC1400106; Fri, 8 May 2026 18:37:36 -0400 (EDT) Received: from phl-imap-07 ([10.202.2.97]) by phl-compute-02.internal (MEProxy); Fri, 08 May 2026 18:37:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jetm.me; h=cc:cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1778279856; x=1778366256; bh=rdl7FlZRDD5hPRomwZIvt+J7x8ER3CE2Z9z6Qt9njHI=; b= jSefRTNb0vkHx8JB9tQYgYSusy6CJo+dVpJTuU5A+0EAygHq31D101DTnMIhkW0T SpLbBL0DA3fgNfeQ3khNlNnEqMURsJeJsOKCU/IyNYH2JWcOl6oltMzZIJsiEGRe 3wtZdRUVR8Lwz9tn8fF6E6Y/kiovd872dPLvuveuZVrJqUr2bcXVYpFQ0JYjd0ww IUD+k9msO6cySUjdk1vS225Ewd+fU7Dr+kMTIgRib/rNtVazNY7A1FoiuUfMZ6vd 5tuZvjAW6j93jt/+uw4ZXPZ4ylFJpLqiVuW2oEsBu+aG0qJZThINWvMhvYgVv01l h+3vhbHxLOsNk2ZxjWlSDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1778279856; x= 1778366256; bh=rdl7FlZRDD5hPRomwZIvt+J7x8ER3CE2Z9z6Qt9njHI=; b=D XE3DUaPcbNJo80g3CxM7Wt9h3RHvpm0BnaXBOwb2Hn0WIDk4EKqKZUP6fb6aNl1W cxKl9tzsjrMisIwwPbFhbqPI72Ig+TldhWrgTH3xkjneIWGpqM/h12/wrgJA121+ vfq9Jo4bBvpaU51cMlPlmfBARKLzVtKSAhrDDfKDtl8GDDqIq8aKsjPSqgwlgR9e F1GdFsQAyYxVoVSkM5xauv3xFtRxnRNX80TJs97BQAQXBrvjouBvHGVoRYVvi71N rAYRc/1qhbgGFIjx7Xua+Fho3DCZyKbMLd6BUf6PHg+SoOLeWyZQNWFpd3tG+YFR Nr6r3VjzOGqnXLbDNjFVg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdduudduheejucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucgopfhokfffucdluddtmdenucfjughrpefotggggffhvf ffufevjghfsehtkedttdertdejnecuhfhrohhmpeflrghvihgvrhcuvfhirgcuoehflhho shhssehjvghtmhdrmhgvqeenucggtffrrghtthgvrhhnpedtudejffejkeekteelueefvd ejvdeuhfefteehkeevtddvleduteekleetvdelhfenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepmhgrihhlfhhrohhmpehflhhoshhssehjvghtmhdrmhgvpdhnsggprh gtphhtthhopeejpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehrohgsvghrthdr mhgruggvrhestgholhhlrggsohhrrgdrtghomhdprhgtphhtthhopegsrghrnhgrsggrsh drphhotgiivgesihguvggrshhonhgsohgrrhgurdgtohhmpdhrtghpthhtohepkhhivghr rghnrdgsihhnghhhrghmsehiuggvrghsohhnsghorghrugdrtghomhdprhgtphhtthhope hlrghurhgvnhhtrdhpihhntghhrghrthesihguvggrshhonhgsohgrrhgurdgtohhmpdhr tghpthhtohepfhhlohhsshesjhgvthhmrdhmvgdprhgtphhtthhopehlihgstggrmhgvrh grqdguvghvvghlsehlihhsthhsrdhlihgstggrmhgvrhgrrdhorhhgpdhrtghpthhtohep mhiirghmrgiirghlsehrvgguhhgrthdrtghomh X-ME-Proxy: Feedback-ID: i9dde48b3:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 0B7291EA006C; Fri, 8 May 2026 18:37:36 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 From: Javier Tia To: libcamera-devel@lists.libcamera.org Date: Fri, 08 May 2026 15:35:57 -0600 Subject: [PATCH v2 2/2] libcamera: software_isp: Use Vector operator>>= in finishFrame Cc: mzamazal@redhat.com, kieran.bingham@ideasonboard.com, laurent.pinchart@ideasonboard.com, barnabas.pocze@ideasonboard.com, robert.mader@collabora.com In-Reply-To: <177827984964.786021.2242634090011461397@jetm.me> References: <177827984964.786021.2242634090011461397@jetm.me> Message-Id: <20260508223736.0B7291EA006C@mailuser.phl.internal> X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Replace the three per-component right-shift assignments with a single sum_ >>= sumShift_ call now that Vector provides the operator. Signed-off-by: Javier Tia Reviewed-by: Laurent Pinchart --- src/libcamera/software_isp/swstats_cpu.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp index 2e020e62..0815ec9a 100644 --- a/src/libcamera/software_isp/swstats_cpu.cpp +++ b/src/libcamera/software_isp/swstats_cpu.cpp @@ -363,9 +363,7 @@ void SwStatsCpu::finishFrame(uint32_t frame, uint32_t bufferId) sharedStats_->yHistogram[j] += s.yHistogram[j]; } - sharedStats_->sum_.r() >>= sumShift_; - sharedStats_->sum_.g() >>= sumShift_; - sharedStats_->sum_.b() >>= sumShift_; + sharedStats_->sum_ >>= sumShift_; } sharedStats_->valid = valid;