[{"id":38848,"web_url":"https://patchwork.libcamera.org/comment/38848/","msgid":"<0a542313-5094-4027-93a0-1592410904c1@ideasonboard.com>","date":"2026-05-11T09:16:58","subject":"Re: [PATCH v2 2/2] libcamera: software_isp: Use Vector operator>>=\n\tin finishFrame","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 05. 08. 23:35 keltezéssel, Javier Tia írta:\n> Replace the three per-component right-shift assignments with a single\n> sum_ >>= sumShift_ call now that Vector provides the operator.\n> \n> Signed-off-by: Javier Tia \n> Reviewed-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/libcamera/software_isp/swstats_cpu.cpp | 4 +---\n> 1 file changed, 1 insertion(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\n> index 2e020e62..0815ec9a 100644\n> --- a/src/libcamera/software_isp/swstats_cpu.cpp\n> +++ b/src/libcamera/software_isp/swstats_cpu.cpp\n> @@ -363,9 +363,7 @@ void SwStatsCpu::finishFrame(uint32_t frame, uint32_t bufferId)\n> \t\t\t\tsharedStats_->yHistogram[j] += s.yHistogram[j];\n> \t\t}\n> \n> -\t\tsharedStats_->sum_.r() >>= sumShift_;\n> -\t\tsharedStats_->sum_.g() >>= sumShift_;\n> -\t\tsharedStats_->sum_.b() >>= sumShift_;\n> +\t\tsharedStats_->sum_ >>= sumShift_;\n> \t}\n> \n> \tsharedStats_->valid = valid;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 452C4BDB1C\n\tfor ;\n\tMon, 11 May 2026 09:17:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 391B463025;\n\tMon, 11 May 2026 11:17:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 89DA462010\n\tfor ;\n\tMon, 11 May 2026 11:17:02 +0200 (CEST)","from [192.168.33.37] (185.182.215.166.nat.pool.zt.hu\n\t[185.182.215.166])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 160BE73B;\n\tMon, 11 May 2026 11:16:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jHmzPgpF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778491015;\n\tbh=NZZz85ewXEiRKUW/dx5W/8CDKODPnKwfsFHJZVnsBmc=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=jHmzPgpFrZti23D9sY6yu3OfOFJbviDdNEllbDtMM2fTe7acNEULjVpaCnircj6yi\n\taVWh5/INO5QLy497GBEchTDtzyYEMiomsEM5Jb/8GjmJ0ayD6YPLDi0xvjPZOJpEec\n\tago1a3RnGayzoYlYpM/Up/Of4lfu1yFOKTzrF9xY=","Message-ID":"<0a542313-5094-4027-93a0-1592410904c1@ideasonboard.com>","Date":"Mon, 11 May 2026 11:16:58 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 2/2] libcamera: software_isp: Use Vector operator>>=\n\tin finishFrame","To":"Javier Tia , libcamera-devel@lists.libcamera.org","Cc":"mzamazal@redhat.com, kieran.bingham@ideasonboard.com,\n\tlaurent.pinchart@ideasonboard.com, robert.mader@collabora.com","References":"<177827984964.786021.2242634090011461397@jetm.me>\n\t<20260508223736.0B7291EA006C@mailuser.phl.internal>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260508223736.0B7291EA006C@mailuser.phl.internal>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]