Patch Detail
Show a patch.
GET /api/patches/26703/?format=api
{ "id": 26703, "url": "https://patchwork.libcamera.org/api/patches/26703/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26703/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260508191943.585091EA006C@mailuser.phl.internal>", "date": "2026-05-08T19:19:34", "name": "[2/2] libcamera: software_isp: Use Vector operator>>= in finishFrame", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d6c896fe666c2af07cf96b397a6523848dea2131", "submitter": { "id": 261, "url": "https://patchwork.libcamera.org/api/people/261/?format=api", "name": "Javier Tia", "email": "floss@jetm.me" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26703/mbox/", "series": [ { "id": 5927, "url": "https://patchwork.libcamera.org/api/series/5927/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5927", "date": "2026-05-08T19:19:13", "name": "libcamera: Vector right-shift operators and SwStatsCpu use site", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5927/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26703/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26703/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A84C0BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 8 May 2026 19:19:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A4556301A;\n\tFri, 8 May 2026 21:19:47 +0200 (CEST)", "from fout-a2-smtp.messagingengine.com\n\t(fout-a2-smtp.messagingengine.com [103.168.172.145])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FBB963024\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 8 May 2026 21:19:44 +0200 (CEST)", "from phl-compute-02.internal (phl-compute-02.internal\n\t[10.202.2.42])\n\tby mailfout.phl.internal (Postfix) with ESMTP id 7723CEC0344;\n\tFri, 8 May 2026 15:19:43 -0400 (EDT)", "from phl-imap-07 ([10.202.2.97])\n\tby phl-compute-02.internal (MEProxy); Fri, 08 May 2026 15:19:43 -0400", "by mailuser.phl.internal (Postfix, from userid 501)\n\tid 585091EA006C; Fri, 8 May 2026 15:19:43 -0400 (EDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=jetm.me header.i=@jetm.me header.b=\"QFQpf3OK\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"J7UIXqSI\"; \n\tdkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=jetm.me; h=cc:cc\n\t:content-transfer-encoding:content-type:content-type:date:date\n\t:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to; s=fm2; t=1778267983;\n\tx=1778354383; bh=rN6gJXu8hGL8yVpblS6Tvz19O1BvfONieZI1a0rZpVw=; b=\n\tQFQpf3OKhoaXcv/g/6/momrNUWrKCKSwvw9f52VsB/Q4fdswZFzJMydS1Ws2qPSp\n\tOftVy+jVC1whjlv/2rzdIeIqqKhxsoAHOC6jw8X76uJKz5jqv73osSyAHf1YiWMA\n\tGv1fRJ7PhFNVX77f5BB8qIl37b549DKZr9pRZQnrwjT9V3cTjQlh+6VGLsktIb9i\n\txSE29kBFbAmVgUryZIbuDEeCPNx488ZWIr5MNUe7/4FxxeyE7u7+GhFgaLzUiNVd\n\tgvxzQaxdezsWoDuqVtG8gNQqp2v0O1mS/hvWzJWB9fs9T9tC83SBciajetzk9+WW\n\tZE3PvjWzQThqvuyEIxITpw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:cc:content-transfer-encoding\n\t:content-type:content-type:date:date:feedback-id:feedback-id\n\t:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to:x-me-proxy\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1778267983; x=\n\t1778354383; bh=rN6gJXu8hGL8yVpblS6Tvz19O1BvfONieZI1a0rZpVw=; b=J\n\t7UIXqSIaHfRvYOPWGifonpbvvBqMXSlQpbs5pD8MpuA/Ovq56a9HFnnIIcSZlcpM\n\txRSMuHmPbxE4fAHR3nxiwZYtltMVNI/ro8DOX+r5d5XDVZUsnkEyYtOsc1/GtbL6\n\tU/GyXaEDixTUaTio8VubbIX9nmDO9FeZliLIkLuYHK7T4h3Hq6x868CKT2kM8i4b\n\tQpDvyOizeo1LrVDH5/pYjQsxX6maNbpAh40swWYoIPTaTvQIqQj8pdJGG6BnXTKI\n\tYC2mD62LlP4IDERKHTWq4psRbhn4T2cNXT8A8WsU+KplcEaUs+cqSa3E2hfhJTKo\n\t4Osej7O3YRIIW2dvxLm/w==" ], "X-ME-Sender": "<xms:Tzf-aYBEbosobH6JcH4pYdA9bFRK2HlG3u3bdG1SegKb_isr169Jng>\n\t<xme:Tzf-aVX-DHH5yZZErsxGqf0gtwGdXh-_SNjcxuWZ6TjC4_EJV1oFkadn4ygKCxWAY\n\tBw_qQ5SVpuwj3NwJ-t-tkoqeYdofYWwpj8-zHSsckwenHSMNm1Vsw>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdduudduudekucetufdoteggodetrf\n\tdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu\n\trghilhhouhhtmecufedttdenucgopfhokfffucdluddtmdenucfjughrpefotggggffhvf\n\tffufevjghfsehtkedttdertdejnecuhfhrohhmpeflrghvihgvrhcuvfhirgcuoehflhho\n\tshhssehjvghtmhdrmhgvqeenucggtffrrghtthgvrhhnpedtudejffejkeekteelueefvd\n\tejvdeuhfefteehkeevtddvleduteekleetvdelhfenucevlhhushhtvghrufhiiigvpedt\n\tnecurfgrrhgrmhepmhgrihhlfhhrohhmpehflhhoshhssehjvghtmhdrmhgvpdhnsggprh\n\tgtphhtthhopeejpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehrohgsvghrthdr\n\tmhgruggvrhestgholhhlrggsohhrrgdrtghomhdprhgtphhtthhopegsrghrnhgrsggrsh\n\tdrphhotgiivgesihguvggrshhonhgsohgrrhgurdgtohhmpdhrtghpthhtohepkhhivghr\n\trghnrdgsihhnghhhrghmsehiuggvrghsohhnsghorghrugdrtghomhdprhgtphhtthhope\n\thlrghurhgvnhhtrdhpihhntghhrghrthesihguvggrshhonhgsohgrrhgurdgtohhmpdhr\n\ttghpthhtohepfhhlohhsshesjhgvthhmrdhmvgdprhgtphhtthhopehlihgstggrmhgvrh\n\tgrqdguvghvvghlsehlihhsthhsrdhlihgstggrmhgvrhgrrdhorhhgpdhrtghpthhtohep\n\tmhiirghmrgiirghlsehrvgguhhgrthdrtghomh", "X-ME-Proxy": "<xmx:Tzf-aQ7LGs9MXS8d-hPuocwVfhpUQp4sYx70dbLHDSVdHBBb0nwG9Q>\n\t<xmx:Tzf-aSl3biRSo5w0VLR1-2SXJk8-w_VS-LGHSCnBatWMhvnrHiPwiQ>\n\t<xmx:Tzf-adpmmHFf7E0dDnKclkY5Dx3mwryxJTj1-UqWBBKlX6zJPtB5vw>\n\t<xmx:Tzf-aZsGkXn8rw4-C9uBwZpTxeO3OZCLGUVb-NuCWUmDqRAfTejyxw>\n\t<xmx:Tzf-abH901SidyaQkZ7JKFwYgZ_gwgt8mtp1oOlFL4llX57dLpLmNEJV>", "Feedback-ID": "i9dde48b3:Fastmail", "X-Mailer": "MessagingEngine.com Webmail Interface", "Content-Type": "text/plain; charset=\"utf-8\"", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "From": "Javier Tia <floss@jetm.me>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 08 May 2026 13:19:34 -0600", "Subject": "[PATCH 2/2] libcamera: software_isp: Use Vector operator>>= in\n\tfinishFrame", "Cc": "mzamazal@redhat.com, kieran.bingham@ideasonboard.com,\n\tlaurent.pinchart@ideasonboard.com, barnabas.pocze@ideasonboard.com,\n\trobert.mader@collabora.com", "In-Reply-To": "<177826797798.345005.11618565886801750854@jetm.me>", "References": "<177826797798.345005.11618565886801750854@jetm.me>", "Message-Id": "<20260508191943.585091EA006C@mailuser.phl.internal>", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Replace the three per-component right-shift assignments with a single\nsum_ >>= sumShift_ call now that Vector provides the operator.\n\nSigned-off-by: Javier Tia <floss@jetm.me>\n---\n src/libcamera/software_isp/swstats_cpu.cpp | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex 2e020e62..0815ec9a 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -363,9 +363,7 @@ void SwStatsCpu::finishFrame(uint32_t frame, uint32_t bufferId)\n \t\t\t\tsharedStats_->yHistogram[j] += s.yHistogram[j];\n \t\t}\n \n-\t\tsharedStats_->sum_.r() >>= sumShift_;\n-\t\tsharedStats_->sum_.g() >>= sumShift_;\n-\t\tsharedStats_->sum_.b() >>= sumShift_;\n+\t\tsharedStats_->sum_ >>= sumShift_;\n \t}\n \n \tsharedStats_->valid = valid;\n", "prefixes": [ "2/2" ] }