| Message ID | 20260508191943.585091EA006C@mailuser.phl.internal |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
On Fri, May 08, 2026 at 01:19:34PM -0600, Javier Tia wrote: > Replace the three per-component right-shift assignments with a single > sum_ >>= sumShift_ call now that Vector provides the operator. > > Signed-off-by: Javier Tia <floss@jetm.me> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/software_isp/swstats_cpu.cpp | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp > index 2e020e62..0815ec9a 100644 > --- a/src/libcamera/software_isp/swstats_cpu.cpp > +++ b/src/libcamera/software_isp/swstats_cpu.cpp > @@ -363,9 +363,7 @@ void SwStatsCpu::finishFrame(uint32_t frame, uint32_t bufferId) > sharedStats_->yHistogram[j] += s.yHistogram[j]; > } > > - sharedStats_->sum_.r() >>= sumShift_; > - sharedStats_->sum_.g() >>= sumShift_; > - sharedStats_->sum_.b() >>= sumShift_; > + sharedStats_->sum_ >>= sumShift_; > } > > sharedStats_->valid = valid;
diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp index 2e020e62..0815ec9a 100644 --- a/src/libcamera/software_isp/swstats_cpu.cpp +++ b/src/libcamera/software_isp/swstats_cpu.cpp @@ -363,9 +363,7 @@ void SwStatsCpu::finishFrame(uint32_t frame, uint32_t bufferId) sharedStats_->yHistogram[j] += s.yHistogram[j]; } - sharedStats_->sum_.r() >>= sumShift_; - sharedStats_->sum_.g() >>= sumShift_; - sharedStats_->sum_.b() >>= sumShift_; + sharedStats_->sum_ >>= sumShift_; } sharedStats_->valid = valid;
Replace the three per-component right-shift assignments with a single sum_ >>= sumShift_ call now that Vector provides the operator. Signed-off-by: Javier Tia <floss@jetm.me> --- src/libcamera/software_isp/swstats_cpu.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)