[{"id":38831,"web_url":"https://patchwork.libcamera.org/comment/38831/","msgid":"<20260508200150.GC2186850@killaraus.ideasonboard.com>","date":"2026-05-08T20:01:50","subject":"Re: [PATCH 2/2] libcamera: software_isp: Use Vector operator>>= in\n\tfinishFrame","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, May 08, 2026 at 01:19:34PM -0600, Javier Tia wrote:\n> Replace the three per-component right-shift assignments with a single\n> sum_ >>= sumShift_ call now that Vector provides the operator.\n> \n> Signed-off-by: Javier Tia \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/software_isp/swstats_cpu.cpp | 4 +---\n> 1 file changed, 1 insertion(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\n> index 2e020e62..0815ec9a 100644\n> --- a/src/libcamera/software_isp/swstats_cpu.cpp\n> +++ b/src/libcamera/software_isp/swstats_cpu.cpp\n> @@ -363,9 +363,7 @@ void SwStatsCpu::finishFrame(uint32_t frame, uint32_t bufferId)\n> \t\t\t\tsharedStats_->yHistogram[j] += s.yHistogram[j];\n> \t\t}\n> \n> -\t\tsharedStats_->sum_.r() >>= sumShift_;\n> -\t\tsharedStats_->sum_.g() >>= sumShift_;\n> -\t\tsharedStats_->sum_.b() >>= sumShift_;\n> +\t\tsharedStats_->sum_ >>= sumShift_;\n> \t}\n> \n> \tsharedStats_->valid = valid;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B6EABDCBD\n\tfor ;\n\tFri, 8 May 2026 20:01:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 520CE62FEA;\n\tFri, 8 May 2026 22:01:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C6CD62FEA\n\tfor ;\n\tFri, 8 May 2026 22:01:51 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EFD9BCA;\n\tFri, 8 May 2026 22:01:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cGAOvsLi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778270506;\n\tbh=wr7xn1/69Plkl+zl5XEAzIo4xXKy2/PD1ziB1gCYa3Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cGAOvsLiSVgZbAflK3SetoXgaRAuh8kJg5pRircJOjR9eYy3BgcJcucDvX7rMUw+X\n\tNpsNyp6LmZoR4fuzCrEHh465gIsbVoQHI7baiK8pG+ZShf6gR0gXyg3xT/WLP6K3Mf\n\t4suIYTWYQBp6K/fJKdIctqqj70oXVRgiDHX3y1f4=","Date":"Fri, 8 May 2026 23:01:50 +0300","From":"Laurent Pinchart ","To":"Javier Tia ","Cc":"libcamera-devel@lists.libcamera.org, mzamazal@redhat.com,\n\tkieran.bingham@ideasonboard.com, barnabas.pocze@ideasonboard.com,\n\trobert.mader@collabora.com","Subject":"Re: [PATCH 2/2] libcamera: software_isp: Use Vector operator>>= in\n\tfinishFrame","Message-ID":"<20260508200150.GC2186850@killaraus.ideasonboard.com>","References":"<177826797798.345005.11618565886801750854@jetm.me>\n\t<20260508191943.585091EA006C@mailuser.phl.internal>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260508191943.585091EA006C@mailuser.phl.internal>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]