Patch Detail
Show a patch.
GET /api/patches/26517/?format=api
{ "id": 26517, "url": "https://patchwork.libcamera.org/api/patches/26517/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26517/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260413114713.426459-2-barnabas.pocze@ideasonboard.com>", "date": "2026-04-13T11:47:12", "name": "[v1,2/3] libcamera: software_isp: debayer: Add missing `override`", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "66c28208f7b8fb4cf7ef53717dc221b1274e3747", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26517/mbox/", "series": [ { "id": 5880, "url": "https://patchwork.libcamera.org/api/series/5880/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5880", "date": "2026-04-13T11:47:11", "name": "[v1,1/3] libcamera: egl: Remove `eGLImage::image_`", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5880/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26517/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26517/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FD8CC32F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Apr 2026 11:47:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 75B6562E95;\n\tMon, 13 Apr 2026 13:47:20 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B44FE62E7F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Apr 2026 13:47:16 +0200 (CEST)", "from pb-laptop.local (185.182.214.8.nat.pool.zt.hu [185.182.214.8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D44927FE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Apr 2026 13:45:44 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MQT1dJyF\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776080744;\n\tbh=GPaHluTYFpcJK9VAXq+rFZ4cZl9SHze8WpG44US1exw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=MQT1dJyFkLXDMgCqMLUKh7BKasX5i/ExCSyPee7rhlC0z8Ba6Lg8pl5uyTW4q1Wyf\n\tdvSFE1EQP7PtcXZWB6EDPy7Rljf/49vtQrLSe6PMiE5m+SSj7OP9yoYBeJBMtN8Zjv\n\tgA+gS5tkYgu6v4dJ8Z23BWh5AIIhyiSdMkCoIELQ=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1 2/3] libcamera: software_isp: debayer: Add missing\n\t`override`", "Date": "Mon, 13 Apr 2026 13:47:12 +0200", "Message-ID": "<20260413114713.426459-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260413114713.426459-1-barnabas.pocze@ideasonboard.com>", "References": "<20260413114713.426459-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add the missing `override` specifiers in the derived classes of `Debayer`.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/software_isp/debayer_cpu.h | 18 +++++++++---------\n src/libcamera/software_isp/debayer_egl.h | 18 +++++++++---------\n 2 files changed, 18 insertions(+), 18 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\nindex 05fecc8fe..39a0ea6ea 100644\n--- a/src/libcamera/software_isp/debayer_cpu.h\n+++ b/src/libcamera/software_isp/debayer_cpu.h\n@@ -36,16 +36,16 @@ public:\n \n \tint configure(const StreamConfiguration &inputCfg,\n \t\t const std::vector<std::reference_wrapper<const StreamConfiguration>> &outputCfgs,\n-\t\t bool ccmEnabled);\n-\tSize patternSize(PixelFormat inputFormat);\n-\tstd::vector<PixelFormat> formats(PixelFormat input);\n+\t\t bool ccmEnabled) override;\n+\tSize patternSize(PixelFormat inputFormat) override;\n+\tstd::vector<PixelFormat> formats(PixelFormat input) override;\n \tstd::tuple<unsigned int, unsigned int>\n-\tstrideAndFrameSize(const PixelFormat &outputFormat, const Size &size);\n-\tvoid process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms);\n-\tint start();\n-\tvoid stop();\n-\tSizeRange sizes(PixelFormat inputFormat, const Size &inputSize);\n-\tconst SharedFD &getStatsFD() { return stats_->getStatsFD(); }\n+\tstrideAndFrameSize(const PixelFormat &outputFormat, const Size &size) override;\n+\tvoid process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms) override;\n+\tint start() override;\n+\tvoid stop() override;\n+\tSizeRange sizes(PixelFormat inputFormat, const Size &inputSize) override;\n+\tconst SharedFD &getStatsFD() override { return stats_->getStatsFD(); }\n \n private:\n \tfriend class DebayerCpuThread;\ndiff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\nindex bdde676f2..d563bfa55 100644\n--- a/src/libcamera/software_isp/debayer_egl.h\n+++ b/src/libcamera/software_isp/debayer_egl.h\n@@ -43,20 +43,20 @@ public:\n \n \tint configure(const StreamConfiguration &inputCfg,\n \t\t const std::vector<std::reference_wrapper<const StreamConfiguration>> &outputCfgs,\n-\t\t bool ccmEnabled);\n+\t\t bool ccmEnabled) override;\n \n-\tSize patternSize(PixelFormat inputFormat);\n+\tSize patternSize(PixelFormat inputFormat) override;\n \n-\tstd::vector<PixelFormat> formats(PixelFormat input);\n-\tstd::tuple<unsigned int, unsigned int> strideAndFrameSize(const PixelFormat &outputFormat, const Size &size);\n+\tstd::vector<PixelFormat> formats(PixelFormat input) override;\n+\tstd::tuple<unsigned int, unsigned int> strideAndFrameSize(const PixelFormat &outputFormat, const Size &size) override;\n \n-\tvoid process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms);\n-\tint start();\n-\tvoid stop();\n+\tvoid process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms) override;\n+\tint start() override;\n+\tvoid stop() override;\n \n-\tconst SharedFD &getStatsFD() { return stats_->getStatsFD(); }\n+\tconst SharedFD &getStatsFD() override { return stats_->getStatsFD(); }\n \n-\tSizeRange sizes(PixelFormat inputFormat, const Size &inputSize);\n+\tSizeRange sizes(PixelFormat inputFormat, const Size &inputSize) override;\n \n private:\n \tstatic int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n", "prefixes": [ "v1", "2/3" ] }