[{"id":38600,"web_url":"https://patchwork.libcamera.org/comment/38600/","msgid":"<177608588521.1693075.1590910456928687861@ping.linuxembedded.co.uk>","date":"2026-04-13T13:11:25","subject":"Re: [PATCH v1 2/3] libcamera: software_isp: debayer: Add missing\n\t`override`","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-04-13 12:47:12)\n> Add the missing `override` specifiers in the derived classes of `Debayer`.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/software_isp/debayer_cpu.h | 18 +++++++++---------\n> src/libcamera/software_isp/debayer_egl.h | 18 +++++++++---------\n> 2 files changed, 18 insertions(+), 18 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\n> index 05fecc8fe..39a0ea6ea 100644\n> --- a/src/libcamera/software_isp/debayer_cpu.h\n> +++ b/src/libcamera/software_isp/debayer_cpu.h\n> @@ -36,16 +36,16 @@ public:\n> \n> int configure(const StreamConfiguration &inputCfg,\n> const std::vector> &outputCfgs,\n> - bool ccmEnabled);\n> - Size patternSize(PixelFormat inputFormat);\n> - std::vector formats(PixelFormat input);\n> + bool ccmEnabled) override;\n> + Size patternSize(PixelFormat inputFormat) override;\n> + std::vector formats(PixelFormat input) override;\n> std::tuple\n> - strideAndFrameSize(const PixelFormat &outputFormat, const Size &size);\n> - void process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms);\n> - int start();\n> - void stop();\n> - SizeRange sizes(PixelFormat inputFormat, const Size &inputSize);\n> - const SharedFD &getStatsFD() { return stats_->getStatsFD(); }\n> + strideAndFrameSize(const PixelFormat &outputFormat, const Size &size) override;\n> + void process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms) override;\n> + int start() override;\n> + void stop() override;\n> + SizeRange sizes(PixelFormat inputFormat, const Size &inputSize) override;\n> + const SharedFD &getStatsFD() override { return stats_->getStatsFD(); }\n> \n> private:\n> friend class DebayerCpuThread;\n> diff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\n> index bdde676f2..d563bfa55 100644\n> --- a/src/libcamera/software_isp/debayer_egl.h\n> +++ b/src/libcamera/software_isp/debayer_egl.h\n> @@ -43,20 +43,20 @@ public:\n> \n> int configure(const StreamConfiguration &inputCfg,\n> const std::vector> &outputCfgs,\n> - bool ccmEnabled);\n> + bool ccmEnabled) override;\n> \n> - Size patternSize(PixelFormat inputFormat);\n> + Size patternSize(PixelFormat inputFormat) override;\n> \n> - std::vector formats(PixelFormat input);\n> - std::tuple strideAndFrameSize(const PixelFormat &outputFormat, const Size &size);\n> + std::vector formats(PixelFormat input) override;\n> + std::tuple strideAndFrameSize(const PixelFormat &outputFormat, const Size &size) override;\n> \n> - void process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms);\n> - int start();\n> - void stop();\n> + void process(uint32_t frame, FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms) override;\n> + int start() override;\n> + void stop() override;\n> \n> - const SharedFD &getStatsFD() { return stats_->getStatsFD(); }\n> + const SharedFD &getStatsFD() override { return stats_->getStatsFD(); }\n> \n> - SizeRange sizes(PixelFormat inputFormat, const Size &inputSize);\n> + SizeRange sizes(PixelFormat inputFormat, const Size &inputSize) override;\n> \n> private:\n> static int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n> -- \n> 2.53.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F1FEC32BB\n\tfor ;\n\tMon, 13 Apr 2026 13:11:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 880FD62E92;\n\tMon, 13 Apr 2026 15:11:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99D5F6271A\n\tfor ;\n\tMon, 13 Apr 2026 15:11:27 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9CCE47FE;\n\tMon, 13 Apr 2026 15:09:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZP2dCXuk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776085795;\n\tbh=l/Vj/W0WRqxFZESsX/AKP3bX4ou17+nFV5Q4h8tc3bw=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=ZP2dCXukIeykkVi6yD8/n9ETF3Lg4rV+pf7eAOZA21oEsJ2/khhqB0y30GNIfLhTJ\n\tnINBbYYIHneB4Qo+6Kh6V1cbNcRJ7mEBNxuamyA8KCdyrg1dh9MZcoq0cc8gWJ9LVH\n\t5TSzaaDEKMJ+F52zu27eYbHokQgDpAr9dvkkGfgw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260413114713.426459-2-barnabas.pocze@ideasonboard.com>","References":"<20260413114713.426459-1-barnabas.pocze@ideasonboard.com>\n\t<20260413114713.426459-2-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1 2/3] libcamera: software_isp: debayer: Add missing\n\t`override`","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 13 Apr 2026 14:11:25 +0100","Message-ID":"<177608588521.1693075.1590910456928687861@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]