Patch Detail
Show a patch.
GET /api/patches/18167/?format=api
{ "id": 18167, "url": "https://patchwork.libcamera.org/api/patches/18167/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18167/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230119155905.464995-5-mike.rudenko@gmail.com>", "date": "2023-01-19T15:59:05", "name": "[libcamera-devel,4/4] ipa: rkisp1: Raise maximum analogue gain", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ac72192e1b0e80758ce8164e5486bd6f89ef0a1d", "submitter": { "id": 146, "url": "https://patchwork.libcamera.org/api/people/146/?format=api", "name": "Mikhail Rudenko", "email": "mike.rudenko@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18167/mbox/", "series": [ { "id": 3716, "url": "https://patchwork.libcamera.org/api/series/3716/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3716", "date": "2023-01-19T15:59:01", "name": "Add Omnivision OV4689 support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3716/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18167/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18167/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB9CBC3240\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Jan 2023 16:07:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7E0D625F4;\n\tThu, 19 Jan 2023 17:07:43 +0100 (CET)", "from mail-lj1-x229.google.com (mail-lj1-x229.google.com\n\t[IPv6:2a00:1450:4864:20::229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BACDC625E7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Jan 2023 16:59:14 +0100 (CET)", "by mail-lj1-x229.google.com with SMTP id s25so2585251lji.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Jan 2023 07:59:14 -0800 (PST)", "from localhost (93-80-66-125.broadband.corbina.ru. [93.80.66.125])\n\tby smtp.gmail.com with ESMTPSA id\n\tbi19-20020a05651c231300b0027fb7d64775sm4362138ljb.62.2023.01.19.07.59.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 19 Jan 2023 07:59:13 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674144463;\n\tbh=MvvDczy5PAgzVLfgStIMZXX/wNkdCRJ9+zE3LiHO8G4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MLM8YYZamY9XTkdjS64wxCf69rOziAA3xSL3YI08Z+KokeOOuC5eYNRqqJd+argUY\n\tTmrIwOCkBrwHPjOFwH68blwxIyTLKTfLyPYQ4VGUCyCRfuTk2nOmXH6aT53+UjCzgv\n\thi1empt38s26BIbvRH1+SLhWEL970SNMiSScXzhPgDUcYtZNaOZIYDUcLA6F3JmCxi\n\tXPtv2RQrUBFFQTZlmI8aA1bl68ABGLcuoPs12+KQI0I5Z2WxRBMrml5FaYY+UOqUNy\n\t4kmwzhlAiPxs8QnuiTZJ9GXxIM52NO5iC/YPphGLlH+SCbxhHHhCApaxDqDcry66LY\n\tc6SML/R5aF/Lg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=VC6xXHMIqN8vfkZCO4s5Tw5RNc4P7VzK0mV10ja24tM=;\n\tb=gc3Uc8vBzV0jY2L7HgpUGuIfxtXaVFIhcyRfCw6tOhKaTqM5p/HZZ9CAxM6rPwE7LL\n\tzvjwLkhXvqLSHLcr734FZ3AvfZymp6VeZzDhkDmcpZnvIqZQhZ0kFx5gKNu6CqtBa1tk\n\tTtPdLCRGPfM7nVeynJpX3lHw6Woc4Aj1I4N3/qAVY0T3xOv+ygyCysxGMwFo725Twf5l\n\toLSn3B+RWLgLrWcbkdFZ4frn5G8mETMM+zn5MBNcDTscc317bGBtAWul56oEwQ59g7gi\n\tnhKsnbBLCbYE5EK3kJvBkyZuMSdhbYEcW24r7Eebyii51OK9uILIUqjxWyq/GTHDirYh\n\tZzvA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"gc3Uc8vB\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=VC6xXHMIqN8vfkZCO4s5Tw5RNc4P7VzK0mV10ja24tM=;\n\tb=jGdVqjr7FDb120Oc6mFmXbb3qn4dzmiRcTNLVKLny6rFzCDbbJggttaQxAgbbAp+iP\n\tfUoF3+CDLv95zHJWZTSk+acQ2I5FsA408WXmEDxe+cRq6Ogt9D0bQILj8IlR/IKEYoAj\n\tf3mi6SiGfEJFSPOJ8tDpe2E1vYZVO+WhsGtHFj+nFXYJBFvUhZ1CVY/lXjcDL2l4co3/\n\tSCKjhHMwU0xcoQzbUlmk/nMeoF8/G0CZT+kenbu2tI7Ab8S2g6pjXUFRsQlMIVECyQHq\n\tqPqBlHe3fhmUjt6/d+6MjgbHZFP+Kavg7ZM8GkP9FRRXurMiPr/uaDVc55PpQITNDzAH\n\tbmbA==", "X-Gm-Message-State": "AFqh2kptJfHXNHoZ85LJO2SamqQWWm8rXlQAAac3pvts1YlfyCn7pYNr\n\tcEb/shetoR8n882qAmEi1NVOvOCgxbQ=", "X-Google-Smtp-Source": "AMrXdXuOlJOpvtfV1lSlnfDPlZV9zej+tBlX23E1rxo7K1tX4Chq93g9pdd0YFZwyC225Q8kzSGAZw==", "X-Received": "by 2002:a05:651c:149:b0:28b:7997:8400 with SMTP id\n\tc9-20020a05651c014900b0028b79978400mr2989241ljd.46.1674143953714; \n\tThu, 19 Jan 2023 07:59:13 -0800 (PST)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 19 Jan 2023 18:59:05 +0300", "Message-Id": "<20230119155905.464995-5-mike.rudenko@gmail.com>", "X-Mailer": "git-send-email 2.39.0", "In-Reply-To": "<20230119155905.464995-1-mike.rudenko@gmail.com>", "References": "<20230119155905.464995-1-mike.rudenko@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Thu, 19 Jan 2023 17:07:39 +0100", "Subject": "[libcamera-devel] [PATCH 4/4] ipa: rkisp1: Raise maximum analogue\n\tgain", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Mikhail Rudenko via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Mikhail Rudenko <mike.rudenko@gmail.com>", "Cc": "Mikhail Rudenko <mike.rudenko@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Omnivision OV4689 sensor driver exposes maximum analogue gain of\n16x. Raise kMaxAnalogueGain to 16.0, so that the full gain range can\nbe used.\n\nSigned-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>\n---\n src/ipa/rkisp1/algorithms/agc.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex e3470e25..e4cb2fc7 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -38,7 +38,7 @@ LOG_DEFINE_CATEGORY(RkISP1Agc)\n \n /* Limits for analogue gain values */\n static constexpr double kMinAnalogueGain = 1.0;\n-static constexpr double kMaxAnalogueGain = 8.0;\n+static constexpr double kMaxAnalogueGain = 16.0;\n \n /* \\todo Honour the FrameDurationLimits control instead of hardcoding a limit */\n static constexpr utils::Duration kMaxShutterSpeed = 60ms;\n", "prefixes": [ "libcamera-devel", "4/4" ] }