From patchwork Thu Jan 19 15:59:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Rudenko X-Patchwork-Id: 18164 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7734EC3240 for ; Thu, 19 Jan 2023 16:07:43 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4E0F5625E4; Thu, 19 Jan 2023 17:07:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1674144462; bh=x00+yf95Zd2qZnb4br41FnejQCvUU7Zq6GZZMTHU74Y=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=rXvh02xsFm6fVb6EsGq4LR6ta6O7vYV4aThnn/rZOckCO35Ajz7juS2167DWLtPML UfeFtl+BLJr3OPn0tlTOpWHLgA6wzVdRay4v33f06c1uhH6FG0vXHJk/XaKQ0AOwGH fGiVZQdb4F5MrBonsnpAkZqb6mJwLlAfJNNICaAUJ70tv9vVt080z/Tt/EB8X7W3vm W4C03SSrGV80k5Gzf5DN7Mr6z/aE3s7aVR4oCM2NrYKAiLJruJ53g6F89mgLt209t3 /3zB7Zllxs7q8+hh+eLsREdNgVNQef5f8NIfXuV/ixajq3MWBzQM/D6A5iKQ7MDtX4 GcYmd8TfEvKWg== Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E52D61EFE for ; Thu, 19 Jan 2023 16:59:11 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="o4WjUX/g"; dkim-atps=neutral Received: by mail-lf1-x129.google.com with SMTP id d30so3863215lfv.8 for ; Thu, 19 Jan 2023 07:59:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AwynBKZgRx9hk8hVR9rVrW5GNMUaUNlULla1hEAc2jA=; b=o4WjUX/gO2kn8VniYickcnZtgyqfO3XZWuQnIz40X/vYruG1+IFRqX5OjivfhFOWw0 V3vt5MfCRuVATH/vFRCKK/co1EUu9XxBjtcCI9I3AmDzKH2MydCXemzWhFsvu66PE8IQ aJWdSWWubKkepSLP1e4YCYS+KMSYGoQOBdv1G8KSHenXy/yxXfJRw29QdnKZcvxbplNN w1uf6jbgZabWQVIT6JLCAzgmnzRf9ihH4VkYKj/LTcMKd9e7cZ4+W8xDZJ3dwnbRH1nn jMOdjEC3d0KjgCfaACjoXZ9hxxXgsmZXEtYx/04y3i9dlDbhuwd2jNnJ/XHe8MgFhjc5 VPVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AwynBKZgRx9hk8hVR9rVrW5GNMUaUNlULla1hEAc2jA=; b=57fDT9MFhOvcN6PVASfn4lEd2fKvDtjELWWYFbuXR4wYmGVhCOEHkg7f9sz4CbP+CP DHydYhhJhOGKHQ5vWuGYYY3jJdysrt8Q5cKIDrZAsGlcY8iQLnOeQaTOY0eP/jKdr/7y bygzEOHAh6U5EwPbx8AMmCInFYaZATkLvNNKHwbyXWwekPeMN6Ndd2QuhUtAzQ0R+j70 Ng9tTfztAZ7//LiJwz2P2KsN5mE3/T2DoVE3uGwcvXJgKbpmpojCyERkXJ6Jr8F2h009 dbAkPClD8p0DKiiSMtbzMMrhAx9LVNRqMxjkalcocPfs6wspyrtOyX8K5apTH7rzTqH3 yTOw== X-Gm-Message-State: AFqh2kogP7MAdlpdasDxDbGUZIsCqIJPacbT0fMTBOF4/uK4mG7F8Erm 18hy09KVpbF3N6KLFscUWvJ+o6Q/Xa8= X-Google-Smtp-Source: AMrXdXsKBJYYTBVvek/yKZdAY4o+O46c26nkT6uIPdrJz9h8apRK2vv/8xNKOcUhSBnwfA2lbZkHOg== X-Received: by 2002:a19:ca1d:0:b0:4a4:68b7:dedc with SMTP id a29-20020a19ca1d000000b004a468b7dedcmr5606728lfg.56.1674143950074; Thu, 19 Jan 2023 07:59:10 -0800 (PST) Received: from localhost (93-80-66-125.broadband.corbina.ru. [93.80.66.125]) by smtp.gmail.com with ESMTPSA id w17-20020a05651234d100b004cb1e2f8f4dsm5908149lfr.152.2023.01.19.07.59.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 07:59:09 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Thu, 19 Jan 2023 18:59:02 +0300 Message-Id: <20230119155905.464995-2-mike.rudenko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230119155905.464995-1-mike.rudenko@gmail.com> References: <20230119155905.464995-1-mike.rudenko@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 19 Jan 2023 17:07:39 +0100 Subject: [libcamera-devel] [PATCH 1/4] ipa: camera_sensor_helper: Add OV4689 support X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mikhail Rudenko via libcamera-devel From: Mikhail Rudenko Reply-To: Mikhail Rudenko Cc: Mikhail Rudenko Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add support for Omnivision OV4689 image sensor to libipa. The sensor implements a linear gain equation with analogue gain control values 0-2047 corresponding to 0x-16x physical gain range. Signed-off-by: Mikhail Rudenko Reviewed-by: Jacopo Mondi --- src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index 3d8a2835..075c568e 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -461,6 +461,17 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER("ov2740", CameraSensorHelperOv2740) +class CameraSensorHelperOv4689 : public CameraSensorHelper +{ +public: + CameraSensorHelperOv4689() + { + gainType_ = AnalogueGainLinear; + gainConstants_.linear = { 1, 0, 0, 128 }; + } +}; +REGISTER_CAMERA_SENSOR_HELPER("ov4689", CameraSensorHelperOv4689) + class CameraSensorHelperOv5640 : public CameraSensorHelper { public: From patchwork Thu Jan 19 15:59:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Rudenko X-Patchwork-Id: 18165 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4CAFFC3294 for ; Thu, 19 Jan 2023 16:07:44 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D908D625E8; Thu, 19 Jan 2023 17:07:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1674144462; bh=WmWAaItbql5zS7SKSvvOkJrefb0u2CCVLYjt+fXXsg4=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=FTLWto5U/uD8/35s59utIe+UTuXs/c69u/NTOK5YF1fbQM5oR4zg7D7trnu8+OWh0 yRkji6UgYePljWDihi+2K42ba5s2DdF0M7u5c5htaUXRnMjB2Rjk74utJh9w6RkTL4 5Y9bBxQruX8zpB9zoBemNkfpoPIzTiTlEPCaqN41BCM2gHGAeTa/4M11Jar5n0/nXk 47IfzwPpDelIfHYMRuhnaQYROmkboAQYyxILQSQMxhoU9iQkHmrL/rXQeQAhCmtl9k Qe6AgCgeQknkzPvW8eUrQP+Yez385W4NUq8c3gpffaMTDiGlAzwYD999HCbkcooeps P7q36jNtbZ0uA== Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 45DB8625E4 for ; Thu, 19 Jan 2023 16:59:12 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QBnnE1i2"; dkim-atps=neutral Received: by mail-lj1-x235.google.com with SMTP id g14so2542983ljh.10 for ; Thu, 19 Jan 2023 07:59:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mQ92gHWPZPxj4Fla0uqBAHNhW9LvwGXAZJK8CyJxafc=; b=QBnnE1i2R/hIvcuCp0PCqvhGwy4+KYoiGLK+i04BoMD4YwsuhkP8WOU3/wMKHHx1Mi aMypuYSSPtz5dhVeFaQFdfWlRnkW8MeVKvXbq8yEshU7y+g+TF9DydKPqsBLudGisI5f qh3S0QTRyqVTv6/fa5XRGKGNc17ogIlF9aHnhra9gtEsgSf3xjYVBnLFKec1KYLZkvhY FPECvAHJVjO16UbnpbmpPAzQwDEPjxIq0JiRIhLyyDYbW12Kn1dGSG2lEKGlCpBiCzf2 kqhMQptvRlsul5/CRa05YO7Qt7KqrLxKE2H1b9YBjg8qZar8EiGhznSPYURXf4761Dp6 dp0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mQ92gHWPZPxj4Fla0uqBAHNhW9LvwGXAZJK8CyJxafc=; b=VMfDinGrsP0Ylh5cYAzs5d0sZvWiGL4naC/IZ50epRDM97yUIrVhFJ4VZiSgHUHoAe P4s8X1frJsFT4MEpvTrLKrFvrdKMdMKPr2c+eH1MnJYUX1wsRvKKzduCHinKybdLH0DP Oyp0Itzq6VWJUXwS5Jk8YvHoifLfavgN1sk3FetQf/eQW56O3Z8wD2/PW1lnIHaLO/fd lb5chst0nFoEwVacZn7VWcB0QB39tjVNPZlxiYNnVaLjPzuFU1+DOpgoctzRQl8HQ3sK w8Bsdv23eYintwpM2IpGFa6At7Vgp2JTyT0XM0l30nDPAHHwQiJgslD6QOOpf4XoSE6I ukGQ== X-Gm-Message-State: AFqh2koBxCLScs1u1J4pwG1t2FF1gcS2poYyzaqxjf7KPqjSE66W5giG CCQ+8m069FHEvrVnFaSXQBMf2+s0bVc= X-Google-Smtp-Source: AMrXdXtTQQbGtK56HVfKCswuFARjOuqR8lUPYfT15S20xq6KjMXDU27pzXqRCT0qW+7F1EjOhYQEsg== X-Received: by 2002:a2e:9058:0:b0:28b:802d:ece8 with SMTP id n24-20020a2e9058000000b0028b802dece8mr2762323ljg.33.1674143951300; Thu, 19 Jan 2023 07:59:11 -0800 (PST) Received: from localhost (93-80-66-125.broadband.corbina.ru. [93.80.66.125]) by smtp.gmail.com with ESMTPSA id k10-20020a05651c10aa00b0027fb9e64bd0sm1783013ljn.86.2023.01.19.07.59.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 07:59:10 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Thu, 19 Jan 2023 18:59:03 +0300 Message-Id: <20230119155905.464995-3-mike.rudenko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230119155905.464995-1-mike.rudenko@gmail.com> References: <20230119155905.464995-1-mike.rudenko@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 19 Jan 2023 17:07:39 +0100 Subject: [libcamera-devel] [PATCH 2/4] libcamera: camera_sensor: Add OV4689 sensor properties X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mikhail Rudenko via libcamera-devel From: Mikhail Rudenko Reply-To: Mikhail Rudenko Cc: Mikhail Rudenko Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add an entry to the sensor properties for Omnivision OV4689. Kernel supports three more types of color bars patterns, which we do not expose now. Signed-off-by: Mikhail Rudenko --- src/libcamera/camera_sensor_properties.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp index c3c2cace..ca8ef962 100644 --- a/src/libcamera/camera_sensor_properties.cpp +++ b/src/libcamera/camera_sensor_properties.cpp @@ -130,6 +130,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen { controls::draft::TestPatternModeColorBars, 1}, }, } }, + { "ov4689", { + .unitCellSize = { 2000, 2000 }, + .testPatternModes = { + { controls::draft::TestPatternModeOff, 0 }, + { controls::draft::TestPatternModeColorBars, 1}, // TODO: more patterns + }, + } }, { "ov5640", { .unitCellSize = { 1400, 1400 }, .testPatternModes = { From patchwork Thu Jan 19 15:59:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Rudenko X-Patchwork-Id: 18166 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B5915C3295 for ; Thu, 19 Jan 2023 16:07:44 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 58CFB625F0; Thu, 19 Jan 2023 17:07:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1674144463; bh=/iBlctyk4TSp/X/kQrrD0CU8/lu2bOnXAgPgk8uX+Lw=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=p54Rdpemm1y1z66y3auqfZc8AiyvgrGTx+iHO5ukOXxLmDyw58hRMxbrfV0n6roGc HEImBqoEY1YyqZuSwH7OJMi/UFNZzpi0VF/wVe/zgZ/JK8jDgyHzdGUsbWSbNdQfIm V+DzBZ/oets3W2ZxW95H3JtWlGQ6g3K+BxTxVGQFYiEig/7nG/Brt0UuPvIMkBwh+W jxuZnNZzpNhDbEpXlhMSK9Q2RbFUzHamUF1DYXSfY/EZO4N8542NMTqLGy0LRyJ4c/ zlGPwCst2Wg09MBPlfda5ai9SoWdJ5eyDriJIySKoHWxRNRx6lmg6cuED290Ni216x Kmnmxv6YG87qQ== Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 55C86625E7 for ; Thu, 19 Jan 2023 16:59:13 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="aA1LNKvc"; dkim-atps=neutral Received: by mail-lj1-x233.google.com with SMTP id p25so2536905ljn.12 for ; Thu, 19 Jan 2023 07:59:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K85cyn9uBZ7pObkM3EhBgwE5xqmAxKY+28ZXWbVRdXQ=; b=aA1LNKvc13Kr7auxSLvCQ+Aeu2vCkB0mdfyHEDqhjWpivIqR1i5YTg7rkeFa0PRYVl DdetUOJ5Qg9xTranBmFqnAkCO8iZVqjTMHnUqnNW/Ylqu3nYRVe3lK5rtVYUjaL01ImA qLK9TC/lCHgAIJn1ZgY/4p6uXBRA8sn0y05e033KZdy2FH8clxad6tgAgCF8TgtBurnE dcicZMWZY9Dm64Puay178EBtsXu1f7UM9M1QWUIRxUHX5003XRZQogTpRPFjB7ZUeumS eUxm+g+DZwkkwG2vbCoMA8AB0lo3HQnoWOgj/EsLnsgslXIRvG6XR1vcn0nlTYcylijj R1rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K85cyn9uBZ7pObkM3EhBgwE5xqmAxKY+28ZXWbVRdXQ=; b=nVcEsn13hiQiHMkVS0FYRqNfTsRYwzJWhm0Hlh2MSn9K+Jnxewl104Exu3BU6H+JwU nO2+6MPUaE3kVx0QwfC534R9ljdNU4cZsjr9hyiLP7M2mK0ihkhJy4HLKOhTU9/M7Djj QCZ27YdSKFvcMDzJtK56NUkcbzCc018CrW3gJ+mCE2zF2XLGfjtYYB9oXr5qWja8SwPm U++nP8/Gxgs4PcDxa3LmJEjK4k1/VVcs9Wo9Tdfd1d+eLnifYex9QmmMDDClwX7uzBXC 7SLiVosWGn4GkL9hBPFpJ0Ej11jKCXnlJZN6r6WQurI3jv492y9S0XsfiGrnfz8s6qbM 5gTA== X-Gm-Message-State: AFqh2kplgdbd6elQLcLRA3btYPtA+8wQoT1fAuUccFWM+tF5rO5Hxu6N JI++MTUCUoZFsmVMEj+OGVJXi9H4ccE= X-Google-Smtp-Source: AMrXdXvs7Vke+fv+cNqNR6XoRRhZNE2jLAUUPvnYNwPrpsTslrOEglNWGYR48Gtchwzsx3JMsLnZJA== X-Received: by 2002:a2e:82c3:0:b0:288:fe5a:4a59 with SMTP id n3-20020a2e82c3000000b00288fe5a4a59mr3014408ljh.33.1674143952532; Thu, 19 Jan 2023 07:59:12 -0800 (PST) Received: from localhost (93-80-66-125.broadband.corbina.ru. [93.80.66.125]) by smtp.gmail.com with ESMTPSA id p13-20020a2e740d000000b00284e8f3020asm3887492ljc.6.2023.01.19.07.59.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 07:59:12 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Thu, 19 Jan 2023 18:59:04 +0300 Message-Id: <20230119155905.464995-4-mike.rudenko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230119155905.464995-1-mike.rudenko@gmail.com> References: <20230119155905.464995-1-mike.rudenko@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 19 Jan 2023 17:07:39 +0100 Subject: [libcamera-devel] [PATCH 3/4] ipa: rkisp1: Add OV4689 tuning file X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mikhail Rudenko via libcamera-devel From: Mikhail Rudenko Reply-To: Mikhail Rudenko Cc: Mikhail Rudenko Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add a minimal tuning file for Omnivision OV4689, specifying black level subtraction level. Signed-off-by: Mikhail Rudenko Reviewed-by: Jacopo Mondi --- src/ipa/rkisp1/data/meson.build | 1 + src/ipa/rkisp1/data/ov4689.yaml | 13 +++++++++++++ 2 files changed, 14 insertions(+) create mode 100644 src/ipa/rkisp1/data/ov4689.yaml diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build index c3b4e388..f5e9fa75 100644 --- a/src/ipa/rkisp1/data/meson.build +++ b/src/ipa/rkisp1/data/meson.build @@ -2,6 +2,7 @@ conf_files = files([ 'imx219.yaml', + 'ov4689.yaml', 'ov5640.yaml', 'uncalibrated.yaml', ]) diff --git a/src/ipa/rkisp1/data/ov4689.yaml b/src/ipa/rkisp1/data/ov4689.yaml new file mode 100644 index 00000000..750b369e --- /dev/null +++ b/src/ipa/rkisp1/data/ov4689.yaml @@ -0,0 +1,13 @@ +# SPDX-License-Identifier: CC0-1.0 +%YAML 1.1 +--- +version: 1 +algorithms: + - Agc: + - Awb: + - BlackLevelCorrection: + R: 64 + Gr: 64 + Gb: 64 + B: 64 +... From patchwork Thu Jan 19 15:59:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Rudenko X-Patchwork-Id: 18167 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EB9CBC3240 for ; Thu, 19 Jan 2023 16:07:44 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B7E0D625F4; Thu, 19 Jan 2023 17:07:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1674144463; bh=MvvDczy5PAgzVLfgStIMZXX/wNkdCRJ9+zE3LiHO8G4=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=MLM8YYZamY9XTkdjS64wxCf69rOziAA3xSL3YI08Z+KokeOOuC5eYNRqqJd+argUY TmrIwOCkBrwHPjOFwH68blwxIyTLKTfLyPYQ4VGUCyCRfuTk2nOmXH6aT53+UjCzgv hi1empt38s26BIbvRH1+SLhWEL970SNMiSScXzhPgDUcYtZNaOZIYDUcLA6F3JmCxi XPtv2RQrUBFFQTZlmI8aA1bl68ABGLcuoPs12+KQI0I5Z2WxRBMrml5FaYY+UOqUNy 4kmwzhlAiPxs8QnuiTZJ9GXxIM52NO5iC/YPphGLlH+SCbxhHHhCApaxDqDcry66LY c6SML/R5aF/Lg== Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BACDC625E7 for ; Thu, 19 Jan 2023 16:59:14 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="gc3Uc8vB"; dkim-atps=neutral Received: by mail-lj1-x229.google.com with SMTP id s25so2585251lji.2 for ; Thu, 19 Jan 2023 07:59:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VC6xXHMIqN8vfkZCO4s5Tw5RNc4P7VzK0mV10ja24tM=; b=gc3Uc8vBzV0jY2L7HgpUGuIfxtXaVFIhcyRfCw6tOhKaTqM5p/HZZ9CAxM6rPwE7LL zvjwLkhXvqLSHLcr734FZ3AvfZymp6VeZzDhkDmcpZnvIqZQhZ0kFx5gKNu6CqtBa1tk TtPdLCRGPfM7nVeynJpX3lHw6Woc4Aj1I4N3/qAVY0T3xOv+ygyCysxGMwFo725Twf5l oLSn3B+RWLgLrWcbkdFZ4frn5G8mETMM+zn5MBNcDTscc317bGBtAWul56oEwQ59g7gi nhKsnbBLCbYE5EK3kJvBkyZuMSdhbYEcW24r7Eebyii51OK9uILIUqjxWyq/GTHDirYh ZzvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VC6xXHMIqN8vfkZCO4s5Tw5RNc4P7VzK0mV10ja24tM=; b=jGdVqjr7FDb120Oc6mFmXbb3qn4dzmiRcTNLVKLny6rFzCDbbJggttaQxAgbbAp+iP fUoF3+CDLv95zHJWZTSk+acQ2I5FsA408WXmEDxe+cRq6Ogt9D0bQILj8IlR/IKEYoAj f3mi6SiGfEJFSPOJ8tDpe2E1vYZVO+WhsGtHFj+nFXYJBFvUhZ1CVY/lXjcDL2l4co3/ SCKjhHMwU0xcoQzbUlmk/nMeoF8/G0CZT+kenbu2tI7Ab8S2g6pjXUFRsQlMIVECyQHq qPqBlHe3fhmUjt6/d+6MjgbHZFP+Kavg7ZM8GkP9FRRXurMiPr/uaDVc55PpQITNDzAH bmbA== X-Gm-Message-State: AFqh2kptJfHXNHoZ85LJO2SamqQWWm8rXlQAAac3pvts1YlfyCn7pYNr cEb/shetoR8n882qAmEi1NVOvOCgxbQ= X-Google-Smtp-Source: AMrXdXuOlJOpvtfV1lSlnfDPlZV9zej+tBlX23E1rxo7K1tX4Chq93g9pdd0YFZwyC225Q8kzSGAZw== X-Received: by 2002:a05:651c:149:b0:28b:7997:8400 with SMTP id c9-20020a05651c014900b0028b79978400mr2989241ljd.46.1674143953714; Thu, 19 Jan 2023 07:59:13 -0800 (PST) Received: from localhost (93-80-66-125.broadband.corbina.ru. [93.80.66.125]) by smtp.gmail.com with ESMTPSA id bi19-20020a05651c231300b0027fb7d64775sm4362138ljb.62.2023.01.19.07.59.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 07:59:13 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Thu, 19 Jan 2023 18:59:05 +0300 Message-Id: <20230119155905.464995-5-mike.rudenko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230119155905.464995-1-mike.rudenko@gmail.com> References: <20230119155905.464995-1-mike.rudenko@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 19 Jan 2023 17:07:39 +0100 Subject: [libcamera-devel] [PATCH 4/4] ipa: rkisp1: Raise maximum analogue gain X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mikhail Rudenko via libcamera-devel From: Mikhail Rudenko Reply-To: Mikhail Rudenko Cc: Mikhail Rudenko Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Omnivision OV4689 sensor driver exposes maximum analogue gain of 16x. Raise kMaxAnalogueGain to 16.0, so that the full gain range can be used. Signed-off-by: Mikhail Rudenko --- src/ipa/rkisp1/algorithms/agc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp index e3470e25..e4cb2fc7 100644 --- a/src/ipa/rkisp1/algorithms/agc.cpp +++ b/src/ipa/rkisp1/algorithms/agc.cpp @@ -38,7 +38,7 @@ LOG_DEFINE_CATEGORY(RkISP1Agc) /* Limits for analogue gain values */ static constexpr double kMinAnalogueGain = 1.0; -static constexpr double kMaxAnalogueGain = 8.0; +static constexpr double kMaxAnalogueGain = 16.0; /* \todo Honour the FrameDurationLimits control instead of hardcoding a limit */ static constexpr utils::Duration kMaxShutterSpeed = 60ms;