From patchwork Thu Jan 19 15:59:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Rudenko X-Patchwork-Id: 18167 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EB9CBC3240 for ; Thu, 19 Jan 2023 16:07:44 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B7E0D625F4; Thu, 19 Jan 2023 17:07:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1674144463; bh=MvvDczy5PAgzVLfgStIMZXX/wNkdCRJ9+zE3LiHO8G4=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=MLM8YYZamY9XTkdjS64wxCf69rOziAA3xSL3YI08Z+KokeOOuC5eYNRqqJd+argUY TmrIwOCkBrwHPjOFwH68blwxIyTLKTfLyPYQ4VGUCyCRfuTk2nOmXH6aT53+UjCzgv hi1empt38s26BIbvRH1+SLhWEL970SNMiSScXzhPgDUcYtZNaOZIYDUcLA6F3JmCxi XPtv2RQrUBFFQTZlmI8aA1bl68ABGLcuoPs12+KQI0I5Z2WxRBMrml5FaYY+UOqUNy 4kmwzhlAiPxs8QnuiTZJ9GXxIM52NO5iC/YPphGLlH+SCbxhHHhCApaxDqDcry66LY c6SML/R5aF/Lg== Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BACDC625E7 for ; Thu, 19 Jan 2023 16:59:14 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="gc3Uc8vB"; dkim-atps=neutral Received: by mail-lj1-x229.google.com with SMTP id s25so2585251lji.2 for ; Thu, 19 Jan 2023 07:59:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VC6xXHMIqN8vfkZCO4s5Tw5RNc4P7VzK0mV10ja24tM=; b=gc3Uc8vBzV0jY2L7HgpUGuIfxtXaVFIhcyRfCw6tOhKaTqM5p/HZZ9CAxM6rPwE7LL zvjwLkhXvqLSHLcr734FZ3AvfZymp6VeZzDhkDmcpZnvIqZQhZ0kFx5gKNu6CqtBa1tk TtPdLCRGPfM7nVeynJpX3lHw6Woc4Aj1I4N3/qAVY0T3xOv+ygyCysxGMwFo725Twf5l oLSn3B+RWLgLrWcbkdFZ4frn5G8mETMM+zn5MBNcDTscc317bGBtAWul56oEwQ59g7gi nhKsnbBLCbYE5EK3kJvBkyZuMSdhbYEcW24r7Eebyii51OK9uILIUqjxWyq/GTHDirYh ZzvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VC6xXHMIqN8vfkZCO4s5Tw5RNc4P7VzK0mV10ja24tM=; b=jGdVqjr7FDb120Oc6mFmXbb3qn4dzmiRcTNLVKLny6rFzCDbbJggttaQxAgbbAp+iP fUoF3+CDLv95zHJWZTSk+acQ2I5FsA408WXmEDxe+cRq6Ogt9D0bQILj8IlR/IKEYoAj f3mi6SiGfEJFSPOJ8tDpe2E1vYZVO+WhsGtHFj+nFXYJBFvUhZ1CVY/lXjcDL2l4co3/ SCKjhHMwU0xcoQzbUlmk/nMeoF8/G0CZT+kenbu2tI7Ab8S2g6pjXUFRsQlMIVECyQHq qPqBlHe3fhmUjt6/d+6MjgbHZFP+Kavg7ZM8GkP9FRRXurMiPr/uaDVc55PpQITNDzAH bmbA== X-Gm-Message-State: AFqh2kptJfHXNHoZ85LJO2SamqQWWm8rXlQAAac3pvts1YlfyCn7pYNr cEb/shetoR8n882qAmEi1NVOvOCgxbQ= X-Google-Smtp-Source: AMrXdXuOlJOpvtfV1lSlnfDPlZV9zej+tBlX23E1rxo7K1tX4Chq93g9pdd0YFZwyC225Q8kzSGAZw== X-Received: by 2002:a05:651c:149:b0:28b:7997:8400 with SMTP id c9-20020a05651c014900b0028b79978400mr2989241ljd.46.1674143953714; Thu, 19 Jan 2023 07:59:13 -0800 (PST) Received: from localhost (93-80-66-125.broadband.corbina.ru. [93.80.66.125]) by smtp.gmail.com with ESMTPSA id bi19-20020a05651c231300b0027fb7d64775sm4362138ljb.62.2023.01.19.07.59.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 07:59:13 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Thu, 19 Jan 2023 18:59:05 +0300 Message-Id: <20230119155905.464995-5-mike.rudenko@gmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230119155905.464995-1-mike.rudenko@gmail.com> References: <20230119155905.464995-1-mike.rudenko@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 19 Jan 2023 17:07:39 +0100 Subject: [libcamera-devel] [PATCH 4/4] ipa: rkisp1: Raise maximum analogue gain X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mikhail Rudenko via libcamera-devel From: Mikhail Rudenko Reply-To: Mikhail Rudenko Cc: Mikhail Rudenko Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Omnivision OV4689 sensor driver exposes maximum analogue gain of 16x. Raise kMaxAnalogueGain to 16.0, so that the full gain range can be used. Signed-off-by: Mikhail Rudenko --- src/ipa/rkisp1/algorithms/agc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp index e3470e25..e4cb2fc7 100644 --- a/src/ipa/rkisp1/algorithms/agc.cpp +++ b/src/ipa/rkisp1/algorithms/agc.cpp @@ -38,7 +38,7 @@ LOG_DEFINE_CATEGORY(RkISP1Agc) /* Limits for analogue gain values */ static constexpr double kMinAnalogueGain = 1.0; -static constexpr double kMaxAnalogueGain = 8.0; +static constexpr double kMaxAnalogueGain = 16.0; /* \todo Honour the FrameDurationLimits control instead of hardcoding a limit */ static constexpr utils::Duration kMaxShutterSpeed = 60ms;