Patch Detail
Show a patch.
GET /api/patches/17140/?format=api
{ "id": 17140, "url": "https://patchwork.libcamera.org/api/patches/17140/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17140/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220816183826.102989-3-Rauch.Christian@gmx.de>", "date": "2022-08-16T18:38:26", "name": "[libcamera-devel,v2,3/3] libcamera: pipeline: remove unused assignment", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e4a5ca76fade37d87ab95707ad4f75aaf78f7dfe", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17140/mbox/", "series": [ { "id": 3420, "url": "https://patchwork.libcamera.org/api/series/3420/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3420", "date": "2022-08-16T18:38:25", "name": "[libcamera-devel,v2,1/3] libcamera: remove unused headers", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3420/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17140/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17140/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB9E2BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 16 Aug 2022 18:38:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2BFCB61FC3;\n\tTue, 16 Aug 2022 20:38:35 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.17.21])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 085D861FC0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Aug 2022 20:38:32 +0200 (CEST)", "from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx104\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id 1MwfWU-1nPtnT3Tpa-00yBGU;\n\tTue, 16 Aug 2022 20:38:29 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660675115;\n\tbh=z98DY/0QKSCUgFXO+yHBw1c1rzBHI6R5i/T01he88wQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=dYOaREB2JdJwfMUN4PBKZy5LYk9eJkvGG4umR4jRwkwooPrmywUuF/TC57CWSodfP\n\tUnP78C90eb6EZVDI1czmHmrmzIyTUkGluDAQY0RRmiqEsdQr6B4x6cyngazyE1I6FY\n\tkDbH1nCvfGLGP2HE4DNv6xrJgX+kbbovSG3lc5ipx4neX2KE5AstrIYl8ou8Y9rcZ9\n\tqnWHfBmB7tvHoLQZb7UvpbrOqtIOwrVazfr7GqGcbqm7sttVvlGENI+KGwvEPnAiW1\n\tqFfPTQdG/M6B+AiEyLoCxvi1ZDKRCZ1MAws2mQCfIlI4KZEfKiJyHPE9gaCQwF+1we\n\tS176GY4lsQbHw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1660675110;\n\tbh=z98DY/0QKSCUgFXO+yHBw1c1rzBHI6R5i/T01he88wQ=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=TmsfS/cNbt/gz8L/UgPSz+bYN8RUQRCkBfHgAK6S3p0ht292GB5UhOPwfvrx2XuKU\n\tN4f2M611n4sPYtY2nGZcu6w4/OCJ0hDL571TJbQb5bzg6m8vYJWSF/00yb/xS4WgIm\n\td1vS3mlOdpS0Oc5aPG1ZNP010BsNGzABnzPdDhtY=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"TmsfS/cN\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 16 Aug 2022 20:38:26 +0200", "Message-Id": "<20220816183826.102989-3-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220816183826.102989-1-Rauch.Christian@gmx.de>", "References": "<20220816183826.102989-1-Rauch.Christian@gmx.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:cuctcFPU81/qwZwFY9DqBRKI1h4BE83J424cEMylq7lCxLeDpYZ\n\tE1GQNkDsHshNVLmqBu04tkQKrDwbfFa4hdJqrF5OJV7TKSLLPbAnIVc2Xav5/B87nFx22Ko\n\tak88aQcgEZci/4Py/HuoG9y9zpLNSItyifTHPfZJnSzuFkmca2X6JnojdNz4nVyljVE71cS\n\tVeJWPXZMsKufXKuplH6KA==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:LxqZKtQb+3c=:SBR4r/EoukZt2J3CHe3jxm\n\t7u6pXMsAp0A/4cDEs8CsdQWVERfICcKX6RrBy3IErzLD5Dq8Z7WEXhGaBjp5dV0W/e4l2lHhr\n\tCUwy7mc3ldnthCZ+GiW1mG2OzamxjJvr/mtALmUKYCwE89XiIymDpypyV0Zl2fEfFOcnHR5qH\n\tiuVwWhRunGiE6xK68vi4zdGrebzD0w+4ySFZ7+5t6PiF0U5Fm91WEqvtACi5svOKk7UXQmY6R\n\tuP1gIN6P5BNT93+NhUakBLpO7VLS7HPBZxpM7HvsVigfP6GBMomszyO6lQuqFr/F/W3yY3QmO\n\t9STT/lz0tQpywn0twHpPxb8b9sfOiKOQLSlesFCklwpnWjjAIPieS+DWIirSGFFNpSh1xUM1O\n\tSmTswai5BetmYXF375bv2AuAcdd12B58bZSg7/boRLakXo70CxaT16l5XVesK40STnsoiABi1\n\tZRIeHxSzKGHeaI3KxMWy+S0Gg2oiNFbE8FO+TGqnarRkAUAfSamBv/vRJRJ/R9CWzup4N83Zm\n\txhXlXStow1sZNvJ6G+lalp+tC2PxtlyD4CX7lFYiski/wG47u4hbqTCHZznX/A+nHb40/vdOp\n\t2tkBBsNj0P/EdzBNugUO5HhQ4GuaW2ecTK71/UHwZ2vjXYsQUazirRSM7hMOS+lo4Cif5SU4f\n\tVGonA8m+4CrzdoMjHaldWvgkwNKsDx9mUHTgqcwWj8eH4eniMswd6f44tDd7QXvJkTZFVSOTC\n\tVeV4ygXawtyiJsDLcxcUOmqhif5blL2HsNyXwWJwVT8+8TktvmVXcM/YqKa2UNKjB+n8vgfY3\n\twHYYVGhC0mdpw153on3Dmp29UugRCOBwK6WvMqUSDrm8j6gkYg/xAoNcZ36WcDa5GJUQV51Q1\n\t8dVZLOV6KonxxT9eYWpJ/wZ1QCwK1YT2xbpaG7bRJYAMj870WOIz3uI1L8rDusEX6tj7I4lC5\n\tgygL6SA7W5Kk8uDPDvrAYrHKqc7oMFF998K0d7XLb+JtNowsdxAmK/tgrlgKL2/cs6Xzz6R+C\n\tHGKEJ9W8645Vwe+rbtt+sCsqVV+67QY5v4b29kMBbb6E5ciK2tyPqqgoL6dhh9FWSRQTDBW1I\n\tYs6RPcecpkvZ1+p6uXJqg9ikzhLlxiRsgIMGT55lUEeLU88km+TrEw7uw==", "Subject": "[libcamera-devel] [PATCH v2 3/3] libcamera: pipeline: remove unused\n\tassignment", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The variable 'ret' is assigned but not read until after the next assignment.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -\n 1 file changed, 1 deletion(-)\n\n--\n2.34.1", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 93287332..03bbe6b4 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -688,7 +688,6 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \t\t/* \\todo Turn this into a hard failure. */\n \t\tLOG(RkISP1, Warning) << \"Camera sensor information not available\";\n \t\tsensorInfo = {};\n-\t\tret = 0;\n \t}\n\n \tstd::map<uint32_t, ControlInfoMap> entityControls;\n", "prefixes": [ "libcamera-devel", "v2", "3/3" ] }