Patch Detail
Show a patch.
GET /api/1.1/patches/27054/?format=api
{ "id": 27054, "url": "https://patchwork.libcamera.org/api/1.1/patches/27054/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27054/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260626113325.3218045-8-bryan.odonoghue@linaro.org>", "date": "2026-06-26T11:33:24", "name": "[v3,7/8] libcamera: egl: Drop dmabuf_import_failed_", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fa42f3676fb8f135635970e0165f76b8a7cdf0e4", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27054/mbox/", "series": [ { "id": 6020, "url": "https://patchwork.libcamera.org/api/1.1/series/6020/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6020", "date": "2026-06-26T11:33:17", "name": "libcamera: software_isp: gpu: Add go faster stripes", "version": 3, "mbox": "https://patchwork.libcamera.org/series/6020/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27054/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27054/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8F9EDC3306\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 26 Jun 2026 11:33:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 13BA865EEA;\n\tFri, 26 Jun 2026 13:33:51 +0200 (CEST)", "from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE6F1658F7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Jun 2026 13:33:45 +0200 (CEST)", "by mail-wm1-x330.google.com with SMTP id\n\t5b1f17b1804b1-4926ee9e8d9so1532145e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Jun 2026 04:33:45 -0700 (PDT)", "from inspiron14p-linux ([109.76.78.98])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-49268fe31b0sm79265985e9.4.2026.06.26.04.33.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 26 Jun 2026 04:33:44 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"qLfj5qOW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1782473625; x=1783078425;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=wUTK8M+uWf50J9eOZKpDSPxAGvL5i5epNISJptGTKUQ=;\n\tb=qLfj5qOWwCAG7E4i1EnH5jTB6kYLXX7k0u9xUr64P1cOQ12f1IiPIuK50jIKkp4BYo\n\ttfyzGzsgSZ/pwkWE9qUdaxhOY4trkYVWRmlOKueOAGMTbMDlCN2pwedgP3RPKgzT1ppF\n\t4ghAt/Ra9pEWRrCHYpwIM8V2MwaXcjMp+EIp9tarQYoIFtGgfSfww6SgJaKrPUUtZjGl\n\tAKRa+cBmm1hrZWUy9JEcuAx6cYa9V96xin61LVitoPSkbuBIbnPldrB6pWWX+AvI18yH\n\tCQIyA15Jd864DHoOrsURbsZt1As9e8NSTZvfynZUVvFBkuKRBE+hQISsm1iAAdqbx6EW\n\trhmg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1782473625; x=1783078425;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=wUTK8M+uWf50J9eOZKpDSPxAGvL5i5epNISJptGTKUQ=;\n\tb=SaYuJJzlFtcaUUG+0sAGU139zidukoOcmVJ82dZKBdATwPwoUnvwwPhU7yUq5iLCdY\n\t8z6oYS/wNhG03jUmvUfSjjOtMwtm6JrvKNvw2OVcTfFAqf7lRB+FaJt3gKqliJDy9Mk1\n\tTn8z0gbzRIKpqUsOGC7m8WUyqgVjLa7uLeW3wMV7HjYte4BKWPc65ZDlSX2AaAU3TCOp\n\tctzN0Ydjob7LYSU0CYw6iglKxiUeIT+tuhJfCyW6E/Oj3tohYbGiDQyl+4hCa0l9PbQA\n\tsHl49F5QKPdNJHc3YOuLrzzYhrvQD51QJLsVnKDVytVlv49wnISAepQPnojrt9HMXHAF\n\tL5ZA==", "X-Gm-Message-State": "AOJu0YwqRiNcgIcfD/zEidJhpTqvC1FHB+Mn/5DNu4fdMKBPvr/p1qnJ\n\tyZUxEM+mbcbp//qUUh+cM/yA7iu9QXQcIhYA8Uo7T10IQWlgphTuW83joKVrcTcxCvlg98nmq/R\n\tfdQtxaaE=", "X-Gm-Gg": "AfdE7ck2HLufNJQyX3zldFBzsVVcRQeXUNAtc1hkVIr6YkR7bdsPhcdJkFyVfcR0IXe\n\tPlKF7NviMq3Y+tZX/hRYveh2BMd8S8ag10GPdBJCbDQG+ColgOXCn/R9fUOaKgi3NR4Aa48awv7\n\tOuRnvgdDHZ3RJms5YxR4swvXRm89/axprGH9+DJSUhmdJ8M9f2UNhLoDDNmDU5DqUBgDyr0ZSoS\n\tuGnRTEzYpzeiaYe8oVKxTv/Nxt7idWLPPb4U9KMGDnsHkWdJH4Vu45a31KkTPqscSBDPTWo3hhi\n\txPj359tk96Xcqi9XRGWHuMa5WLP2fQ5cRBaZKv89NGdNsB0L7vq/qUqC6RIxLae+xGGOhVosm9l\n\tZvu0IIkFQ7nKQh3Q/mjJzJFAPY6/luTCfEFTuYdzJH/gx+Fd4rxq24TnDR7A1/xQ5e5FAGc6A2j\n\tIt13CVMpPQM8XjcPHxdgaZzc60AA==", "X-Received": "by 2002:a05:600c:1551:b0:490:3cf0:8d81 with SMTP id\n\t5b1f17b1804b1-492664241a4mr82720495e9.13.1782473625269; \n\tFri, 26 Jun 2026 04:33:45 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "bryan.odonoghue@linaro.org,\n\tpavel@ucw.cz", "Subject": "[PATCH v3 7/8] libcamera: egl: Drop dmabuf_import_failed_", "Date": "Fri, 26 Jun 2026 12:33:24 +0100", "Message-ID": "<20260626113325.3218045-8-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260626113325.3218045-1-bryan.odonoghue@linaro.org>", "References": "<20260626113325.3218045-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Drop per eGLImage flag dmabuf_import_failed_. We use a per-session import\nflag use_dmabuf_ so there's no need to mark failure per image anymore.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/egl.h | 1 -\n src/libcamera/egl.cpp | 1 -\n 2 files changed, 2 deletions(-)", "diff": "diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex e4d366abd..d2c4d1a7b 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -90,7 +90,6 @@ public:\n \tGLenum texture_unit_; /**< Texture unit associated with this image eg (GL_TEXTURE0) */\n \tGLuint texture_; /**< OpenGL texture object ID */\n \tGLuint fbo_; /**< OpenGL frame buffer object ID */\n-\tbool dmabuf_import_failed_ = false; /**< Previous image import failed */\n \n private:\n \tLIBCAMERA_DISABLE_COPY_AND_MOVE(eGLImage)\ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 4eabddcc7..ce451d521 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -210,7 +210,6 @@ int eGL::createDMABufTexture2D(eGLImage &eglImage, int fd, bool output)\n \n \tif (image == EGL_NO_IMAGE_KHR) {\n \t\tLOG(eGL, Debug) << \"eglCreateImageKHR fail\";\n-\t\teglImage.dmabuf_import_failed_ = true;\n \t\treturn -ENODEV;\n \t}\n \n", "prefixes": [ "v3", "7/8" ] }