[{"id":39455,"web_url":"https://patchwork.libcamera.org/comment/39455/","msgid":"<01ba5465-35e7-4beb-8cd4-357268108006@collabora.com>","date":"2026-06-26T12:04:05","subject":"Re: [PATCH v3 7/8] libcamera: egl: Drop dmabuf_import_failed_","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"Would prefer this commit to get squashed into the one where we stop \nusing these values. Still:\n\nReviewed-by: Robert Mader \n\nOn 26.06.26 13:33, Bryan O'Donoghue wrote:\n> Drop per eGLImage flag dmabuf_import_failed_. We use a per-session import\n> flag use_dmabuf_ so there's no need to mark failure per image anymore.\n>\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> include/libcamera/internal/egl.h | 1 -\n> src/libcamera/egl.cpp | 1 -\n> 2 files changed, 2 deletions(-)\n>\n> diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\n> index e4d366abd..d2c4d1a7b 100644\n> --- a/include/libcamera/internal/egl.h\n> +++ b/include/libcamera/internal/egl.h\n> @@ -90,7 +90,6 @@ public:\n> \tGLenum texture_unit_; /**< Texture unit associated with this image eg (GL_TEXTURE0) */\n> \tGLuint texture_; /**< OpenGL texture object ID */\n> \tGLuint fbo_; /**< OpenGL frame buffer object ID */\n> -\tbool dmabuf_import_failed_ = false; /**< Previous image import failed */\n> \n> private:\n> \tLIBCAMERA_DISABLE_COPY_AND_MOVE(eGLImage)\n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index 4eabddcc7..ce451d521 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -210,7 +210,6 @@ int eGL::createDMABufTexture2D(eGLImage &eglImage, int fd, bool output)\n> \n> \tif (image == EGL_NO_IMAGE_KHR) {\n> \t\tLOG(eGL, Debug) << \"eglCreateImageKHR fail\";\n> -\t\teglImage.dmabuf_import_failed_ = true;\n> \t\treturn -ENODEV;\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6DCDEBF415\n\tfor ;\n\tFri, 26 Jun 2026 12:04:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0CD6365ED5;\n\tFri, 26 Jun 2026 14:04:13 +0200 (CEST)","from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com\n\t[136.143.188.12])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E72C0658FA\n\tfor ;\n\tFri, 26 Jun 2026 14:04:10 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1782475446907136.72163551274605; \n\tFri, 26 Jun 2026 05:04:06 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"cRMsyQta\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1782475448; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=kVqgBtIOsNyG1hCDSw2Zc8TYPXcnZXXgVMEdiETAQuQ/wW8iM1CTOohVKX76e99QH9dsqIlsZ8Je0LRgMhgARwJpcTB5dTgrVzr877Ve/LCgcswT9qc+ffNt2c4PjCmfzMdEMFWtHS06rHYIQ/cWgCy8vZ616QuO/epGGNhQsW0=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1782475448;\n\th=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=5TshL4FbKyUi0omEffuWmq04zZ2rjp73GMDZ8Jvgrg8=; \n\tb=LZEVjJ8TjwysuTEwlboCx870fKkMTMeCQytmrYb4z0uuHClsnuuUHlKgZG1ocgxyyravCaT6CJ+JNPKfPLGe+Dj8YbK0D1alMSeeSfLNJlsEGN+7++gvSEDxqv4fLSoPwQ7WwEFBMcc1/Q7UFRsumzU+MdwXvQWWtdXZ7OWaN50=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1782475448;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc;\n\tbh=5TshL4FbKyUi0omEffuWmq04zZ2rjp73GMDZ8Jvgrg8=;\n\tb=cRMsyQtaOKqvmI+tpY262DLuetTX1psjakLrrbwZIvH7YhJZjqgw/Zb6A2LGgDSs\n\tXKI9DzkLCf6Xwls19LZwkiI7ur4PXhcKFcRO4maJmA7wqBW7A2TMxL9lk/zMimzR9Fn\n\tijREeTteKWPt4RSeOVmOObS12HZgVgMDh+MDw56U=","Message-ID":"<01ba5465-35e7-4beb-8cd4-357268108006@collabora.com>","Date":"Fri, 26 Jun 2026 14:04:05 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 7/8] libcamera: egl: Drop dmabuf_import_failed_","To":"libcamera-devel@lists.libcamera.org","References":"<20260626113325.3218045-1-bryan.odonoghue@linaro.org>\n\t<20260626113325.3218045-8-bryan.odonoghue@linaro.org>","Content-Language":"en-US, de-DE, en-GB","From":"Robert Mader ","In-Reply-To":"<20260626113325.3218045-8-bryan.odonoghue@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":39468,"web_url":"https://patchwork.libcamera.org/comment/39468/","msgid":"<85fr29jx22.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-06-26T12:39:01","subject":"Re: [PATCH v3 7/8] libcamera: egl: Drop dmabuf_import_failed_","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Robert Mader writes:\n\n> Would prefer this commit to get squashed into the one where we stop\n> using these values.\n\n+1\n\n> Still:\n>\n> Reviewed-by: Robert Mader \n>\n> On 26.06.26 13:33, Bryan O'Donoghue wrote:\n>> Drop per eGLImage flag dmabuf_import_failed_. We use a per-session import\n>> flag use_dmabuf_ so there's no need to mark failure per image anymore.\n>>\n>> Signed-off-by: Bryan O'Donoghue \n>> ---\n>> include/libcamera/internal/egl.h | 1 -\n>> src/libcamera/egl.cpp | 1 -\n>> 2 files changed, 2 deletions(-)\n>>\n>> diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\n>> index e4d366abd..d2c4d1a7b 100644\n>> --- a/include/libcamera/internal/egl.h\n>> +++ b/include/libcamera/internal/egl.h\n>> @@ -90,7 +90,6 @@ public:\n>> \tGLenum texture_unit_; /**< Texture unit associated with this image eg (GL_TEXTURE0) */\n>> \tGLuint texture_; /**< OpenGL texture object ID */\n>> \tGLuint fbo_; /**< OpenGL frame buffer object ID */\n>> -\tbool dmabuf_import_failed_ = false; /**< Previous image import failed */\n>> private:\n>> \tLIBCAMERA_DISABLE_COPY_AND_MOVE(eGLImage)\n>> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n>> index 4eabddcc7..ce451d521 100644\n>> --- a/src/libcamera/egl.cpp\n>> +++ b/src/libcamera/egl.cpp\n>> @@ -210,7 +210,6 @@ int eGL::createDMABufTexture2D(eGLImage &eglImage, int fd, bool output)\n>> \tif (image == EGL_NO_IMAGE_KHR) {\n>> \t\tLOG(eGL, Debug) << \"eglCreateImageKHR fail\";\n>> -\t\teglImage.dmabuf_import_failed_ = true;\n>> \t\treturn -ENODEV;\n>> \t}\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F26A5C3264\n\tfor ;\n\tFri, 26 Jun 2026 12:39:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 941A165EE2;\n\tFri, 26 Jun 2026 14:39:08 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37B83658FA\n\tfor ;\n\tFri, 26 Jun 2026 14:39:07 +0200 (CEST)","from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n\t[209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-424-7d6yktQ-MMunU8WLGJIpNQ-1; Fri, 26 Jun 2026 08:39:04 -0400","by mail-wr1-f72.google.com with SMTP id\n\tffacd0b85a97d-469675e37e8so545053f8f.1\n\tfor ;\n\tFri, 26 Jun 2026 05:39:04 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-4.net.vodafone.cz. [77.48.47.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-46f4ffc11d9sm3756085f8f.37.2026.06.26.05.39.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 26 Jun 2026 05:39:02 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"YZu77axT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1782477546;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=jl/SwdLMLvCZ1zlCEWw2qeJjWcmf7fBR5KZHL11jnvY=;\n\tb=YZu77axT8f3hY7j4lseF8g1aLKN5LGhaBtoY8+w5dMQa7t7aAbjgtSRBf7jdSQD40d/6Q8\n\tn5CrP3apdShY+9FBBgaNatH4CvpCU2dQLMhYTDMekyqhoL4FtYFLv7dwwA1iSE6LJ4lg2D\n\tg1HOBbzs/9Yy86viXVotY1OobDEVnws=","X-MC-Unique":"7d6yktQ-MMunU8WLGJIpNQ-1","X-Mimecast-MFC-AGG-ID":"7d6yktQ-MMunU8WLGJIpNQ_1782477543","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1782477543; x=1783082343;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=jl/SwdLMLvCZ1zlCEWw2qeJjWcmf7fBR5KZHL11jnvY=;\n\tb=l3/gmuvPGFnEzGkuALjdm8Alr6kyPq7JUkuJ9yWo6wwSTWr1KhnGX6vDRAfUM4e6Zz\n\tXPBennE+oqKeUnFe6+aJsP6jPTJOl7ZnHf4VJCrypZKMSpT5gcbgCJ3rFed8oCZwit3Q\n\t1Jss2frMUgZg61oqs14Po9RlBlR7ITxlO9ce+Yxs0VQLqLtfo4NkXR+Pi0fzw39vTDwI\n\tzVF4B4O7jGPycegg/uk8/i3GIi+qxrVH7kXjSUZ1jQkdpA90MsvBn/7IxQ3FZwWKojO2\n\tv0RrZV0Lod2Y2gIH73w68PXyWfPB7wGbViSYa3r8VSz2LA2U9kmPf1WjJN/Te8j97W/o\n\t4q8Q==","X-Gm-Message-State":"AOJu0YymAFO1mwnGznAYj1nEQ6/rm5VXH2mbhkfo5jncb4WvBAEyIctC\n\tVHqrAWZNZnA59L4uNKwWZfkDvSgH4PRYtpi0hBvzIaAfotCyrFyTPY+DNvHF7fzevnfWFpHRmaw\n\t5eDlaxlBp9as3qTSldR3DWVm1IV4DCzTTqJnM2xxMbJeC981uIAgzzI8PYhH2rmsKKa0A98+7bs\n\tw=","X-Gm-Gg":"AfdE7cmGGr74FdQjKFqo9oH6jiP8MQtUpoOtvybcJv/ccXUTWjEMHnQBz6b0FTFIYI8\n\tKebEow3DOpMcadyijoE5BcoQBjfXsg1RnFK3/q7Tgq4xDo/hSHrJQOSeImMUDqXfm40uXlWbHxz\n\teK+HjnBm+fY2UGiojrugUP5L3VAqZ5qOTHUPpfGOKQH1ldQFTnizJRVZhhlxFG17dyoaqssU2RD\n\tGJwvdnw5PKoz14MBmxdp4/DvQNiOG1vfpJc56i0Yuhge389hgx4wFfiG6fD+Ejm2gFafGt4qn6w\n\tMmvLj2J7u0SlNI+gzZSKOeWYPiZ+eXb6iaMeVlYbBqDQ9qH/81oLOMCNbtzulvSW+bm+61bNO1A\n\tiL6sEpQ79wnVroiydI2bvoqaQQ8X7cLMGBnFLsCq06raXf/9LmRLozW2CNS8uB+ru","X-Received":["by 2002:a05:6000:470b:b0:46d:28a7:3ce7 with SMTP id\n\tffacd0b85a97d-46dbed35effmr10180776f8f.7.1782477543450; \n\tFri, 26 Jun 2026 05:39:03 -0700 (PDT)","by 2002:a05:6000:470b:b0:46d:28a7:3ce7 with SMTP id\n\tffacd0b85a97d-46dbed35effmr10180724f8f.7.1782477542893; \n\tFri, 26 Jun 2026 05:39:02 -0700 (PDT)"],"From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, Robert Mader\n\t","Subject":"Re: [PATCH v3 7/8] libcamera: egl: Drop dmabuf_import_failed_","In-Reply-To":"<01ba5465-35e7-4beb-8cd4-357268108006@collabora.com> (Robert\n\tMader's message of \"Fri, 26 Jun 2026 14:04:05 +0200\")","References":"<20260626113325.3218045-1-bryan.odonoghue@linaro.org>\n\t<20260626113325.3218045-8-bryan.odonoghue@linaro.org>\n\t<01ba5465-35e7-4beb-8cd4-357268108006@collabora.com>","Date":"Fri, 26 Jun 2026 14:39:01 +0200","Message-ID":"<85fr29jx22.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"PNG758PYOxRG8ZEoq54SMvgTZFh_iUDU0XbSDUkjSks_1782477543","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]