From patchwork Fri Jun 26 11:33:24 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 27054 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8F9EDC3306 for ; Fri, 26 Jun 2026 11:33:51 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 13BA865EEA; Fri, 26 Jun 2026 13:33:51 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="qLfj5qOW"; dkim-atps=neutral Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BE6F1658F7 for ; Fri, 26 Jun 2026 13:33:45 +0200 (CEST) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4926ee9e8d9so1532145e9.0 for ; Fri, 26 Jun 2026 04:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1782473625; x=1783078425; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wUTK8M+uWf50J9eOZKpDSPxAGvL5i5epNISJptGTKUQ=; b=qLfj5qOWwCAG7E4i1EnH5jTB6kYLXX7k0u9xUr64P1cOQ12f1IiPIuK50jIKkp4BYo tfyzGzsgSZ/pwkWE9qUdaxhOY4trkYVWRmlOKueOAGMTbMDlCN2pwedgP3RPKgzT1ppF 4ghAt/Ra9pEWRrCHYpwIM8V2MwaXcjMp+EIp9tarQYoIFtGgfSfww6SgJaKrPUUtZjGl AKRa+cBmm1hrZWUy9JEcuAx6cYa9V96xin61LVitoPSkbuBIbnPldrB6pWWX+AvI18yH CQIyA15Jd864DHoOrsURbsZt1As9e8NSTZvfynZUVvFBkuKRBE+hQISsm1iAAdqbx6EW rhmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782473625; x=1783078425; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wUTK8M+uWf50J9eOZKpDSPxAGvL5i5epNISJptGTKUQ=; b=SaYuJJzlFtcaUUG+0sAGU139zidukoOcmVJ82dZKBdATwPwoUnvwwPhU7yUq5iLCdY 8z6oYS/wNhG03jUmvUfSjjOtMwtm6JrvKNvw2OVcTfFAqf7lRB+FaJt3gKqliJDy9Mk1 Tn8z0gbzRIKpqUsOGC7m8WUyqgVjLa7uLeW3wMV7HjYte4BKWPc65ZDlSX2AaAU3TCOp ctzN0Ydjob7LYSU0CYw6iglKxiUeIT+tuhJfCyW6E/Oj3tohYbGiDQyl+4hCa0l9PbQA sHl49F5QKPdNJHc3YOuLrzzYhrvQD51QJLsVnKDVytVlv49wnISAepQPnojrt9HMXHAF L5ZA== X-Gm-Message-State: AOJu0YwqRiNcgIcfD/zEidJhpTqvC1FHB+Mn/5DNu4fdMKBPvr/p1qnJ yZUxEM+mbcbp//qUUh+cM/yA7iu9QXQcIhYA8Uo7T10IQWlgphTuW83joKVrcTcxCvlg98nmq/R fdQtxaaE= X-Gm-Gg: AfdE7ck2HLufNJQyX3zldFBzsVVcRQeXUNAtc1hkVIr6YkR7bdsPhcdJkFyVfcR0IXe PlKF7NviMq3Y+tZX/hRYveh2BMd8S8ag10GPdBJCbDQG+ColgOXCn/R9fUOaKgi3NR4Aa48awv7 OuRnvgdDHZ3RJms5YxR4swvXRm89/axprGH9+DJSUhmdJ8M9f2UNhLoDDNmDU5DqUBgDyr0ZSoS uGnRTEzYpzeiaYe8oVKxTv/Nxt7idWLPPb4U9KMGDnsHkWdJH4Vu45a31KkTPqscSBDPTWo3hhi xPj359tk96Xcqi9XRGWHuMa5WLP2fQ5cRBaZKv89NGdNsB0L7vq/qUqC6RIxLae+xGGOhVosm9l Zvu0IIkFQ7nKQh3Q/mjJzJFAPY6/luTCfEFTuYdzJH/gx+Fd4rxq24TnDR7A1/xQ5e5FAGc6A2j It13CVMpPQM8XjcPHxdgaZzc60AA== X-Received: by 2002:a05:600c:1551:b0:490:3cf0:8d81 with SMTP id 5b1f17b1804b1-492664241a4mr82720495e9.13.1782473625269; Fri, 26 Jun 2026 04:33:45 -0700 (PDT) Received: from inspiron14p-linux ([109.76.78.98]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49268fe31b0sm79265985e9.4.2026.06.26.04.33.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2026 04:33:44 -0700 (PDT) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: bryan.odonoghue@linaro.org, pavel@ucw.cz Subject: [PATCH v3 7/8] libcamera: egl: Drop dmabuf_import_failed_ Date: Fri, 26 Jun 2026 12:33:24 +0100 Message-ID: <20260626113325.3218045-8-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260626113325.3218045-1-bryan.odonoghue@linaro.org> References: <20260626113325.3218045-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Drop per eGLImage flag dmabuf_import_failed_. We use a per-session import flag use_dmabuf_ so there's no need to mark failure per image anymore. Signed-off-by: Bryan O'Donoghue Reviewed-by: Robert Mader --- include/libcamera/internal/egl.h | 1 - src/libcamera/egl.cpp | 1 - 2 files changed, 2 deletions(-) diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h index e4d366abd..d2c4d1a7b 100644 --- a/include/libcamera/internal/egl.h +++ b/include/libcamera/internal/egl.h @@ -90,7 +90,6 @@ public: GLenum texture_unit_; /**< Texture unit associated with this image eg (GL_TEXTURE0) */ GLuint texture_; /**< OpenGL texture object ID */ GLuint fbo_; /**< OpenGL frame buffer object ID */ - bool dmabuf_import_failed_ = false; /**< Previous image import failed */ private: LIBCAMERA_DISABLE_COPY_AND_MOVE(eGLImage) diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp index 4eabddcc7..ce451d521 100644 --- a/src/libcamera/egl.cpp +++ b/src/libcamera/egl.cpp @@ -210,7 +210,6 @@ int eGL::createDMABufTexture2D(eGLImage &eglImage, int fd, bool output) if (image == EGL_NO_IMAGE_KHR) { LOG(eGL, Debug) << "eglCreateImageKHR fail"; - eglImage.dmabuf_import_failed_ = true; return -ENODEV; }