Patch Detail
Show a patch.
GET /api/1.1/patches/18714/?format=api
{ "id": 18714, "url": "https://patchwork.libcamera.org/api/1.1/patches/18714/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18714/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230606-alphabetical-order-v2-1-50869c0f9215@skidata.com>", "date": "2023-06-06T14:27:11", "name": "[libcamera-devel,v2] libipa: camera_sensor_helper: restore alphabetical order", "commit_ref": "0a37c203da58b3c23c011d8233c16c6063e3cb86", "pull_url": null, "state": "accepted", "archived": false, "hash": "07760777185aa2444e57c1d54e9b3ea1665fed12", "submitter": { "id": 163, "url": "https://patchwork.libcamera.org/api/1.1/people/163/?format=api", "name": "Benjamin Bara", "email": "bbara93@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18714/mbox/", "series": [ { "id": 3911, "url": "https://patchwork.libcamera.org/api/1.1/series/3911/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3911", "date": "2023-06-06T14:27:11", "name": "[libcamera-devel,v2] libipa: camera_sensor_helper: restore alphabetical order", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3911/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18714/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18714/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D740CC3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 6 Jun 2023 14:27:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2EB6B62893;\n\tTue, 6 Jun 2023 16:27:25 +0200 (CEST)", "from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com\n\t[IPv6:2a00:1450:4864:20::12e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ECBC062722\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 6 Jun 2023 16:27:23 +0200 (CEST)", "by mail-lf1-x12e.google.com with SMTP id\n\t2adb3069b0e04-4f505aace48so7873009e87.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 06 Jun 2023 07:27:23 -0700 (PDT)", "from [127.0.1.1] ([91.230.2.244]) by smtp.gmail.com with ESMTPSA id\n\txo21-20020a170907bb9500b00965ffb8407asm5636987ejc.87.2023.06.06.07.27.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 06 Jun 2023 07:27:22 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686061645;\n\tbh=bI2czLnqB2k9L5jFH4z5MVQpoEexT95IpGNlh9VT2k0=;\n\th=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=b9mUgsqwFnu6nrUxkb5FpaRKvVt3deCLuKLHrQSw6SiUt3x0jJ0U3teN0CeIWVeKv\n\t6nORxlc9oB1/I2WoIjLEi6tdIeTapITdKdpuH7HKy1Vbq4c6GCrYP0o3zXzvMD+pdz\n\t9DPXexxg8MK3wtlB4FHIFaueDO/QNS04VgWdsV4EBujKHSBwu9EBZAtTGWdGIgHr8R\n\tB+8SHCElzt4ItgmPqGbyssfLiVQKdKSyVbLpDpzFMMc/uZEhNKjXOa3shdkojc7uE9\n\tuwUoIrM7q9vl0KJ7DoUO9fUzKyMY0LUbsygsXrtj0C4FZ6pJqAOCtMniTUv6IXF7Ny\n\tWvcCcqUzJg18Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20221208; t=1686061643; x=1688653643;\n\th=cc:to:message-id:content-transfer-encoding:mime-version:subject\n\t:date:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=/9ol6eKd/H7QeK2mRAxevuzJLsdIv4mD1JJZcXETLxE=;\n\tb=PFhuVuibfrYoPjt0Gw1kYNgaSb7IkSYJzmxoufakKGdEC2D1wlSANJQTSy1zsujA+v\n\tMb7pXcjPNTZ8/dceEkGpyvB/3ykqR0SB0k/xLvOqatOHrPBhhQBpkFNYiYQvwZ7QDu8a\n\tASzjsHf0MF1nLOQNdY2o45f6LnnCYiLSTvVodh+R5RV2hveWkZBkxnxr1+5VWbVqOo0G\n\tZb7TchyeO42knDlR8NXniokPBzOn4nUH1O8FFCE2yWaBIqCWBnYVjnz5dKVzafiEnEsp\n\tWrOf9Lpa5riNjWI+hjkq5Y79mttVtiA/DE0TYlbAOHBQ4OjbpZZ5yFGKts8xpKFGpont\n\tvvug==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"PFhuVuib\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1686061643; x=1688653643;\n\th=cc:to:message-id:content-transfer-encoding:mime-version:subject\n\t:date:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=/9ol6eKd/H7QeK2mRAxevuzJLsdIv4mD1JJZcXETLxE=;\n\tb=QSwc5x63lBWBnOWQTVLioe5WcjRZxhaKkSRQDeVjZWY+R8Lb2P26FPFGMPjvubslsJ\n\tb3pFuXhXPqnQ8+kGW/11lMh1kT/9klvhyR4+HG2uLmn/N2/AqUb2g8rqD91nPL/dqgxy\n\tKMs/Hjl4uLj5WxKxXftaNgA1kRmDNYwXVwxLbx6XdSv3k6AkxYaVKwiaLI+jZS/uuoFG\n\tIoZwnU33XI5XUDM6dWja/DJBRqSmOKSHfUFAqI3r5xtC2HV1VtuyLXAwYdu8CduV9iXv\n\tPhgZUqUipQ0VaEJLXqmTVxYU9Lg9GaG4VhkF5ibiA3iB2Ved4m9Kh5z5g4MbMPps0Jh5\n\tA8KQ==", "X-Gm-Message-State": "AC+VfDzsJaj+aNJIibDSsa9572F3Ju+qtqAjLDqYF0eeSjQNEZLQfGIL\n\tZNpkuH+a54cTg6AcOGs9pvgO4hvYocw=", "X-Google-Smtp-Source": "ACHHUZ5V82xoTEkEUP44mePz0ywBCS37w9Hq6NAy6RScI0WZN4tIHemRDPBNCxKADKzYaSFxuyfzmg==", "X-Received": "by 2002:ac2:4855:0:b0:4f6:ac5:1fd7 with SMTP id\n\t21-20020ac24855000000b004f60ac51fd7mr934075lfy.66.1686061642702; \n\tTue, 06 Jun 2023 07:27:22 -0700 (PDT)", "Date": "Tue, 06 Jun 2023 16:27:11 +0200", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20230606-alphabetical-order-v2-1-50869c0f9215@skidata.com>", "X-B4-Tracking": "v=1; b=H4sIAD5Cf2QC/32NQQ6CMBBFr2K6toa2kYgr72FYTMtgJwIlMw3RE\n\tO5u4QAu3/95easSZEJR99OqGBcSSlMBez6pEGF6oaausLKVdVVd1RqGOYLHTAEGnbhD1gjG+Rs\n\t2196gKqIHQe0ZphB3dQTJyPsxM/b0OWrPtnAkyYm/R3wx+/q3sxhttAtNMBYMOGcf8qYOMlxCG\n\tlW7bdsP4fMEeM8AAAA=", "To": "libcamera-devel@lists.libcamera.org", "X-Mailer": "b4 0.12.2", "Subject": "[libcamera-devel] [PATCH v2] libipa: camera_sensor_helper: restore\n\talphabetical order", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Benjamin Bara via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Benjamin Bara <bbara93@gmail.com>", "Cc": "Benjamin Bara <benjamin.bara@skidata.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Benjamin Bara <benjamin.bara@skidata.com>\n\nThe addition of the CameraSensorHelperImx327 class was not correctly\ninserted in alphabetical sort order.\n\nMove it to the correct location.\n\nFixes: 7d5b38e2ef41 (\"libipa: camera_sensor_helper: Add IMX327 helper\")\nReported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Benjamin Bara <benjamin.bara@skidata.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\nUnfortunately missed to keep the alphabetical order as mentioned by\nLaurent.\n---\nChanges in v2:\n- Add commit message\n- Link to v1: https://lists.libcamera.org/pipermail/libcamera-devel/2023-June/038129.html\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\n\n---\nbase-commit: a0271e72a86da5796891795565f43f20f7024a8d\nchange-id: 20230606-alphabetical-order-ea13b8e95f1e\n\nBest regards,", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 2eebd7ab..f0ecc383 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -428,11 +428,6 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx290\", CameraSensorHelperImx290)\n \n-class CameraSensorHelperImx327 : public CameraSensorHelperImx290\n-{\n-};\n-REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx327)\n-\n class CameraSensorHelperImx296 : public CameraSensorHelper\n {\n public:\n@@ -444,6 +439,11 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx296\", CameraSensorHelperImx296)\n \n+class CameraSensorHelperImx327 : public CameraSensorHelperImx290\n+{\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx327)\n+\n class CameraSensorHelperImx477 : public CameraSensorHelper\n {\n public:\n", "prefixes": [ "libcamera-devel", "v2" ] }