From patchwork Tue Jun 6 14:27:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Bara X-Patchwork-Id: 18714 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D740CC3200 for ; Tue, 6 Jun 2023 14:27:25 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2EB6B62893; Tue, 6 Jun 2023 16:27:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1686061645; bh=bI2czLnqB2k9L5jFH4z5MVQpoEexT95IpGNlh9VT2k0=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=b9mUgsqwFnu6nrUxkb5FpaRKvVt3deCLuKLHrQSw6SiUt3x0jJ0U3teN0CeIWVeKv 6nORxlc9oB1/I2WoIjLEi6tdIeTapITdKdpuH7HKy1Vbq4c6GCrYP0o3zXzvMD+pdz 9DPXexxg8MK3wtlB4FHIFaueDO/QNS04VgWdsV4EBujKHSBwu9EBZAtTGWdGIgHr8R B+8SHCElzt4ItgmPqGbyssfLiVQKdKSyVbLpDpzFMMc/uZEhNKjXOa3shdkojc7uE9 uwUoIrM7q9vl0KJ7DoUO9fUzKyMY0LUbsygsXrtj0C4FZ6pJqAOCtMniTUv6IXF7Ny WvcCcqUzJg18Q== Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id ECBC062722 for ; Tue, 6 Jun 2023 16:27:23 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="PFhuVuib"; dkim-atps=neutral Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4f505aace48so7873009e87.0 for ; Tue, 06 Jun 2023 07:27:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686061643; x=1688653643; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=/9ol6eKd/H7QeK2mRAxevuzJLsdIv4mD1JJZcXETLxE=; b=PFhuVuibfrYoPjt0Gw1kYNgaSb7IkSYJzmxoufakKGdEC2D1wlSANJQTSy1zsujA+v Mb7pXcjPNTZ8/dceEkGpyvB/3ykqR0SB0k/xLvOqatOHrPBhhQBpkFNYiYQvwZ7QDu8a ASzjsHf0MF1nLOQNdY2o45f6LnnCYiLSTvVodh+R5RV2hveWkZBkxnxr1+5VWbVqOo0G Zb7TchyeO42knDlR8NXniokPBzOn4nUH1O8FFCE2yWaBIqCWBnYVjnz5dKVzafiEnEsp WrOf9Lpa5riNjWI+hjkq5Y79mttVtiA/DE0TYlbAOHBQ4OjbpZZ5yFGKts8xpKFGpont vvug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686061643; x=1688653643; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/9ol6eKd/H7QeK2mRAxevuzJLsdIv4mD1JJZcXETLxE=; b=QSwc5x63lBWBnOWQTVLioe5WcjRZxhaKkSRQDeVjZWY+R8Lb2P26FPFGMPjvubslsJ b3pFuXhXPqnQ8+kGW/11lMh1kT/9klvhyR4+HG2uLmn/N2/AqUb2g8rqD91nPL/dqgxy KMs/Hjl4uLj5WxKxXftaNgA1kRmDNYwXVwxLbx6XdSv3k6AkxYaVKwiaLI+jZS/uuoFG IoZwnU33XI5XUDM6dWja/DJBRqSmOKSHfUFAqI3r5xtC2HV1VtuyLXAwYdu8CduV9iXv PhgZUqUipQ0VaEJLXqmTVxYU9Lg9GaG4VhkF5ibiA3iB2Ved4m9Kh5z5g4MbMPps0Jh5 A8KQ== X-Gm-Message-State: AC+VfDzsJaj+aNJIibDSsa9572F3Ju+qtqAjLDqYF0eeSjQNEZLQfGIL ZNpkuH+a54cTg6AcOGs9pvgO4hvYocw= X-Google-Smtp-Source: ACHHUZ5V82xoTEkEUP44mePz0ywBCS37w9Hq6NAy6RScI0WZN4tIHemRDPBNCxKADKzYaSFxuyfzmg== X-Received: by 2002:ac2:4855:0:b0:4f6:ac5:1fd7 with SMTP id 21-20020ac24855000000b004f60ac51fd7mr934075lfy.66.1686061642702; Tue, 06 Jun 2023 07:27:22 -0700 (PDT) Received: from [127.0.1.1] ([91.230.2.244]) by smtp.gmail.com with ESMTPSA id xo21-20020a170907bb9500b00965ffb8407asm5636987ejc.87.2023.06.06.07.27.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 07:27:22 -0700 (PDT) Date: Tue, 06 Jun 2023 16:27:11 +0200 MIME-Version: 1.0 Message-Id: <20230606-alphabetical-order-v2-1-50869c0f9215@skidata.com> X-B4-Tracking: v=1; b=H4sIAD5Cf2QC/32NQQ6CMBBFr2K6toa2kYgr72FYTMtgJwIlMw3RE O5u4QAu3/95easSZEJR99OqGBcSSlMBez6pEGF6oaausLKVdVVd1RqGOYLHTAEGnbhD1gjG+Rs 2196gKqIHQe0ZphB3dQTJyPsxM/b0OWrPtnAkyYm/R3wx+/q3sxhttAtNMBYMOGcf8qYOMlxCG lW7bdsP4fMEeM8AAAA= To: libcamera-devel@lists.libcamera.org X-Mailer: b4 0.12.2 Subject: [libcamera-devel] [PATCH v2] libipa: camera_sensor_helper: restore alphabetical order X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Benjamin Bara via libcamera-devel From: Benjamin Bara Reply-To: Benjamin Bara Cc: Benjamin Bara Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Benjamin Bara The addition of the CameraSensorHelperImx327 class was not correctly inserted in alphabetical sort order. Move it to the correct location. Fixes: 7d5b38e2ef41 ("libipa: camera_sensor_helper: Add IMX327 helper") Reported-by: Laurent Pinchart Signed-off-by: Benjamin Bara Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- Unfortunately missed to keep the alphabetical order as mentioned by Laurent. --- Changes in v2: - Add commit message - Link to v1: https://lists.libcamera.org/pipermail/libcamera-devel/2023-June/038129.html --- src/ipa/libipa/camera_sensor_helper.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- base-commit: a0271e72a86da5796891795565f43f20f7024a8d change-id: 20230606-alphabetical-order-ea13b8e95f1e Best regards, diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index 2eebd7ab..f0ecc383 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -428,11 +428,6 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER("imx290", CameraSensorHelperImx290) -class CameraSensorHelperImx327 : public CameraSensorHelperImx290 -{ -}; -REGISTER_CAMERA_SENSOR_HELPER("imx327", CameraSensorHelperImx327) - class CameraSensorHelperImx296 : public CameraSensorHelper { public: @@ -444,6 +439,11 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER("imx296", CameraSensorHelperImx296) +class CameraSensorHelperImx327 : public CameraSensorHelperImx290 +{ +}; +REGISTER_CAMERA_SENSOR_HELPER("imx327", CameraSensorHelperImx327) + class CameraSensorHelperImx477 : public CameraSensorHelper { public: