Patch Detail
Show a patch.
GET /api/1.1/patches/18257/?format=api
{ "id": 18257, "url": "https://patchwork.libcamera.org/api/1.1/patches/18257/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18257/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230206170356.20340-4-laurent.pinchart@ideasonboard.com>", "date": "2023-02-06T17:03:55", "name": "[libcamera-devel,v1,3/4] pipeline: ipu3: Drop unused code", "commit_ref": "9cc5cbadc2244560ea5325491acdb90e2bbbc196", "pull_url": null, "state": "accepted", "archived": false, "hash": "b25c58dda6b1412cfc833675c7ac7a2ff8cd9fba", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18257/mbox/", "series": [ { "id": 3740, "url": "https://patchwork.libcamera.org/api/1.1/series/3740/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3740", "date": "2023-02-06T17:03:52", "name": "Misc fixes for transformation handling", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3740/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18257/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18257/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41ACDC329C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 Feb 2023 17:04:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0079B625FD;\n\tMon, 6 Feb 2023 18:04:03 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6960E625FF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Feb 2023 18:04:02 +0100 (CET)", "from pendragon.ideasonboard.com (unknown [109.136.43.56])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D1AEF4DA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Feb 2023 18:04:01 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675703044;\n\tbh=RiAibVoMVJWWjNmCK3UmaB/yHa779zjqdmV1+13l7TM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=dvq0goepW2cTw4Cn+OrZ9NsBouqRLcLv67nZlwcBayYLeLcIpN8HupJge30CtjA3w\n\tsTZKjKiVZ5KqYrOZJRhn0Ow4Pa0xz1pORKBruQBbymdbWx/HuxRW3SBgUyvkGotR8I\n\taEuK0QJktvaaIKBpLima5MXGP08NpNbny4ugtHTTRhg6o8LErwAtYP6NEWQ/UEfumc\n\tz9tM6z/ePS883OosvO+UpPXqgTqi7A3rDspNJ7npEliQfWTvblOTKry6/qcW0H1ijt\n\tU67COZP/aGWdF1bY5Ple7sDpAuaLbToNOnsniy66bTgX+iEPmnxhD51XBtpInZXXjU\n\tSQ+Eisu8RESMQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675703042;\n\tbh=RiAibVoMVJWWjNmCK3UmaB/yHa779zjqdmV1+13l7TM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Vr2wJo1UiDWLGO85NB6O0nqk142zZYBxz3gS9xIVgfY4yCDEklXwffvK2ddtGDiqR\n\tGuoX02DYuDnGpgclobnod4EfdWIydAlUIDhL+CB+bn5wwvyVZOr6ozRi2r2KrQFjFM\n\tGB4CySyMRICTvCcc53MFwgRH/ey2aKZzYNI/aoIk=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Vr2wJo1U\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 6 Feb 2023 19:03:55 +0200", "Message-Id": "<20230206170356.20340-4-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230206170356.20340-1-laurent.pinchart@ideasonboard.com>", "References": "<20230206170356.20340-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 3/4] pipeline: ipu3: Drop unused code", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Commit 1a614866a29c (\"libcamera: camera_sensor: Validate Transform\") has\nremoved usage of the IPU3CameraData::rotationTransform_ but hasn't\nremoved the field itself, nor its initialization. Drop those as they're\nunused.\n\nFixes: 1a614866a29c (\"libcamera: camera_sensor: Validate Transform\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 8 --------\n 1 file changed, 8 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 3a569c7e0031..355cb0cb76b8 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -73,7 +73,6 @@ public:\n \tStream rawStream_;\n \n \tRectangle cropRegion_;\n-\tTransform rotationTransform_;\n \n \tstd::unique_ptr<DelayedControls> delayedCtrls_;\n \tIPU3Frames frameInfos_;\n@@ -1101,13 +1100,6 @@ int PipelineHandlerIPU3::registerCameras()\n \t\t\t\t\t << cio2->sensor()->id()\n \t\t\t\t\t << \". Assume rotation 0\";\n \n-\t\tint32_t rotationValue = rotation.value_or(0);\n-\t\tbool success;\n-\t\tdata->rotationTransform_ = transformFromRotation(rotationValue, &success);\n-\t\tif (!success)\n-\t\t\tLOG(IPU3, Warning) << \"Invalid rotation of \" << rotationValue\n-\t\t\t\t\t << \" degrees: ignoring\";\n-\n \t\t/**\n \t\t * \\todo Dynamically assign ImgU and output devices to each\n \t\t * stream and camera; as of now, limit support to two cameras\n", "prefixes": [ "libcamera-devel", "v1", "3/4" ] }