Patch Detail
Show a patch.
GET /api/1.1/patches/16349/?format=api
{ "id": 16349, "url": "https://patchwork.libcamera.org/api/1.1/patches/16349/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16349/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220623232210.18742-4-laurent.pinchart@ideasonboard.com>", "date": "2022-06-23T23:22:00", "name": "[libcamera-devel,03/13] gstreamer: Move variable to loop scope", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ba9e0d73f2364d06ad16a81eaff00c29e0b2a6f9", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16349/mbox/", "series": [ { "id": 3214, "url": "https://patchwork.libcamera.org/api/1.1/series/3214/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3214", "date": "2022-06-23T23:21:57", "name": "gstreamer: Queue multiple requests", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3214/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16349/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16349/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAE1ABD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Jun 2022 23:22:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C81B365649;\n\tFri, 24 Jun 2022 01:22:35 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 34D7165635\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jun 2022 01:22:30 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B04C06BB;\n\tFri, 24 Jun 2022 01:22:29 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656026555;\n\tbh=eIaNFEK/fkZTwMsMBv7ZufdKJmcG2AnPe5i8AztK3+c=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=FEQPbYTCElQjUU4HPK29RZ3aQV4b70fFvuIqXwhE/2EHJ4u6Sw5nSyY4lf9ApZ+Hi\n\tVXbJMW2iIGIhFm6cw3gw1+HJI/ZGvtppob12PlMvrgEadPcM997OmlFlen2UTtXDgF\n\tqBvDed1ElHgD3cUBzrpk1o1+P7dxwlQRtKDdXpPI33ev5aCM+TWemcU7MIo8N6VW+3\n\tQlct4/QU8H+PDtvHTRcfWZesdEJ1+rjwYXtRrnrHgOSBdqUTi6hjK5tUSuER89RveC\n\twVXb1fesd2re//edTHEf+JUiNAS3LPhiL9dB2clARrs1Bwdagi03fg+jiJ24fQQtM3\n\tc1E2npkSPMJ5A==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656026550;\n\tbh=eIaNFEK/fkZTwMsMBv7ZufdKJmcG2AnPe5i8AztK3+c=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ox2zxV2ozfkE57kabegvvBkw52BQkCfCb6anM0O0AWRLrWxMr2fq6cDu6zNHe88p7\n\tbe3uGfCmXkNCgmfcnFvYfjjNgwSKfNgkjRAH+fRXrv/kpRH+CmuO94PDXFp2OlJvlw\n\th/mQPFQNAJozDY8k9peAteb/w5uf4pzP8qS7kwuM=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Ox2zxV2o\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 24 Jun 2022 02:22:00 +0300", "Message-Id": "<20220623232210.18742-4-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220623232210.18742-1-laurent.pinchart@ideasonboard.com>", "References": "<20220623232210.18742-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 03/13] gstreamer: Move variable to loop\n\tscope", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tVedant Paranjape <vedantparanjape160201@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The GstBuffer variable in GstLibcameraSrcState::requestCompleted() is\nonly used within the loop scope. Make it a local loop variable.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 9d6be075a474..dea143961d69 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -165,10 +165,9 @@ GstLibcameraSrcState::requestCompleted(Request *request)\n \t\treturn;\n \t}\n \n-\tGstBuffer *buffer;\n \tfor (GstPad *srcpad : srcpads_) {\n \t\tStream *stream = gst_libcamera_pad_get_stream(srcpad);\n-\t\tbuffer = wrap->detachBuffer(stream);\n+\t\tGstBuffer *buffer = wrap->detachBuffer(stream);\n \n \t\tFrameBuffer *fb = gst_libcamera_buffer_get_frame_buffer(buffer);\n \n", "prefixes": [ "libcamera-devel", "03/13" ] }