| Message ID | 20220623232210.18742-4-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, Le vendredi 24 juin 2022 à 02:22 +0300, Laurent Pinchart a écrit : > The GstBuffer variable in GstLibcameraSrcState::requestCompleted() is > only used within the loop scope. Make it a local loop variable. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Thanks for the cleanup. Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> > --- > src/gstreamer/gstlibcamerasrc.cpp | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp > index 9d6be075a474..dea143961d69 100644 > --- a/src/gstreamer/gstlibcamerasrc.cpp > +++ b/src/gstreamer/gstlibcamerasrc.cpp > @@ -165,10 +165,9 @@ GstLibcameraSrcState::requestCompleted(Request *request) > return; > } > > - GstBuffer *buffer; > for (GstPad *srcpad : srcpads_) { > Stream *stream = gst_libcamera_pad_get_stream(srcpad); > - buffer = wrap->detachBuffer(stream); > + GstBuffer *buffer = wrap->detachBuffer(stream); > > FrameBuffer *fb = gst_libcamera_buffer_get_frame_buffer(buffer); >
Hi Laurent, Thank you for the patch. On 6/24/22 04:52, Laurent Pinchart via libcamera-devel wrote: > The GstBuffer variable in GstLibcameraSrcState::requestCompleted() is > only used within the loop scope. Make it a local loop variable. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> > --- > src/gstreamer/gstlibcamerasrc.cpp | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp > index 9d6be075a474..dea143961d69 100644 > --- a/src/gstreamer/gstlibcamerasrc.cpp > +++ b/src/gstreamer/gstlibcamerasrc.cpp > @@ -165,10 +165,9 @@ GstLibcameraSrcState::requestCompleted(Request *request) > return; > } > > - GstBuffer *buffer; > for (GstPad *srcpad : srcpads_) { > Stream *stream = gst_libcamera_pad_get_stream(srcpad); > - buffer = wrap->detachBuffer(stream); > + GstBuffer *buffer = wrap->detachBuffer(stream); > > FrameBuffer *fb = gst_libcamera_buffer_get_frame_buffer(buffer); >
diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp index 9d6be075a474..dea143961d69 100644 --- a/src/gstreamer/gstlibcamerasrc.cpp +++ b/src/gstreamer/gstlibcamerasrc.cpp @@ -165,10 +165,9 @@ GstLibcameraSrcState::requestCompleted(Request *request) return; } - GstBuffer *buffer; for (GstPad *srcpad : srcpads_) { Stream *stream = gst_libcamera_pad_get_stream(srcpad); - buffer = wrap->detachBuffer(stream); + GstBuffer *buffer = wrap->detachBuffer(stream); FrameBuffer *fb = gst_libcamera_buffer_get_frame_buffer(buffer);
The GstBuffer variable in GstLibcameraSrcState::requestCompleted() is only used within the loop scope. Make it a local loop variable. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/gstreamer/gstlibcamerasrc.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)