From patchwork Thu Jun 23 23:22:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 16349 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CAE1ABD808 for ; Thu, 23 Jun 2022 23:22:37 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C81B365649; Fri, 24 Jun 2022 01:22:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1656026555; bh=eIaNFEK/fkZTwMsMBv7ZufdKJmcG2AnPe5i8AztK3+c=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=FEQPbYTCElQjUU4HPK29RZ3aQV4b70fFvuIqXwhE/2EHJ4u6Sw5nSyY4lf9ApZ+Hi VXbJMW2iIGIhFm6cw3gw1+HJI/ZGvtppob12PlMvrgEadPcM997OmlFlen2UTtXDgF qBvDed1ElHgD3cUBzrpk1o1+P7dxwlQRtKDdXpPI33ev5aCM+TWemcU7MIo8N6VW+3 Qlct4/QU8H+PDtvHTRcfWZesdEJ1+rjwYXtRrnrHgOSBdqUTi6hjK5tUSuER89RveC wVXb1fesd2re//edTHEf+JUiNAS3LPhiL9dB2clARrs1Bwdagi03fg+jiJ24fQQtM3 c1E2npkSPMJ5A== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 34D7165635 for ; Fri, 24 Jun 2022 01:22:30 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Ox2zxV2o"; dkim-atps=neutral Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B04C06BB; Fri, 24 Jun 2022 01:22:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1656026550; bh=eIaNFEK/fkZTwMsMBv7ZufdKJmcG2AnPe5i8AztK3+c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ox2zxV2ozfkE57kabegvvBkw52BQkCfCb6anM0O0AWRLrWxMr2fq6cDu6zNHe88p7 be3uGfCmXkNCgmfcnFvYfjjNgwSKfNgkjRAH+fRXrv/kpRH+CmuO94PDXFp2OlJvlw h/mQPFQNAJozDY8k9peAteb/w5uf4pzP8qS7kwuM= To: libcamera-devel@lists.libcamera.org Date: Fri, 24 Jun 2022 02:22:00 +0300 Message-Id: <20220623232210.18742-4-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220623232210.18742-1-laurent.pinchart@ideasonboard.com> References: <20220623232210.18742-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 03/13] gstreamer: Move variable to loop scope X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Cc: Nicolas Dufresne , Vedant Paranjape Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The GstBuffer variable in GstLibcameraSrcState::requestCompleted() is only used within the loop scope. Make it a local loop variable. Signed-off-by: Laurent Pinchart Reviewed-by: Nicolas Dufresne Reviewed-by: Umang Jain --- src/gstreamer/gstlibcamerasrc.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp index 9d6be075a474..dea143961d69 100644 --- a/src/gstreamer/gstlibcamerasrc.cpp +++ b/src/gstreamer/gstlibcamerasrc.cpp @@ -165,10 +165,9 @@ GstLibcameraSrcState::requestCompleted(Request *request) return; } - GstBuffer *buffer; for (GstPad *srcpad : srcpads_) { Stream *stream = gst_libcamera_pad_get_stream(srcpad); - buffer = wrap->detachBuffer(stream); + GstBuffer *buffer = wrap->detachBuffer(stream); FrameBuffer *fb = gst_libcamera_buffer_get_frame_buffer(buffer);