Patch Detail
Show a patch.
GET /api/1.1/patches/15229/?format=api
{ "id": 15229, "url": "https://patchwork.libcamera.org/api/1.1/patches/15229/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15229/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211228215951.32396-4-laurent.pinchart@ideasonboard.com>", "date": "2021-12-28T21:59:49", "name": "[libcamera-devel,v1,3/5] v4l2: v4l2_camera_proxy: Drop trace message from freeBuffers()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5a633b3c3da3413c10e7ea4fda3793a9717b4821", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": { "id": 14, "url": "https://patchwork.libcamera.org/api/1.1/users/14/?format=api", "username": "pinchartl", "first_name": "Laurent", "last_name": "Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/15229/mbox/", "series": [ { "id": 2870, "url": "https://patchwork.libcamera.org/api/1.1/series/2870/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2870", "date": "2021-12-28T21:59:46", "name": "libcamera: Improve debug messages in V4L2 compat layer", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2870/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15229/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15229/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B09EFBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Dec 2021 22:00:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5EC5D6091A;\n\tTue, 28 Dec 2021 23:00:03 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0DA4D608E9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Dec 2021 22:59:59 +0100 (CET)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 54EFE895\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Dec 2021 22:59:58 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rtKHSv1r\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640728798;\n\tbh=B7vytGfSodr0BIgBR1pAZBaXOj+6bL7ZFaLyGSMd3PI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=rtKHSv1rZmTA0hw1t0q1ai7u/61KGd6dnwuU2Ypz9xQ90NNlQFlToewh07eSTQSvO\n\tpwaWwRicQ2bvrtp6P60YRE600xYD/LTdHP0Pq90qpP/0oTIM84xKU6sQ1LWe38goBT\n\tduAYJx2vW/2VHek9hETO2fHn3FH2UZLy8Pp41oYY=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 28 Dec 2021 23:59:49 +0200", "Message-Id": "<20211228215951.32396-4-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.33.1", "In-Reply-To": "<20211228215951.32396-1-laurent.pinchart@ideasonboard.com>", "References": "<20211228215951.32396-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 3/5] v4l2: v4l2_camera_proxy: Drop\n\ttrace message from freeBuffers()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The freeBuffers() function is only called from vidioc_reqbufs(), which\nalready logs a trace message. Remove the duplicate.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/v4l2/v4l2_camera_proxy.cpp | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex c1375777c185..80e6624bc9b7 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -445,8 +445,6 @@ int V4L2CameraProxy::vidioc_s_input(V4L2CameraFile *file, int *arg)\n \n void V4L2CameraProxy::freeBuffers()\n {\n-\tLOG(V4L2Compat, Debug) << \"Freeing libcamera bufs\";\n-\n \tvcam_->freeBuffers();\n \tbuffers_.clear();\n \tbufferCount_ = 0;\n", "prefixes": [ "libcamera-devel", "v1", "3/5" ] }