[libcamera-devel,v1,3/5] v4l2: v4l2_camera_proxy: Drop trace message from freeBuffers()
diff mbox series

Message ID 20211228215951.32396-4-laurent.pinchart@ideasonboard.com
State Accepted
Delegated to: Laurent Pinchart
Headers show
Series
  • libcamera: Improve debug messages in V4L2 compat layer
Related show

Commit Message

Laurent Pinchart Dec. 28, 2021, 9:59 p.m. UTC 
The freeBuffers() function is only called from vidioc_reqbufs(), which
already logs a trace message. Remove the duplicate.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/v4l2/v4l2_camera_proxy.cpp | 2 --
 1 file changed, 2 deletions(-)

Comments

Kieran Bingham Jan. 10, 2022, 4:41 p.m. UTC | #1 
Quoting Laurent Pinchart (2021-12-28 21:59:49)
> The freeBuffers() function is only called from vidioc_reqbufs(), which
> already logs a trace message. Remove the duplicate.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/v4l2/v4l2_camera_proxy.cpp | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp
> index c1375777c185..80e6624bc9b7 100644
> --- a/src/v4l2/v4l2_camera_proxy.cpp
> +++ b/src/v4l2/v4l2_camera_proxy.cpp
> @@ -445,8 +445,6 @@ int V4L2CameraProxy::vidioc_s_input(V4L2CameraFile *file, int *arg)
>  
>  void V4L2CameraProxy::freeBuffers()
>  {
> -       LOG(V4L2Compat, Debug) << "Freeing libcamera bufs";
> -
>         vcam_->freeBuffers();
>         buffers_.clear();
>         bufferCount_ = 0;
> -- 
> Regards,
> 
> Laurent Pinchart
>
Paul Elder Jan. 14, 2022, 10:41 a.m. UTC | #2 
Hi Laurent,

On Tue, Dec 28, 2021 at 11:59:49PM +0200, Laurent Pinchart wrote:
> The freeBuffers() function is only called from vidioc_reqbufs(), which
> already logs a trace message. Remove the duplicate.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/v4l2/v4l2_camera_proxy.cpp | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp
> index c1375777c185..80e6624bc9b7 100644
> --- a/src/v4l2/v4l2_camera_proxy.cpp
> +++ b/src/v4l2/v4l2_camera_proxy.cpp
> @@ -445,8 +445,6 @@ int V4L2CameraProxy::vidioc_s_input(V4L2CameraFile *file, int *arg)
>  
>  void V4L2CameraProxy::freeBuffers()
>  {
> -	LOG(V4L2Compat, Debug) << "Freeing libcamera bufs";
> -
>  	vcam_->freeBuffers();
>  	buffers_.clear();
>  	bufferCount_ = 0;
> -- 
> Regards,
> 
> Laurent Pinchart
>

Patch
diff mbox series 

diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp
index c1375777c185..80e6624bc9b7 100644
--- a/src/v4l2/v4l2_camera_proxy.cpp
+++ b/src/v4l2/v4l2_camera_proxy.cpp
@@ -445,8 +445,6 @@  int V4L2CameraProxy::vidioc_s_input(V4L2CameraFile *file, int *arg)
 
 void V4L2CameraProxy::freeBuffers()
 {
-	LOG(V4L2Compat, Debug) << "Freeing libcamera bufs";
-
 	vcam_->freeBuffers();
 	buffers_.clear();
 	bufferCount_ = 0;