From patchwork Tue Dec 28 21:59:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 15229 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B09EFBF415 for ; Tue, 28 Dec 2021 22:00:03 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5EC5D6091A; Tue, 28 Dec 2021 23:00:03 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rtKHSv1r"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0DA4D608E9 for ; Tue, 28 Dec 2021 22:59:59 +0100 (CET) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 54EFE895 for ; Tue, 28 Dec 2021 22:59:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1640728798; bh=B7vytGfSodr0BIgBR1pAZBaXOj+6bL7ZFaLyGSMd3PI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=rtKHSv1rZmTA0hw1t0q1ai7u/61KGd6dnwuU2Ypz9xQ90NNlQFlToewh07eSTQSvO pwaWwRicQ2bvrtp6P60YRE600xYD/LTdHP0Pq90qpP/0oTIM84xKU6sQ1LWe38goBT duAYJx2vW/2VHek9hETO2fHn3FH2UZLy8Pp41oYY= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 28 Dec 2021 23:59:49 +0200 Message-Id: <20211228215951.32396-4-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211228215951.32396-1-laurent.pinchart@ideasonboard.com> References: <20211228215951.32396-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 3/5] v4l2: v4l2_camera_proxy: Drop trace message from freeBuffers() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The freeBuffers() function is only called from vidioc_reqbufs(), which already logs a trace message. Remove the duplicate. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Paul Elder --- src/v4l2/v4l2_camera_proxy.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp index c1375777c185..80e6624bc9b7 100644 --- a/src/v4l2/v4l2_camera_proxy.cpp +++ b/src/v4l2/v4l2_camera_proxy.cpp @@ -445,8 +445,6 @@ int V4L2CameraProxy::vidioc_s_input(V4L2CameraFile *file, int *arg) void V4L2CameraProxy::freeBuffers() { - LOG(V4L2Compat, Debug) << "Freeing libcamera bufs"; - vcam_->freeBuffers(); buffers_.clear(); bufferCount_ = 0;