[libcamera-devel,3/6] libcamera: pipeline: rkisp1: Add support for RGB656

Message ID 20200930200831.2066751-4-niklas.soderlund@ragnatech.se
State Accepted
Headers show
Series
  • libcamera: pipeline: rkisp1: Refresh to match upstream
Related show

Commit Message

Niklas Söderlund Sept. 30, 2020, 8:08 p.m. UTC
The self path support RGB565, list it as a supported format.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Paul Elder Oct. 1, 2020, 3:16 a.m. UTC | #1
On Wed, Sep 30, 2020 at 10:08:28PM +0200, Niklas Söderlund wrote:
> The self path support RGB565, list it as a supported format.

s/support/supports

> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
> index 63c643f22affc74a..277aa226fcd428be 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
> @@ -218,13 +218,14 @@ constexpr std::array<PixelFormat, 5> RKISP1_RSZ_MP_FORMATS{
>  
>  constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };
>  constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };
> -constexpr std::array<PixelFormat, 5> RKISP1_RSZ_SP_FORMATS{
> +constexpr std::array<PixelFormat, 6> RKISP1_RSZ_SP_FORMATS{
>  	formats::YUYV,
>  	formats::NV16,
>  	formats::NV61,
>  	formats::NV21,
>  	formats::NV12,
> -	/* \todo Add support for BGR888 and RGB565 */
> +	formats::RGB565,
> +	/* \todo Add support for BGR888 */
>  };
>  } /* namespace */
>  
> -- 
> 2.28.0
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
index 63c643f22affc74a..277aa226fcd428be 100644
--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
@@ -218,13 +218,14 @@  constexpr std::array<PixelFormat, 5> RKISP1_RSZ_MP_FORMATS{
 
 constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };
 constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };
-constexpr std::array<PixelFormat, 5> RKISP1_RSZ_SP_FORMATS{
+constexpr std::array<PixelFormat, 6> RKISP1_RSZ_SP_FORMATS{
 	formats::YUYV,
 	formats::NV16,
 	formats::NV61,
 	formats::NV21,
 	formats::NV12,
-	/* \todo Add support for BGR888 and RGB565 */
+	formats::RGB565,
+	/* \todo Add support for BGR888 */
 };
 } /* namespace */