[libcamera-devel,1/6] libcamera: pipeline: rkisp1: Remove support for YVYU and VYUY

Message ID 20200930200831.2066751-2-niklas.soderlund@ragnatech.se
State Accepted
Headers show
Series
  • libcamera: pipeline: rkisp1: Refresh to match upstream
Related show

Commit Message

Niklas Söderlund Sept. 30, 2020, 8:08 p.m. UTC
The upstream driver have dropped support for YVYU and VYUY [1], remove
support from the pipeline handler.

1. 3acb3e06baf64e28 ("media: staging: rkisp1: cap: remove unsupported formats")

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comments

Paul Elder Oct. 1, 2020, 3:15 a.m. UTC | #1
On Wed, Sep 30, 2020 at 10:08:26PM +0200, Niklas Söderlund wrote:
> The upstream driver have dropped support for YVYU and VYUY [1], remove

s/have/has

> support from the pipeline handler.
> 
> 1. 3acb3e06baf64e28 ("media: staging: rkisp1: cap: remove unsupported formats")
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
> index ee152c043224f205..410e9f5d94607f44 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
> @@ -195,10 +195,8 @@ void RkISP1Path::stop()
>  namespace {
>  constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 };
>  constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 };
> -constexpr std::array<PixelFormat, 7> RKISP1_RSZ_MP_FORMATS{
> +constexpr std::array<PixelFormat, 5> RKISP1_RSZ_MP_FORMATS{
>  	formats::YUYV,
> -	formats::YVYU,
> -	formats::VYUY,
>  	formats::NV16,
>  	formats::NV61,
>  	formats::NV21,
> @@ -208,10 +206,8 @@ constexpr std::array<PixelFormat, 7> RKISP1_RSZ_MP_FORMATS{
>  
>  constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };
>  constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };
> -constexpr std::array<PixelFormat, 7> RKISP1_RSZ_SP_FORMATS{
> +constexpr std::array<PixelFormat, 5> RKISP1_RSZ_SP_FORMATS{
>  	formats::YUYV,
> -	formats::YVYU,
> -	formats::VYUY,
>  	formats::NV16,
>  	formats::NV61,
>  	formats::NV21,
> -- 
> 2.28.0
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
index ee152c043224f205..410e9f5d94607f44 100644
--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
@@ -195,10 +195,8 @@  void RkISP1Path::stop()
 namespace {
 constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 };
 constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 };
-constexpr std::array<PixelFormat, 7> RKISP1_RSZ_MP_FORMATS{
+constexpr std::array<PixelFormat, 5> RKISP1_RSZ_MP_FORMATS{
 	formats::YUYV,
-	formats::YVYU,
-	formats::VYUY,
 	formats::NV16,
 	formats::NV61,
 	formats::NV21,
@@ -208,10 +206,8 @@  constexpr std::array<PixelFormat, 7> RKISP1_RSZ_MP_FORMATS{
 
 constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };
 constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };
-constexpr std::array<PixelFormat, 7> RKISP1_RSZ_SP_FORMATS{
+constexpr std::array<PixelFormat, 5> RKISP1_RSZ_SP_FORMATS{
 	formats::YUYV,
-	formats::YVYU,
-	formats::VYUY,
 	formats::NV16,
 	formats::NV61,
 	formats::NV21,