| Message ID | 20200904095148.844292-3-kieran.bingham@ideasonboard.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series |
|
| Related | show |
Hello, On Fri, 4 Sep 2020 10:51:46 +0100 Kieran Bingham <kieran.bingham@ideasonboard.com> wrote: > The libcamera project has moved to C++17. Update the toolchain > requirements accordingly. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Is this fixing some specific autobuilder failure ? If so, do you have a reference ? Thanks! Thomas
Hi Thomas, On 04/09/2020 13:51, Thomas Petazzoni wrote: > Hello, > > On Fri, 4 Sep 2020 10:51:46 +0100 > Kieran Bingham <kieran.bingham@ideasonboard.com> wrote: > >> The libcamera project has moved to C++17. Update the toolchain >> requirements accordingly. >> >> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Is this fixing some specific autobuilder failure ? If so, do you have a > reference ? No, that's a pre-requisite for patch 3/3. libcamera is now built with C++17 as a minimum requirement. > Thanks! > > Thomas
On Fri, 4 Sep 2020 13:55:17 +0100 Kieran Bingham <kieran.bingham@ideasonboard.com> wrote: > No, that's a pre-requisite for patch 3/3. > > libcamera is now built with C++17 as a minimum requirement. In this case, we'll squash 2/3 and 3/3 together. Thanks! Thomas
Kieran, All, On 2020-09-04 13:55 +0100, Kieran Bingham spake thusly: > On 04/09/2020 13:51, Thomas Petazzoni wrote: > > On Fri, 4 Sep 2020 10:51:46 +0100 > > Kieran Bingham <kieran.bingham@ideasonboard.com> wrote: > > > >> The libcamera project has moved to C++17. Update the toolchain > >> requirements accordingly. > >> > >> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > Is this fixing some specific autobuilder failure ? If so, do you have a > > reference ? > > No, that's a pre-requisite for patch 3/3. > libcamera is now built with C++17 as a minimum requirement. So the C++17 requirement comes with the version bump. In this case, it should be a single patch: bump and add new requirements. Otherwise, if we end up not applying, or reverting patch 3, then C++17 requirement is superfluous on its own. Regards, Yann E. MORIN.
diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in index 1ea747d1c57e..262ea49a0ead 100644 --- a/package/libcamera/Config.in +++ b/package/libcamera/Config.in @@ -2,7 +2,7 @@ menuconfig BR2_PACKAGE_LIBCAMERA bool "libcamera" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_TOOLCHAIN_HAS_THREADS - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14 + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17 depends on !BR2_STATIC_LIBS # gnutls depends on BR2_USE_WCHAR # gnutls # Invalid packing size of ControlValue struct on m68k @@ -65,6 +65,6 @@ config BR2_PACKAGE_LIBCAMERA_PIPELINE_VIMC endif # BR2_PACKAGE_LIBCAMERA -comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 5" +comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \ - !BR2_TOOLCHAIN_GCC_AT_LEAST_5 || BR2_STATIC_LIBS || !BR2_USE_WCHAR + !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || BR2_STATIC_LIBS || !BR2_USE_WCHAR
The libcamera project has moved to C++17. Update the toolchain requirements accordingly. Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- package/libcamera/Config.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)