[libcamera-devel,v4,10/13] android: camera_device: Report configuration changes from validate()
diff mbox series

Message ID 20200805151507.227503-11-kieran.bingham@ideasonboard.com
State Accepted
Headers show
Series
  • android: JPEG support
Related show

Commit Message

Kieran Bingham Aug. 5, 2020, 3:15 p.m. UTC 
When we call validate on a configuration, if there are any adjustments
on the configuration, we fail without showing why.

Display the stream configuration after the validate stage to aid
debugging stream startup failures.

Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---

v4
 - hyphenate instead.
---
 src/android/camera_device.cpp | 4 ++++
 1 file changed, 4 insertions(+)

Patch
diff mbox series 

diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
index a5c135ce03eb..397161a9ab12 100644
--- a/src/android/camera_device.cpp
+++ b/src/android/camera_device.cpp
@@ -1084,6 +1084,10 @@  int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)
 		break;
 	case CameraConfiguration::Adjusted:
 		LOG(HAL, Info) << "Camera configuration adjusted";
+
+		for (const StreamConfiguration &cfg : *config_)
+			LOG(HAL, Info) << " - " << cfg.toString();
+
 		config_.reset();
 		return -EINVAL;
 	case CameraConfiguration::Invalid: