From patchwork Wed Aug 5 15:15:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 9237 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4BD7FBD87B for ; Wed, 5 Aug 2020 15:15:20 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1488F60901; Wed, 5 Aug 2020 17:15:20 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="DS0CsY5f"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 871D9605C0 for ; Wed, 5 Aug 2020 17:15:16 +0200 (CEST) Received: from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F3BFA304; Wed, 5 Aug 2020 17:15:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1596640516; bh=Zj/gCjWtOnbMkj33ENuOYRQrWswY1/duO6JA/MbRItU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DS0CsY5fg3z/gBzgzbYkWQ8SmIIlOOO6mr+QP4/Ts3fimUwKCfIRaosBECH5weeyo B85kbOqZedk89tszPFk8nScmYGiwtkhhGBMg3RulKzv29klcVKQignhePm9wgViY+C oPE8RkZSOwkDiTgSf/DEkb8iGrv9f5vYRqzdkA04= From: Kieran Bingham To: libcamera devel Date: Wed, 5 Aug 2020 16:15:04 +0100 Message-Id: <20200805151507.227503-11-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200805151507.227503-1-kieran.bingham@ideasonboard.com> References: <20200805151507.227503-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 10/13] android: camera_device: Report configuration changes from validate() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When we call validate on a configuration, if there are any adjustments on the configuration, we fail without showing why. Display the stream configuration after the validate stage to aid debugging stream startup failures. Reviewed-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Signed-off-by: Kieran Bingham --- v4 - hyphenate instead. --- src/android/camera_device.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index a5c135ce03eb..397161a9ab12 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -1084,6 +1084,10 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list) break; case CameraConfiguration::Adjusted: LOG(HAL, Info) << "Camera configuration adjusted"; + + for (const StreamConfiguration &cfg : *config_) + LOG(HAL, Info) << " - " << cfg.toString(); + config_.reset(); return -EINVAL; case CameraConfiguration::Invalid: