[libcamera-devel,08/11] ipa: vimc: Add a dummy configuration file to the vimc IPA

Message ID 20200427031713.14013-9-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • libcamera: Add support for IPA configuration
Related show

Commit Message

Laurent Pinchart April 27, 2020, 3:17 a.m. UTC
The file will be used to test the corresponding APIs.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/ipa/vimc/data/meson.build | 6 ++++++
 src/ipa/vimc/data/vimc.conf   | 1 +
 src/ipa/vimc/meson.build      | 2 ++
 3 files changed, 9 insertions(+)
 create mode 100644 src/ipa/vimc/data/meson.build
 create mode 100644 src/ipa/vimc/data/vimc.conf

Comments

Jacopo Mondi April 27, 2020, 9:14 a.m. UTC | #1
Hi Laurent,

On Mon, Apr 27, 2020 at 06:17:10AM +0300, Laurent Pinchart wrote:
> The file will be used to test the corresponding APIs.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
  j

> ---
>  src/ipa/vimc/data/meson.build | 6 ++++++
>  src/ipa/vimc/data/vimc.conf   | 1 +
>  src/ipa/vimc/meson.build      | 2 ++
>  3 files changed, 9 insertions(+)
>  create mode 100644 src/ipa/vimc/data/meson.build
>  create mode 100644 src/ipa/vimc/data/vimc.conf
>
> diff --git a/src/ipa/vimc/data/meson.build b/src/ipa/vimc/data/meson.build
> new file mode 100644
> index 000000000000..c844926da7f2
> --- /dev/null
> +++ b/src/ipa/vimc/data/meson.build
> @@ -0,0 +1,6 @@
> +conf_files = files([
> +    'vimc.conf',
> +])
> +
> +install_data(conf_files,
> +             install_dir : join_paths(ipa_data_dir, 'vimc'))
> diff --git a/src/ipa/vimc/data/vimc.conf b/src/ipa/vimc/data/vimc.conf
> new file mode 100644
> index 000000000000..b3cda75801e2
> --- /dev/null
> +++ b/src/ipa/vimc/data/vimc.conf
> @@ -0,0 +1 @@
> +# Dummy configuration file for the vimc IPA.
> diff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build
> index a354096d8496..f8650ee80461 100644
> --- a/src/ipa/vimc/meson.build
> +++ b/src/ipa/vimc/meson.build
> @@ -17,3 +17,5 @@ if ipa_sign_module
>                    install : true,
>                    install_dir : ipa_install_dir)
>  endif
> +
> +subdir('data')
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
Kieran Bingham April 27, 2020, 2:14 p.m. UTC | #2
Hi Laurent,

On 27/04/2020 04:17, Laurent Pinchart wrote:
> The file will be used to test the corresponding APIs.
> 

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  src/ipa/vimc/data/meson.build | 6 ++++++
>  src/ipa/vimc/data/vimc.conf   | 1 +
>  src/ipa/vimc/meson.build      | 2 ++
>  3 files changed, 9 insertions(+)
>  create mode 100644 src/ipa/vimc/data/meson.build
>  create mode 100644 src/ipa/vimc/data/vimc.conf
> 
> diff --git a/src/ipa/vimc/data/meson.build b/src/ipa/vimc/data/meson.build
> new file mode 100644
> index 000000000000..c844926da7f2
> --- /dev/null
> +++ b/src/ipa/vimc/data/meson.build
> @@ -0,0 +1,6 @@
> +conf_files = files([
> +    'vimc.conf',
> +])
> +
> +install_data(conf_files,
> +             install_dir : join_paths(ipa_data_dir, 'vimc'))
> diff --git a/src/ipa/vimc/data/vimc.conf b/src/ipa/vimc/data/vimc.conf
> new file mode 100644
> index 000000000000..b3cda75801e2
> --- /dev/null
> +++ b/src/ipa/vimc/data/vimc.conf
> @@ -0,0 +1 @@
> +# Dummy configuration file for the vimc IPA.
> diff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build
> index a354096d8496..f8650ee80461 100644
> --- a/src/ipa/vimc/meson.build
> +++ b/src/ipa/vimc/meson.build
> @@ -17,3 +17,5 @@ if ipa_sign_module
>                    install : true,
>                    install_dir : ipa_install_dir)
>  endif
> +
> +subdir('data')
>

Patch

diff --git a/src/ipa/vimc/data/meson.build b/src/ipa/vimc/data/meson.build
new file mode 100644
index 000000000000..c844926da7f2
--- /dev/null
+++ b/src/ipa/vimc/data/meson.build
@@ -0,0 +1,6 @@ 
+conf_files = files([
+    'vimc.conf',
+])
+
+install_data(conf_files,
+             install_dir : join_paths(ipa_data_dir, 'vimc'))
diff --git a/src/ipa/vimc/data/vimc.conf b/src/ipa/vimc/data/vimc.conf
new file mode 100644
index 000000000000..b3cda75801e2
--- /dev/null
+++ b/src/ipa/vimc/data/vimc.conf
@@ -0,0 +1 @@ 
+# Dummy configuration file for the vimc IPA.
diff --git a/src/ipa/vimc/meson.build b/src/ipa/vimc/meson.build
index a354096d8496..f8650ee80461 100644
--- a/src/ipa/vimc/meson.build
+++ b/src/ipa/vimc/meson.build
@@ -17,3 +17,5 @@  if ipa_sign_module
                   install : true,
                   install_dir : ipa_install_dir)
 endif
+
+subdir('data')