| Message ID | 20200427031713.14013-4-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, On Mon, Apr 27, 2020 at 06:17:05AM +0300, Laurent Pinchart wrote: > The message printed when loading a proxy worker from the build directory > is missing a space. Add it. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > --- > src/libcamera/ipa_proxy.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp > index 5fd88a4ba75e..22b246be5797 100644 > --- a/src/libcamera/ipa_proxy.cpp > +++ b/src/libcamera/ipa_proxy.cpp > @@ -102,7 +102,7 @@ std::string IPAProxy::resolvePath(const std::string &file) const > std::string ipaProxyDir = root + "src/libcamera/proxy/worker"; > > LOG(IPAProxy, Info) > - << "libcamera is not installed. Loading proxy workers from'" > + << "libcamera is not installed. Loading proxy workers from '" > << ipaProxyDir << "'"; > > std::string proxyPath = ipaProxyDir + proxyFile; > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi LAurent, On Mon, Apr 27, 2020 at 06:17:05AM +0300, Laurent Pinchart wrote: > The message printed when loading a proxy worker from the build directory > is missing a space. Add it. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > --- > src/libcamera/ipa_proxy.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp > index 5fd88a4ba75e..22b246be5797 100644 > --- a/src/libcamera/ipa_proxy.cpp > +++ b/src/libcamera/ipa_proxy.cpp > @@ -102,7 +102,7 @@ std::string IPAProxy::resolvePath(const std::string &file) const > std::string ipaProxyDir = root + "src/libcamera/proxy/worker"; > > LOG(IPAProxy, Info) > - << "libcamera is not installed. Loading proxy workers from'" > + << "libcamera is not installed. Loading proxy workers from '" > << ipaProxyDir << "'"; > > std::string proxyPath = ipaProxyDir + proxyFile; > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
I really like this patch, I've reviewed it twice! On Mon, Apr 27, 2020 at 06:17:05AM +0300, Laurent Pinchart wrote: > The message printed when loading a proxy worker from the build directory > is missing a space. Add it. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/ipa_proxy.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp > index 5fd88a4ba75e..22b246be5797 100644 > --- a/src/libcamera/ipa_proxy.cpp > +++ b/src/libcamera/ipa_proxy.cpp > @@ -102,7 +102,7 @@ std::string IPAProxy::resolvePath(const std::string &file) const > std::string ipaProxyDir = root + "src/libcamera/proxy/worker"; > > LOG(IPAProxy, Info) > - << "libcamera is not installed. Loading proxy workers from'" > + << "libcamera is not installed. Loading proxy workers from '" > << ipaProxyDir << "'"; > > std::string proxyPath = ipaProxyDir + proxyFile; > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp index 5fd88a4ba75e..22b246be5797 100644 --- a/src/libcamera/ipa_proxy.cpp +++ b/src/libcamera/ipa_proxy.cpp @@ -102,7 +102,7 @@ std::string IPAProxy::resolvePath(const std::string &file) const std::string ipaProxyDir = root + "src/libcamera/proxy/worker"; LOG(IPAProxy, Info) - << "libcamera is not installed. Loading proxy workers from'" + << "libcamera is not installed. Loading proxy workers from '" << ipaProxyDir << "'"; std::string proxyPath = ipaProxyDir + proxyFile;
The message printed when loading a proxy worker from the build directory is missing a space. Add it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/libcamera/ipa_proxy.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)