[libcamera-devel,11/21] qcam: main_window: Remove unneeded debug message
diff mbox series

Message ID 20200323142205.28342-12-laurent.pinchart@ideasonboard.com
State Superseded
Headers show
Series
  • qcam: Bypass format conversion when not required
Related show

Commit Message

Laurent Pinchart March 23, 2020, 2:21 p.m. UTC 
Printing the name of the selected camera to the log doesn't provide any
value. Remove it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/qcam/main_window.cpp | 2 --
 1 file changed, 2 deletions(-)

Comments

Kieran Bingham March 23, 2020, 3:50 p.m. UTC | #1 
Hi Laurent,

On 23/03/2020 14:21, Laurent Pinchart wrote:
> Printing the name of the selected camera to the log doesn't provide any
> value. Remove it.

Agreed,

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  src/qcam/main_window.cpp | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp
> index 21a8fcfe711d..ed8301502fb2 100644
> --- a/src/qcam/main_window.cpp
> +++ b/src/qcam/main_window.cpp
> @@ -247,8 +247,6 @@ int MainWindow::openCamera()
>  		return -EBUSY;
>  	}
>  
> -	std::cout << "Using camera " << camera_->name() << std::endl;
> -
>  	return 0;
>  }
>  
>

Patch
diff mbox series 

diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp
index 21a8fcfe711d..ed8301502fb2 100644
--- a/src/qcam/main_window.cpp
+++ b/src/qcam/main_window.cpp
@@ -247,8 +247,6 @@  int MainWindow::openCamera()
 		return -EBUSY;
 	}
 
-	std::cout << "Using camera " << camera_->name() << std::endl;
-
 	return 0;
 }