[libcamera-devel,09/21] qcam: main_window: Don't print message when saving a picture
diff mbox series

Message ID 20200323142205.28342-10-laurent.pinchart@ideasonboard.com
State Superseded
Headers show
Series
  • qcam: Bypass format conversion when not required
Related show

Commit Message

Laurent Pinchart March 23, 2020, 2:21 p.m. UTC 
When saving a picture, the application prints a message on cout. This
isn't necessary and doesn't really help with debugging or diagnostics,
remove it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/qcam/main_window.cpp | 3 ---
 1 file changed, 3 deletions(-)

Comments

Kieran Bingham March 23, 2020, 3:42 p.m. UTC | #1 
On 23/03/2020 14:21, Laurent Pinchart wrote:
> When saving a picture, the application prints a message on cout. This
> isn't necessary and doesn't really help with debugging or diagnostics,
> remove it.

Oh ... it helped me while I was making it at least ;-)

But it probably isn't required indeed.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  src/qcam/main_window.cpp | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp
> index 18aae07ffce7..7aaa73e9a709 100644
> --- a/src/qcam/main_window.cpp
> +++ b/src/qcam/main_window.cpp
> @@ -406,9 +406,6 @@ void MainWindow::saveImageAs()
>  
>  	QString filename = QFileDialog::getSaveFileName(this, "Save Image", defaultPath,
>  							"Image Files (*.png *.jpg *.jpeg)");
> -
> -	std::cout << "Save image to " << filename.toStdString() << std::endl;
> -
>  	if (filename.isEmpty())
>  		return;
>  
>

Patch
diff mbox series 

diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp
index 18aae07ffce7..7aaa73e9a709 100644
--- a/src/qcam/main_window.cpp
+++ b/src/qcam/main_window.cpp
@@ -406,9 +406,6 @@  void MainWindow::saveImageAs()
 
 	QString filename = QFileDialog::getSaveFileName(this, "Save Image", defaultPath,
 							"Image Files (*.png *.jpg *.jpeg)");
-
-	std::cout << "Save image to " << filename.toStdString() << std::endl;
-
 	if (filename.isEmpty())
 		return;