| Message ID | 20200318115846.7975-7-kgupta@es.iitr.ac.in |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Kaaira, Thank you for the patch. On Wed, Mar 18, 2020 at 05:28:46PM +0530, Kaaira Gupta wrote: > The tests declare a hard-coded LIBCAMERA_IPA_PROXY_PATH to allow tests > to run from tests-suite. > > Now that the proxy path is determined at runtime, we can remove the > redundant setting of LIBCAMERA_IPA_PROXY_PATH for tests. > > Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > test/libtest/test.cpp | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/test/libtest/test.cpp b/test/libtest/test.cpp > index 6cd3fbe..fd9f3d7 100644 > --- a/test/libtest/test.cpp > +++ b/test/libtest/test.cpp > @@ -21,10 +21,6 @@ int Test::execute() > { > int ret; > > - ret = setenv("LIBCAMERA_IPA_PROXY_PATH", "src/libcamera/proxy/worker", 1); > - if (ret) > - return errno; > - > ret = init(); > if (ret) > return ret;
Hi Kaaira, On 18/03/2020 11:58, Kaaira Gupta wrote: > The tests declare a hard-coded LIBCAMERA_IPA_PROXY_PATH to allow tests > to run from tests-suite. > > Now that the proxy path is determined at runtime, we can remove the > redundant setting of LIBCAMERA_IPA_PROXY_PATH for tests. > > Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in> Please add tags to patches when you get them. I have given: Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> in V1, and you can keep it on the patch :-) (Especially if the patch doesn't change) > --- > test/libtest/test.cpp | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/test/libtest/test.cpp b/test/libtest/test.cpp > index 6cd3fbe..fd9f3d7 100644 > --- a/test/libtest/test.cpp > +++ b/test/libtest/test.cpp > @@ -21,10 +21,6 @@ int Test::execute() > { > int ret; > > - ret = setenv("LIBCAMERA_IPA_PROXY_PATH", "src/libcamera/proxy/worker", 1); > - if (ret) > - return errno; > - > ret = init(); > if (ret) > return ret; >
diff --git a/test/libtest/test.cpp b/test/libtest/test.cpp index 6cd3fbe..fd9f3d7 100644 --- a/test/libtest/test.cpp +++ b/test/libtest/test.cpp @@ -21,10 +21,6 @@ int Test::execute() { int ret; - ret = setenv("LIBCAMERA_IPA_PROXY_PATH", "src/libcamera/proxy/worker", 1); - if (ret) - return errno; - ret = init(); if (ret) return ret;
The tests declare a hard-coded LIBCAMERA_IPA_PROXY_PATH to allow tests to run from tests-suite. Now that the proxy path is determined at runtime, we can remove the redundant setting of LIBCAMERA_IPA_PROXY_PATH for tests. Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in> --- test/libtest/test.cpp | 4 ---- 1 file changed, 4 deletions(-)