ipa: rpi: Fix vd56g3 tuning files syntax
diff mbox series

Message ID 20261120-fix-vd56g3-tuning-comment-v1-1-be3d082f8505@foss.st.com
State New
Headers show
Series
  • ipa: rpi: Fix vd56g3 tuning files syntax
Related show

Commit Message

Benjamin Mugnier Nov. 20, 2026, 3:27 p.m. UTC
"/* */" style comments are not supported in json, resulting in the
parser failing to read the file.

As markdown does not support comments of any sort, rely on a unused
'comment' property instead.

Add the same comment in vc4 ipa while at it.

Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
---
 src/ipa/rpi/pisp/data/vd56g3.json | 2 +-
 src/ipa/rpi/vc4/data/vd56g3.json  | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)


---
base-commit: 4b08fac2ccf8ee6d9a73ca24e20bd0f46eb76b5e
change-id: 20261118-fix-vd56g3-tuning-comment-b1b9537fd362

Best regards,
--  
Benjamin Mugnier <benjamin.mugnier@foss.st.com>

Comments

Kieran Bingham Nov. 20, 2026, 4:04 p.m. UTC | #1
Quoting Benjamin Mugnier (2026-11-20 15:27:05)
> "/* */" style comments are not supported in json, resulting in the
> parser failing to read the file.
> 
> As markdown does not support comments of any sort, rely on a unused
> 'comment' property instead.
> 
> Add the same comment in vc4 ipa while at it.
> 
> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>


Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/ipa/rpi/pisp/data/vd56g3.json | 2 +-
>  src/ipa/rpi/vc4/data/vd56g3.json  | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/src/ipa/rpi/pisp/data/vd56g3.json b/src/ipa/rpi/pisp/data/vd56g3.json
> index 67b6d96f43fb..89fbc3641e85 100644
> --- a/src/ipa/rpi/pisp/data/vd56g3.json
> +++ b/src/ipa/rpi/pisp/data/vd56g3.json
> @@ -1,7 +1,7 @@
> -/* HD-61201 lens */
>  {
>      "version": 2.0,
>      "target": "pisp",
> +    "comment": "HD-61201 lens",
>      "algorithms": [
>          {
>              "rpi.black_level":
> diff --git a/src/ipa/rpi/vc4/data/vd56g3.json b/src/ipa/rpi/vc4/data/vd56g3.json
> index 2d7e0abb2985..e8fbf58d4576 100644
> --- a/src/ipa/rpi/vc4/data/vd56g3.json
> +++ b/src/ipa/rpi/vc4/data/vd56g3.json
> @@ -1,6 +1,7 @@
>  {
>      "version": 2.0,
>      "target": "bcm2835",
> +    "comment": "HD-61201 lens",
>      "algorithms": [
>          {
>              "rpi.black_level":
> @@ -446,4 +447,4 @@
>              }
>          }
>      ]
> -}
> \ No newline at end of file
> +}
> 
> ---
> base-commit: 4b08fac2ccf8ee6d9a73ca24e20bd0f46eb76b5e
> change-id: 20261118-fix-vd56g3-tuning-comment-b1b9537fd362
> 
> Best regards,
> --  
> Benjamin Mugnier <benjamin.mugnier@foss.st.com>
>

Patch
diff mbox series

diff --git a/src/ipa/rpi/pisp/data/vd56g3.json b/src/ipa/rpi/pisp/data/vd56g3.json
index 67b6d96f43fb..89fbc3641e85 100644
--- a/src/ipa/rpi/pisp/data/vd56g3.json
+++ b/src/ipa/rpi/pisp/data/vd56g3.json
@@ -1,7 +1,7 @@ 
-/* HD-61201 lens */
 {
     "version": 2.0,
     "target": "pisp",
+    "comment": "HD-61201 lens",
     "algorithms": [
         {
             "rpi.black_level":
diff --git a/src/ipa/rpi/vc4/data/vd56g3.json b/src/ipa/rpi/vc4/data/vd56g3.json
index 2d7e0abb2985..e8fbf58d4576 100644
--- a/src/ipa/rpi/vc4/data/vd56g3.json
+++ b/src/ipa/rpi/vc4/data/vd56g3.json
@@ -1,6 +1,7 @@ 
 {
     "version": 2.0,
     "target": "bcm2835",
+    "comment": "HD-61201 lens",
     "algorithms": [
         {
             "rpi.black_level":
@@ -446,4 +447,4 @@ 
             }
         }
     ]
-}
\ No newline at end of file
+}