From patchwork Fri Nov 20 15:27:05 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Mugnier X-Patchwork-Id: 29063 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B0DB4C3304 for ; Fri, 20 Nov 2026 15:26:54 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3529F6A946; Fri, 20 Nov 2026 16:26:53 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="boZvGx/t"; dkim-atps=neutral Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazlp170110003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c207::3]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D158B6A936 for ; Fri, 20 Nov 2026 16:26:51 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cl1jlRHYzOEiPyjUmi0yFNEj4ufp/9mHVTk1ZovK9GlgeugpOpamcpP6bGOhmzOF5zKoxAkdmmmMI4x5dZ9v8mLdJUdyLofr5b4WtLQJXtRSoWQUYsfjVcBUetfHkaWijpk2yCQTzIZNcWmq6QSJn06rHd7o9op7mAKwHLVo1IPyBILRIMv6n5w7ulEss8fmeJDzZaWepoiUUIGhAWCFBQDh6KJTNMjZkEm5RnryS5oQfHyPHhettnyQEeCvmIScxb3f24643H7Gb3eVuhHJI+YdIFYd2TBu34h+YOGFnR70c1y5MzA8ujA0F4ApfWTKsSt0UDkJfRwOnexY7pDDNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VIiYvq9u+0TS7bVw5/mTmAy7r8TR6GwqU+5SXd3pEAY=; b=DbEOVhpFASpYxfFBwBh4iOkPZ5HS4QHd9ulUKSO49Ixm8xXy/cN4/1SxRxYAkzNc7po8YkRur62lVvP6CnnPVPJKULCZJ6wn4rHiDV/cIKDMXJ8za4q9sRWWnG/Mm2Wzyj4v4jFwdTZmJNaxua4c2P42CzLt2dyHmpy+lbaC49YYiwN8y+sGorxdWthxzjma2idNI1AXVdUJNggiveJ61gdFy42MrSzxJwod6BCeksR/CBibvFKEZJ1WirEv9Yxr0RwwjVkgSzbdMZCXQkO4JoVTQ8bzd4vxbmVi0KYxVgXsHuA8WyRpOj3bBwofnEhsaaBbTXgG/6AkzTCn0A/tSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.59) smtp.rcpttodomain=lists.libcamera.org smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VIiYvq9u+0TS7bVw5/mTmAy7r8TR6GwqU+5SXd3pEAY=; b=boZvGx/t1waFFY7gHRpXo4Zz9P9U1xxmw43vS1SlhF5t7kMBHnetL4gKdf56ACzg+7tRcv9BmwYk/kInVl5wDlREl/TYaZeb2SWCX9I1wojtW/ZmK+2zjqA2akCUnCqUp/IalB2pTYaRydBikiXzHmtufqMnP2sYY3EfNntCyQ1f6LHChxl9pvUPztcwkrs0L705Xx5Pyhwg0XSNS+gW/24mRH/GdnhhmeRHI0B9EHB6VhKDkM/bSPPua8w6Bk3bKuAGUUhkHC80CoVZJeSVJsQ+wJtQ0+CnWhxnysqZkgdso8yCQj9OfzEdXjXXg6ErmfK+R9HMkRi36WN+t88FhA== Received: from PR3P189CA0051.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::26) by DU4PR10MB639687.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:5d4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.662.2; Fri, 20 Nov 2026 15:26:38 +0000 Received: from MI3PEPF0000849C.eurprd03.prod.outlook.com (2603:10a6:102:53:cafe::66) by PR3P189CA0051.outlook.office365.com (2603:10a6:102:53::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.639.12 via Frontend Transport; Fri, 20 Nov 2026 15:26:38 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=fail (sender IP is 164.130.1.59) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.59 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.59; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.59) by MI3PEPF0000849C.mail.protection.outlook.com (10.167.240.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.639.5 via Frontend Transport; Fri, 20 Nov 2026 15:26:37 +0000 Received: from STKDAG1NODE2.st.com (10.75.128.133) by smtpo365.st.com (10.250.44.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.56; Fri, 20 Nov 2026 16:27:23 +0100 Received: from localhost (10.130.78.67) by STKDAG1NODE2.st.com (10.75.128.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Fri, 20 Nov 2026 16:26:37 +0100 From: Benjamin Mugnier Date: Fri, 20 Nov 2026 16:27:05 +0100 Subject: [PATCH] ipa: rpi: Fix vd56g3 tuning files syntax MIME-Version: 1.0 Message-ID: <20261120-fix-vd56g3-tuning-comment-v1-1-be3d082f8505@foss.st.com> X-B4-Tracking: v=1; b=H4sIAMhmAGsC/yXMywrCMBCF4Vcps3bASWi8vIp0YZJpHKFTSdIil L67UZcfnPNvUDgLF7h2G2RepcisDXToIDzumhglNoM5GkdEZxzljWvsXbJYFxVNGOZpYq3oyV9 6exqjdQba/5W5jX/t2/B3WfyTQ/0GYd8/Sv8yzn0AAAA= X-Change-ID: 20261118-fix-vd56g3-tuning-comment-b1b9537fd362 To: CC: Benjamin Mugnier X-Mailer: b4 0.15.2 X-Originating-IP: [10.130.78.67] X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE2.st.com (10.75.128.133) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF0000849C:EE_|DU4PR10MB639687:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b5216f8-1406-4f27-52c6-08df471aab4f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|376014|1800799024|36860700016|82310400026|261026140227099003|261028144727099003|56012099006|11063799006|261009223027099003|261021121427099003|261022105027099003|261021123027099003|10067099003|261102123227099003|261026121527099003|9063799003|18002099003|3023799007; X-Microsoft-Antispam-Message-Info: Coqges7gBDDITvDrwKminUtEFkGJmWebGW5MI64iDhBnWwg0m55tCZxZdqJzX6Rn6Cz8Rv1UMb/e7un+P5H0jkpY8y+FqBRQ+FQZGTFqsdrpGqNL/+31SM4q+rzjoZM/YHlVeHqnmgQ3U+jcxzmBcuxO5hUTajFQgOk001OF5fZnary8h6vSRYyCSQHk1HkgHVC1tUICBp7kgjXuC7br60MHLIO8GQ16VYWNCRsY0/I4evIX8L7tynW1+3ejmY5AyW0PuL7/CrtuayzDrx7vlXIySrg+8IwaxmL0Yf1Rpo4wRepD/Dy5mYa+zKuJvnYGXBhqxel3fEmxqL8P8zEz45Ez/0576U1Im1+9B5irXL7DJ9iDtT4H7Du8Al9PDlVQfWRj+0kvxQ3XVHUc3SgOUr+cCg8My5wU4wruaAHq2slHfmjmoktIVtaB0AJPWJtt+UGcnBeF2gem3WArjDDmOu+AHlL//0fTVHvAPZMv92BfPZGop/KZznuDNMIvwdzh9RaxmQ++8PohlfTFulAUS4tUR8IEL1eykLJ3vPuYWCj7VMI5crWNmhTwFFWb9CWFUaKAPbtwV82XY6MGjVB5VE5dpwq60Omgc5tBmB3Om93IKs3HRhDL3yRVIFKyFgOTcSRHbBqtms0aIZmhn+EJQoQIYtRyVbobwsx+hPGs2cTyB6/Ead2+3Lhe4ckiDmGykTUSLwjqV0ZcfU5Qd2qflA== X-Forefront-Antispam-Report: CIP:164.130.1.59; CTRY:IT; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:smtpO365.st.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(23010399003)(376014)(1800799024)(36860700016)(82310400026)(261026140227099003)(261028144727099003)(56012099006)(11063799006)(261009223027099003)(261021121427099003)(261022105027099003)(261021123027099003)(10067099003)(261102123227099003)(261026121527099003)(9063799003)(18002099003)(3023799007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1Kvr4bd9MjwpYCY72PqoxzCvc11bEtSz+bmk2F49/7iKfwnZS76mpCgZq2vK/skR43t1Y7Rc3GlTuRhPCXp/fNo4ouCrPLHZDJhSsJDogvMzFqFlZKJ0Fy7o6YwUWBFoyhUBmhLHoES2KQcVvXnlKptkLxieystZMtgN6OhX7VD9bNK+OWqI71auG7pV0Csv0HL8JPM+/iHUd0tEixkz7+KUzvhdkmfqC4qqL0CtSbOCYh3mZZjSQuM+gVPLrMuAqVs2Y2KIi9vcx2TgJudQtgWC+O8/qLMSh1hXRrU48W6TT3VPoADdo0AhZTxNge0JvRYRLE1J3a/Gcj8P7ZUbnptxyyHVf+FLYEjMYu2ZX64bWXLqRA6t3xBDvULbfh8vtdhB5GbRsftaVOglw+642jGQVOijmiIz8UsNi9A1o3O+JV+NwmuR5cuDNHkd45NR X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2026 15:26:37.8307 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4b5216f8-1406-4f27-52c6-08df471aab4f X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f; Ip=[164.130.1.59]; Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF0000849C.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR10MB639687 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" "/* */" style comments are not supported in json, resulting in the parser failing to read the file. As markdown does not support comments of any sort, rely on a unused 'comment' property instead. Add the same comment in vc4 ipa while at it. Signed-off-by: Benjamin Mugnier Acked-by: Kieran Bingham --- src/ipa/rpi/pisp/data/vd56g3.json | 2 +- src/ipa/rpi/vc4/data/vd56g3.json | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) --- base-commit: 4b08fac2ccf8ee6d9a73ca24e20bd0f46eb76b5e change-id: 20261118-fix-vd56g3-tuning-comment-b1b9537fd362 Best regards, -- Benjamin Mugnier diff --git a/src/ipa/rpi/pisp/data/vd56g3.json b/src/ipa/rpi/pisp/data/vd56g3.json index 67b6d96f43fb..89fbc3641e85 100644 --- a/src/ipa/rpi/pisp/data/vd56g3.json +++ b/src/ipa/rpi/pisp/data/vd56g3.json @@ -1,7 +1,7 @@ -/* HD-61201 lens */ { "version": 2.0, "target": "pisp", + "comment": "HD-61201 lens", "algorithms": [ { "rpi.black_level": diff --git a/src/ipa/rpi/vc4/data/vd56g3.json b/src/ipa/rpi/vc4/data/vd56g3.json index 2d7e0abb2985..e8fbf58d4576 100644 --- a/src/ipa/rpi/vc4/data/vd56g3.json +++ b/src/ipa/rpi/vc4/data/vd56g3.json @@ -1,6 +1,7 @@ { "version": 2.0, "target": "bcm2835", + "comment": "HD-61201 lens", "algorithms": [ { "rpi.black_level": @@ -446,4 +447,4 @@ } } ] -} \ No newline at end of file +}